bridge: Add extack warning when enabling STP in netns.
Subsystems (3)
PATCH v2 1/1 bridge: Add extack warning when enabling STP in netns.
When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled.
# unshare -n
# ip link add br0 type bridge
# ip link add veth0 type veth peer name veth1
# ip link set veth0 master br0 up
# ip link set veth1 master br0 up
# ip link set br0 type bridge stp_state 1
# ip link set br0 up
# sleep 30
# ip -s link show br0
2: br0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
link/ether b6:61:98:1c:1c:b5 brd ff:ff:ff:ff:ff:ff
RX: bytes packets errors dropped missed mcast
956553768 12861249 0 0 0 12861249 <-. Keep
TX: bytes packets errors dropped carrier collsns | increasing
1027834 11951 0 0 0 0 <-' rapidlyThis is because llc_rcv() drops all packets in non-root netns and BPDU is dropped.
Let's add extack warning when enabling STP in netns.
# unshare -n # ip link add br0 type bridge # ip link set br0 type bridge stp_state 1 Warning: bridge: STP does not work in non-root netns.
Note this commit will be reverted later when we namespacify the whole LLC infra.
---
v2:
- Just add extack instead of returning error (Ido Schimmel)
v1: https://lore.kernel.org/netdev/[email protected]/
--- net/bridge/br_stp_if.c | 3 +++ 1 file changed, 3 insertions(+)
net/bridge/br_stp_if.c +3 -0
@@ -201,6 +201,9 @@ int br_stp_set_enabled(struct net_bridge *br, unsigned long val, {ASSERT_RTNL (); +if (!net_eq (dev_net (br->dev), &init_net)) +NL_SET_ERR_MSG_MOD (extack,"STP does not work in non-root netns" ); +if (br_mrp_enabled (br)) {NL_SET_ERR_MSG_MOD (extack,"STP can't be enabled if MRP is already enabled" );
Signature · 1 line
2.30.2
Quoted 51 lines · Kuniyuki Iwashima
When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled.
# unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up # ip link set veth1 master br0 up # ip link set br0 type bridge stp_state 1 # ip link set br0 up # sleep 30 # ip -s link show br0 2: br0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000 link/ether b6:61:98:1c:1c:b5 brd ff:ff:ff:ff:ff:ff RX: bytes packets errors dropped missed mcast 956553768 12861249 0 0 0 12861249 <-. Keep TX: bytes packets errors dropped carrier collsns | increasing 1027834 11951 0 0 0 0 <-' rapidlyThis is because
llc_rcv()drops all packets in non-root netns and BPDU is dropped.Let's add extack warning when enabling STP in netns.
# unshare -n # ip link add br0 type bridge # ip link set br0 type bridge stp_state 1 Warning: bridge: STP does not work in non-root netns.Note this commit will be reverted later when we namespacify the whole LLC infra.
Fixes e730c15519d0 ("[NET]: Make packet reception network namespace safe")Suggested-by Harry Coin <[email protected]>Suggested-by Ido Schimmel <[email protected]>Signed-off-by Kuniyuki Iwashima <[email protected]>---
v2:
- Just add extack instead of returning error (Ido Schimmel)v1: https://lore.kernel.org/netdev/[email protected]/
--- net/bridge/br_stp_if.c | 3 +++ 1 file changed, 3 insertions(+)net/bridge/br_stp_if.c +0
-0
net/bridge/br_stp_if.c int br_stp_set_enabled(struct net_bridge *br, unsigned long val, · line 209
Quoted 9 lines
net/bridge/br_stp_if.c +3
-0@@ -201,6 +201,9 @@ int br_stp_set_enabled(struct net_bridge *br, unsigned long val, {ASSERT_RTNL (); +if (!net_eq (dev_net (br->dev), &init_net)) +NL_SET_ERR_MSG_MOD (extack,"STP does not work in non-root netns" ); +if (br_mrp_enabled (br)) {NL_SET_ERR_MSG_MOD (extack,"STP can't be enabled if MRP is already enabled" );
Thanks,
Quoted 29 lines · Kuniyuki Iwashima
When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled.
# unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up # ip link set veth1 master br0 up # ip link set br0 type bridge stp_state 1 # ip link set br0 up # sleep 30 # ip -s link show br0 2: br0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000 link/ether b6:61:98:1c:1c:b5 brd ff:ff:ff:ff:ff:ff RX: bytes packets errors dropped missed mcast 956553768 12861249 0 0 0 12861249 <-. Keep TX: bytes packets errors dropped carrier collsns | increasing 1027834 11951 0 0 0 0 <-' rapidlyThis is because
llc_rcv()drops all packets in non-root netns and BPDU is dropped.Let's add extack warning when enabling STP in netns.
# unshare -n # ip link add br0 type bridge # ip link set br0 type bridge stp_state 1 Warning: bridge: STP does not work in non-root netns.
Quoted 8 lines
Note this commit will be reverted later when we namespacify the whole LLC infra.
Fixes e730c15519d0 ("[NET]: Make packet reception network namespace safe")Suggested-by Harry Coin <[email protected]>Suggested-by Ido Schimmel <[email protected]>Signed-off-by Kuniyuki Iwashima <[email protected]>
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 19 lines · On Wed, 12 Jul 2023 08:44:49 -0700 you wrote:
When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled.
# unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up # ip link set veth1 master br0 up # ip link set br0 type bridge stp_state 1 # ip link set br0 up # sleep 30 # ip -s link show br0 2: br0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000 link/ether b6:61:98:1c:1c:b5 brd ff:ff:ff:ff:ff:ff RX: bytes packets errors dropped missed mcast 956553768 12861249 0 0 0 12861249 <-. Keep TX: bytes packets errors dropped carrier collsns | increasing 1027834 11951 0 0 0 0 <-' rapidly
Quoted 1 line
[...]
Here is the summary with links:
- [v2,net] bridge: Add extack warning when enabling STP in netns.
https://git.kernel.org/netdev/net/c/56a16035bb6e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html