Skip to contentSkip to conversation

s390/qeth: Fix vipa deletion

PATCH Applied Alexandra Winter 3 participants 3 messages Jul 4, 2023 – Jul 5, 2023

Subsystems (4)
lore
Share & tools
lore

Alexandra Winter

author maintainer
#0 lore raw

PATCH 1/1 s390/qeth: Fix vipa deletion

From: Thorsten Winkler <[email protected]>

Change boolean parameter of function "qeth_l3_vipa_store" inside the "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because "true" is used for adding a virtual ip address and "false" for deleting.

Fixes 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")
---
 drivers/s390/net/qeth_l3_sys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/net/qeth_l3_sys.c +1 -1
index 9f90a860ca2c..a6b64228ead2 100644
@@ -625,7 +625,7 @@ static QETH_DEVICE_ATTR(vipa_add4, add4, 0644,
 static ssize_t qeth_l3_dev_vipa_del4_store(struct device *dev,
 		struct device_attribute *attr, const char *buf, size_t count)
 {
-	return qeth_l3_vipa_store(dev, buf, true, count, QETH_PROT_IPV4);
+	return qeth_l3_vipa_store(dev, buf, false, count, QETH_PROT_IPV4);
 }
 
 static QETH_DEVICE_ATTR(vipa_del4, del4, 0200, NULL,
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Alexandra Winter

From: Thorsten Winkler <[email protected]>

Change boolean parameter of function "qeth_l3_vipa_store" inside the "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because "true" is used for adding a virtual ip address and "false" for deleting.

Fixes 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")

nit: no blank line here.

Quoted 4 lines
#2 lore raw
In reply to Alexandra Winter
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 9 lines · On Tue, 4 Jul 2023 16:41:21 +0200 you wrote:

From: Thorsten Winkler <[email protected]>

Change boolean parameter of function "qeth_l3_vipa_store" inside the "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because "true" is used for adding a virtual ip address and "false" for deleting.

Fixes 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")

[...]

Here is the summary with links:
- [net] s390/qeth: Fix vipa deletion

    https://git.kernel.org/netdev/net/c/80de809bd35e

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html