Skip to contentSkip to conversation

xenoprof: default to off

PATCH In review Jan Beulich 2 participants 2 messages Jul 10, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xenoprof: default to off

This being x86-only right now, and its x86 bits being heavily outdated, let's no longer enable this by default.

While there also adjust the "help" keyword spelling.

---
The adjustment to pvshim_defconfig of course isn't strictly necessary, but I think the file would better have overrides for things that need a non-default setting. (Visible in context, BIGMEM would then probably also want dropping.) Yet if this causes concerns, I can certainly drop again this part of the change.

xen/arch/x86/configs/pvshim_defconfig +0 -1
@@ -13,7 +13,6 @@ CONFIG_EXPERT=y
 # CONFIG_HYPFS is not set
 # CONFIG_BIGMEM is not set
 # CONFIG_KEXEC is not set
-# CONFIG_XENOPROF is not set
 # CONFIG_XSM is not set
 # CONFIG_UNSUPPORTED is not set
 # CONFIG_SCHED_CREDIT is not set
xen/common/Kconfig +2 -3
@@ -229,10 +229,9 @@ config EFI_SET_VIRTUAL_ADDRESS_MAP
       If unsure, say N.
 
 config XENOPROF
-	def_bool y
-	prompt "Xen Oprofile Support" if EXPERT
+	bool "Xen Oprofile Support" if EXPERT
 	depends on X86
-	---help---
+	help
 	  Xen OProfile (Xenoprof) is a system-wide profiler for Xen virtual
 	  machine environments, capable of profiling the Xen virtual machine
 	  monitor, multiple Linux guest operating systems, and applications