Skip to contentSkip to conversation

Input: tegra-kbc - use devm_platform_ioremap_resource

PATCH Applied Martin Kaiser 3 participants 3 messages Jul 9, 2023 – Jul 10, 2023

Subsystems (4)
HID Tegra architecture support Input drivers Tegra kbc driver
lore
Share & tools
lore

Martin Kaiser

author
#0 lore raw

PATCH 1/1 Input: tegra-kbc - use devm_platform_ioremap_resource

devm_platform_get_and_ioremap_resource maps a resource and returns its physical address. If we don't need the physical address, we should call devm_platform_ioremap_resource instead.

Signed-off-by Martin Kaiser <[email protected]>
---
 drivers/input/keyboard/tegra-kbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/tegra-kbc.c +1 -1
index d5a6c7d8eb25..c9a823ea45d0 100644
@@ -640,7 +640,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
 
 	timer_setup(&kbc->timer, tegra_kbc_keypress_timer, 0);
 
-	kbc->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
+	kbc->mmio = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(kbc->mmio))
 		return PTR_ERR(kbc->mmio);
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Martin Kaiser

devm_platform_get_and_ioremap_resource maps a resource and returns its physical address. If we don't need the physical address, we should call devm_platform_ioremap_resource instead.

Signed-off-by Martin Kaiser <[email protected]>
---
 drivers/input/keyboard/tegra-kbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Different variations of these have been going around for a while now. I don't really see much use in these tiny conversions.

But the patch also isn't wrong, so while I'm at it:

Acked-by Thierry Reding <[email protected]>
Quoted 17 lines
drivers/input/keyboard/tegra-kbc.c +1 -1
index d5a6c7d8eb25..c9a823ea45d0 100644
@@ -640,7 +640,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
 
 	timer_setup(&kbc->timer, tegra_kbc_keypress_timer, 0);
 
-	kbc->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
+	kbc->mmio = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(kbc->mmio))
 		return PTR_ERR(kbc->mmio);
Signature · 1 line
2.30.2