sparc: Use shared font data
PATCH v2 1/1 sparc: Use shared font data
From: "Dr. David Alan Gilbert" <[email protected]>
sparc has a 'btext' font used for the console which is almost identical to the shared font_sun8x16, so use it rather than duplicating the data.
They were actually identical until about a decade ago when
commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
"broken bar" to "vertical line"")
which changed the | in the shared font to be a solid bar rather than a broken bar. That's the only difference.
This was originally spotted by PMD which noticed that PPC does the same thing with the same data, and they also share a bunch of functions to manipulate the data. The PPC code and the functions I'll look at another time if this patch is OK.
Tested very lightly with a boot without FS in qemu.
--- arch/sparc/Kconfig | 1 + arch/sparc/kernel/btext.c | 365 +------------------------------------- 2 files changed, 10 insertions(+), 356 deletions(-)
arch/sparc/Kconfig +1 -0
@@ -219,6 +219,7 @@ config EARLYFB bool "Support for early boot text console" default y depends on SPARC64 + select FONT_SUN8x16 help Say Y here to enable a faster early framebuffer boot console.
arch/sparc/kernel/btext.c +9 -356
410 lines not on this page · raw message
Signature · 1 line
2.41.0
Quoted 12 lines · On Tue, Jul 25, 2023 at 12:58:51AM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
sparc has a 'btext' font used for the console which is almost identical to the shared
font_sun8x16, so use it rather than duplicating the data.They were actually identical until about a decade ago when
commitbcfbeecea11c("drivers: console:font_: Change a glyph from
"broken bar" to "vertical line"")which changed the | in the shared font to be a solid bar rather than a broken bar. That's the only difference.
Quoted 8 lines
This was originally spotted by PMD which noticed that PPC does the same thing with the same data, and they also share a bunch of functions to manipulate the data. The PPC code and the functions I'll look at another time if this patch is OK.
Tested very lightly with a boot without FS in qemu.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Looks good, thanks for the fixes.
Let's hope someone picks it up...
Sam
Quoted 18 lines · * Sam Ravnborg ([email protected]) wrote:
Quoted 17 lines · On Tue, Jul 25, 2023 at 12:58:51AM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
sparc has a 'btext' font used for the console which is almost identical to the shared
font_sun8x16, so use it rather than duplicating the data.They were actually identical until about a decade ago when
commitbcfbeecea11c("drivers: console:font_: Change a glyph from
"broken bar" to "vertical line"")which changed the | in the shared font to be a solid bar rather than a broken bar. That's the only difference.
This was originally spotted by PMD which noticed that PPC does the same thing with the same data, and they also share a bunch of functions to manipulate the data. The PPC code and the functions I'll look at another time if this patch is OK.
Quoted 6 lines
Quoted 3 lines
Tested very lightly with a boot without FS in qemu.
Signed-off-by Dr. David Alan Gilbert <[email protected]>Looks good, thanks for the fixes.
Reviewed-by Sam Ravnborg <[email protected]>
Thanks
Quoted 1 line
Let's hope someone picks it up...
I was hoping Dave would, but I realise Sparc doesn't get much these days.
Of course if anyone feels guilty about their own patches adding code they can take this patch to make ~340 lines of penance.
Dave
Quoted 1 line
Sam
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Hi Dave!
Quoted 26 lines · Dr. David Alan Gilbert
Quoted 18 lines · * Sam Ravnborg ([email protected]) wrote:
Quoted 17 lines · On Tue, Jul 25, 2023 at 12:58:51AM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
sparc has a 'btext' font used for the console which is almost identical to the shared
font_sun8x16, so use it rather than duplicating the data.They were actually identical until about a decade ago when
commitbcfbeecea11c("drivers: console:font_: Change a glyph from
"broken bar" to "vertical line"")which changed the | in the shared font to be a solid bar rather than a broken bar. That's the only difference.
This was originally spotted by PMD which noticed that PPC does the same thing with the same data, and they also share a bunch of functions to manipulate the data. The PPC code and the functions I'll look at another time if this patch is OK.
Quoted 6 lines
Quoted 3 lines
Tested very lightly with a boot without FS in qemu.
Signed-off-by Dr. David Alan Gilbert <[email protected]>Looks good, thanks for the fixes.
Reviewed-by Sam Ravnborg <[email protected]>
Quoted 8 lines
Thanks
Quoted 1 line
Let's hope someone picks it up...
I was hoping Dave would, but I realise Sparc doesn't get much these days.
Of course if anyone feels guilty about their own patches adding code they can take this patch to make ~340 lines of penance.
You can ask Andrew Morton to pick it up through his tree. He usually does that when no one else is willing to pick a patch up.
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Quoted 1 line · * John Paul Adrian Glaubitz ([email protected]) wrote:
Hi Dave!
Hi Adrian,
Quoted 31 lines · Dr. David Alan Gilbert
Quoted 30 lines · * Sam Ravnborg ([email protected]) wrote:
Quoted 18 lines · On Tue, Jul 25, 2023 at 12:58:51AM +0100, [email protected] wrote:
Quoted 17 lines
From: "Dr. David Alan Gilbert" <[email protected]>
sparc has a 'btext' font used for the console which is almost identical to the shared
font_sun8x16, so use it rather than duplicating the data.They were actually identical until about a decade ago when
commitbcfbeecea11c("drivers: console:font_: Change a glyph from
"broken bar" to "vertical line"")which changed the | in the shared font to be a solid bar rather than a broken bar. That's the only difference.
This was originally spotted by PMD which noticed that PPC does the same thing with the same data, and they also share a bunch of functions to manipulate the data. The PPC code and the functions I'll look at another time if this patch is OK.
Quoted 6 lines
Quoted 3 lines
Tested very lightly with a boot without FS in qemu.
Signed-off-by Dr. David Alan Gilbert <[email protected]>Looks good, thanks for the fixes.
Reviewed-by Sam Ravnborg <[email protected]>Thanks
Quoted 1 line
Let's hope someone picks it up...
Quoted 7 lines
Quoted 4 lines
I was hoping Dave would, but I realise Sparc doesn't get much these days.
Of course if anyone feels guilty about their own patches adding code they can take this patch to make ~340 lines of penance.You can ask Andrew Morton to pick it up through his tree. He usually does that when no one else is willing to pick a patch up.
Thanks for the suggestion, I've copied Andrew in, although
there's obviously no rush since it's just a dedupe.
Dave
Quoted 7 lines
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/