Skip to contentSkip to conversation

clocksource: Fix warnings in mshyperv.h

PATCH Applied [email protected] 3 participants 3 messages Jul 12, 2023 – Jul 23, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 clocksource: Fix warnings in mshyperv.h

The following checkpatch warnings are removed:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

---
 arch/x86/include/asm/mshyperv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/mshyperv.h +1 -1
index 88d9ef98e087..fa83d88e4c99 100644
@@ -5,7 +5,7 @@
 #include <linux/types.h>
 #include <linux/nmi.h>
 #include <linux/msi.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <asm/hyperv-tlfs.h>
 #include <asm/nospec-branch.h>
 #include <asm/paravirt.h>
Reviewed-by on v1 1/1
#2 lore raw

From: [email protected] <[email protected]> Sent: Wednesday, July 12, 2023 4:23 AM

Quoted 3 lines

The following checkpatch warnings are removed:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

The "Subject:" of the patch should probably start with "x86/hyperv", not "clocksource". Usually I look back at the commit history of a particular file and try to be consistent with the Subject: prefix that has been used in the past. "x86/hyperv" is typical for this include file.

Other than that,

Quoted 20 lines
---
  arch/x86/include/asm/mshyperv.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/mshyperv.h +1 -1
index 88d9ef98e087..fa83d88e4c99 100644
@@ -5,7 +5,7 @@
  #include <linux/types.h>
  #include <linux/nmi.h>
  #include <linux/msi.h>
-#include <asm/io.h>
+#include <linux/io.h>
  #include <asm/hyperv-tlfs.h>
  #include <asm/nospec-branch.h>
  #include <asm/paravirt.h>
maintainer Applied
#3 lore raw
Quoted 11 lines · Michael Kelley (LINUX)

From: [email protected] <[email protected]> Sent: Wednesday, July 12, 2023 4:23 AM

Quoted 3 lines

The following checkpatch warnings are removed:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

The "Subject:" of the patch should probably start with "x86/hyperv", not "clocksource". Usually I look back at the commit history of a particular file and try to be consistent with the Subject: prefix that has been used in the past. "x86/hyperv" is typical for this include file.

Quoted 3 lines

Other than that,

There is only one warning fixed.

I changed the subject line and commit message.

Applied to hyperv-fixes. Thanks.

Quoted 20 lines
Quoted 20 lines
---
  arch/x86/include/asm/mshyperv.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/mshyperv.h +1 -1
index 88d9ef98e087..fa83d88e4c99 100644
@@ -5,7 +5,7 @@
  #include <linux/types.h>
  #include <linux/nmi.h>
  #include <linux/msi.h>
-#include <asm/io.h>
+#include <linux/io.h>
  #include <asm/hyperv-tlfs.h>
  #include <asm/nospec-branch.h>
  #include <asm/paravirt.h>