Skip to contentSkip to conversation

arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards

PATCH Applied Yogesh Hegde 3 participants 5 messages Jul 18, 2023 – Jul 25, 2023

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Yogesh Hegde

author
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards

This patch fixes an issue affecting the Wifi/Bluetooth connectivity on ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") introduced a problem with the clock configuration. Specifically, the clock-names property of the sdio-pwrseq node was not updated to 'lpo', causing the driver to wait indefinitely for the wrong clock signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards.

To address this, this patch updates the clock-names property of the sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node.

This patch has been tested on ROCK Pi 4B.

Fixes f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")
Signed-off-by Yogesh Hegde <[email protected]>

---
Changes in v2: Added the Fixes tag as per feedback from Vincent Legoll
<[email protected]>

---
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +1 -1
index 907071d4fe80..795a70948d9a 100644
@@ -45,7 +45,7 @@ led-0 {
 	sdio_pwrseq: sdio-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "lpo";
 		pinctrl-names = "default";
 		pinctrl-0 = <&wifi_enable_h>;
 		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 8 lines · Yogesh Hegde

This patch fixes an issue affecting the Wifi/Bluetooth connectivity on ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") introduced a problem with the clock configuration. Specifically, the clock-names property of the sdio-pwrseq node was not updated to 'lpo', causing the driver to wait indefinitely for the wrong clock signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards.

Quoted 7 lines

To address this, this patch updates the clock-names property of the sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node.

This patch has been tested on ROCK Pi 4B.

Fixes f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")
Signed-off-by Yogesh Hegde <[email protected]>

Why are you saying this fixes a specific old commit and not also properly cc: the [email protected] alias?

Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

author
#2 lore raw
Quoted 12 lines · Greg KH
Quoted 11 lines · Yogesh Hegde

This patch fixes an issue affecting the Wifi/Bluetooth connectivity on ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") introduced a problem with the clock configuration. Specifically, the clock-names property of the sdio-pwrseq node was not updated to 'lpo', causing the driver to wait indefinitely for the wrong clock signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards.

To address this, this patch updates the clock-names property of the sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node.

Quoted 7 lines
Quoted 4 lines

This patch has been tested on ROCK Pi 4B.

Fixes f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards")
Signed-off-by Yogesh Hegde <[email protected]>

Why are you saying this fixes a specific old commit and not also properly cc: the [email protected] alias?

It is a mistake on my part. I apologize for the mistake.

Quoted 4 lines

Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

Thanks for the link, I will read through it and resend a v3 of the patch with fixes.

Thanks and Regards
-- Yogesh

maintainer Applied
#3 lore raw
In reply to Yogesh Hegde
Quoted 9 lines · Yogesh Hegde

This patch fixes an issue affecting the Wifi/Bluetooth connectivity on ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") introduced a problem with the clock configuration. Specifically, the clock-names property of the sdio-pwrseq node was not updated to 'lpo', causing the driver to wait indefinitely for the wrong clock signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards

      commit: ebceec271e552a2b05e47d8ef0597052b1a39449

and added the "Cc: [email protected]"

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>
author
#4 lore raw

Hi Heiko,

Quoted 11 lines · Heiko Stuebner

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards

      commit: ebceec271e552a2b05e47d8ef0597052b1a39449

and added the "Cc: [email protected]"

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>

Thanks and my heartfelt gratitude to you for fixing and applying the patch. I am truly grateful for your support.

Due to an increased workload and pressing commitments, there is a considerable delay in my responses and patch submissions.

Thanks and Regards
-- Yogesh
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees