Skip to contentSkip to conversation

serial: 8250_dw: Preserve original value of DLF register

PATCH In review Ruihong Luo 5 participants 7 messages Jul 13, 2023 – Jul 26, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 serial: 8250_dw: Preserve original value of DLF register

Preserve the original value of the Divisor Latch Fraction (DLF) register. When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader, leading to data corruption and the generation of unreadable or distorted characters.

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

---
v4:
* Use the old_dlf to hold the DLF register value

 drivers/tty/serial/8250/8250_dwlib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/tty/serial/8250/8250_dwlib.c +4 -2
index 75f32f054ebb..84843e204a5e 100644
@@ -244,7 +244,7 @@ void dw8250_setup_port(struct uart_port *p)
 	struct dw8250_port_data *pd = p->private_data;
 	struct dw8250_data *data = to_dw8250_data(pd);
 	struct uart_8250_port *up = up_to_u8250p(p);
-	u32 reg;
+	u32 reg, old_dlf;
 
 	pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
 	if (pd->hw_rs485_support) {
@@ -270,9 +270,11 @@ void dw8250_setup_port(struct uart_port *p)
 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
 
+	/* Preserve value written by firmware or bootloader  */
+	old_dlf = dw8250_readl_ext(p, DW_UART_DLF);
 	dw8250_writel_ext(p, DW_UART_DLF, ~0U);
 	reg = dw8250_readl_ext(p, DW_UART_DLF);
-	dw8250_writel_ext(p, DW_UART_DLF, 0);
+	dw8250_writel_ext(p, DW_UART_DLF, old_dlf);
 
 	if (reg) {
 		pd->dlf_size = fls(reg);
Signature · 1 line
2.39.2
#1 lore raw
FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH v4] serial: 8250_dw: Preserve original value of DLF register

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reviewer Reviewed-by on v4 1/1
#2 lore raw
In reply to Ruihong Luo
Quoted 4 lines · Ruihong Luo

Preserve the original value of the Divisor Latch Fraction (DLF) register. When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader, leading to data corruption and the generation of unreadable or distorted characters.

You forgot to add my tag. Why? Do you think the name of variable warrants this? Whatever,

Next time if you don't pick up somebody's tag, care to explain in the changelog why.

Quoted 2 lines
Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Reviewed-by on v4 1/1
#3 lore raw
In reply to Ruihong Luo
Quoted 6 lines · Ruihong Luo

Preserve the original value of the Divisor Latch Fraction (DLF) register. When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader, leading to data corruption and the generation of unreadable or distorted characters.

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

You forgot to add:

Quoted 1 line

Other than that,

Signature · 1 line
 i.
Quoted 34 lines

---
v4:
* Use the old_dlf to hold the DLF register value

 drivers/tty/serial/8250/8250_dwlib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/tty/serial/8250/8250_dwlib.c +4 -2
index 75f32f054ebb..84843e204a5e 100644
@@ -244,7 +244,7 @@ void dw8250_setup_port(struct uart_port *p)
 	struct dw8250_port_data *pd = p->private_data;
 	struct dw8250_data *data = to_dw8250_data(pd);
 	struct uart_8250_port *up = up_to_u8250p(p);
-	u32 reg;
+	u32 reg, old_dlf;
 
 	pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
 	if (pd->hw_rs485_support) {
@@ -270,9 +270,11 @@ void dw8250_setup_port(struct uart_port *p)
 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
 
+	/* Preserve value written by firmware or bootloader  */
+	old_dlf = dw8250_readl_ext(p, DW_UART_DLF);
 	dw8250_writel_ext(p, DW_UART_DLF, ~0U);
 	reg = dw8250_readl_ext(p, DW_UART_DLF);
-	dw8250_writel_ext(p, DW_UART_DLF, 0);
+	dw8250_writel_ext(p, DW_UART_DLF, old_dlf);
 
 	if (reg) {
 		pd->dlf_size = fls(reg);
#4 lore raw
Quoted 7 lines · Ilpo Järvinen
Quoted 5 lines · Ruihong Luo

Preserve the original value of the Divisor Latch Fraction (DLF) register. When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader, leading to data corruption and the generation of unreadable or distorted characters.

Quoted 5 lines
Quoted 1 line
Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

You forgot to add:

It's there. Just not in the commit message. It's fine.

Quoted 5 lines
Quoted 1 line

Other than that,

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Ilpo Järvinen
Quoted 5 lines · Ruihong Luo

Preserve the original value of the Divisor Latch Fraction (DLF) register. When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader, leading to data corruption and the generation of unreadable or distorted characters.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

You forgot to add:

It's there. Just not in the commit message. It's fine.

No it isn't, that's not how to have a patch added to the stable tree, as my form letter says:

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

I'll go fix it up by hand...

#6 lore raw
Quoted 22 lines · Greg Kroah-Hartman
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Ilpo Järvinen
Quoted 5 lines · Ruihong Luo

Preserve the original value of the Divisor Latch Fraction (DLF) register. When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader, leading to data corruption and the generation of unreadable or distorted characters.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

You forgot to add:

It's there. Just not in the commit message. It's fine.

No it isn't, that's not how to have a patch added to the stable tree, as my form letter says:

<formletter>

Quoted 8 lines

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

I'll go fix it up by hand...

Good to know, thank you for the clarification!

Signature · 2 lines
With Best Regards,
Andy Shevchenko