gpio: eic-sprd: remove unneeded platform_set_drvdata() call
Subsystems (2)
PATCH 1/1 gpio: eic-sprd: remove unneeded platform_set_drvdata() call
The platform_set_drvdata() call was never used, ever since the driver was originally added.
It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook.
--- drivers/gpio/gpio-eic-sprd.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpio/gpio-eic-sprd.c +0 -1
@@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)return ret; } -platform_set_drvdata (pdev, sprd_eic);return 0 ; }
Signature · 1 line
2.34.1
Quoted 4 lines · Andrei Coardos
The
platform_set_drvdata()call was never used, ever since the driver was originally added.
It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andrei Coardos
The
platform_set_drvdata()call was never used, ever since the driver was originally added.
It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook.Reviewed-by Alexandru Ardelean <[email protected]>Signed-off-by Andrei Coardos <[email protected]>
LGTM. Thanks.
Quoted 16 lines
--- drivers/gpio/gpio-eic-sprd.c | 1 - 1 file changed, 1 deletion(-)drivers/gpio/gpio-eic-sprd.c +0
-1@@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)return ret; } -platform_set_drvdata (pdev, sprd_eic);return 0 ; }
Bartosz Golaszewski
AppliedQuoted 25 lines · Andrei Coardos
The
platform_set_drvdata()call was never used, ever since the driver was originally added.
It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook.Reviewed-by Alexandru Ardelean <[email protected]>Signed-off-by Andrei Coardos <[email protected]>--- drivers/gpio/gpio-eic-sprd.c | 1 - 1 file changed, 1 deletion(-)drivers/gpio/gpio-eic-sprd.c +0
-2@@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)return ret; } -platform_set_drvdata (pdev, sprd_eic);return 0 ; } --
Quoted 2 lines
2.34.1
Applied, thanks!
Bart