platform/x86: asus-wmi: Fix setting RGB mode on some TUF laptops
PATCH v3 1/1 platform/x86: asus-wmi: Fix setting RGB mode on some TUF laptops
This patch fixes setting the cmd values to 0xb3 and 0xb4. This is necessary on some TUF laptops in order to set the RGB mode.
---
V1 -> V2. Make setting 0xb3 and 0xb4 the default logic V2 -> V3. Defualt to -EINVAL to match the rest of asus-wmi.
drivers/platform/x86/asus-wmi.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/platform/x86/asus-wmi.c +12 -2
@@ -738,13 +738,23 @@ static ssize_t kbd_rgb_mode_store(struct device *dev,struct device_attribute *attr, const char *buf, size_t count) { - u32 cmd, mode, r, g, b, speed; + u32 cmd, mode, r, g, b, speed;int err;if (sscanf (buf,"%d %d %d %d %d %d" , &cmd, &mode, &r, &g, &b, &speed) !=6 )return -EINVAL ; - cmd = !!cmd; +/* B3 is set and B4 is save to BIOS */ +switch (cmd) { +case 0 : + cmd =0xb3 ; +break ; +case 1 : + cmd =0xb4 ; +break ; +default : +return -EINVAL ; + }/* These are the known usable modes across all TUF/ROG */ if (mode >=12 || mode ==9 )
Signature · 1 line
2.40.0
Looks good to me.
Quoted 47 lines · Kristian Angelov
This patch fixes setting the cmd values to
0xb3and0xb4. This is necessary on some TUF laptops in order to set the RGB mode.Signed-off-by Kristian Angelov <[email protected]>---
V1 -> V2. Make setting0xb3and0xb4the default logic V2 -> V3. Defualt to-EINVALto match the rest of asus-wmi.drivers/platform/x86/asus-wmi.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)drivers/platform/x86/asus-wmi.c +12
-2@@ -738,13 +738,23 @@ static ssize_t kbd_rgb_mode_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { -u32 cmd, mode, r, g, b, speed; +u32 cmd, mode, r, g, b, speed;int err;if (sscanf (buf,"%d %d %d %d %d %d" , &cmd, &mode, &r, &g, &b, &speed) !=6 )return -EINVAL ; - cmd = !!cmd; +/* B3 is set and B4 is save to BIOS */ +switch (cmd) { +case 0 : + cmd =0xb3 ; +break ; +case 1 : + cmd =0xb4 ; +break ; +default : +return -EINVAL ; + }drivers/platform/x86/asus-wmi.c +0
-1/* These are the known usable modes across all TUF/ROG */ if (mode >=12 || mode ==9 ) --2.40.0
Hi,
Quoted 10 lines · Luke Jones
Looks good to me.
Reviewed-by Luke D. Jones <[email protected]>Quoted 5 lines · Kristian Angelov
This patch fixes setting the cmd values to
0xb3and0xb4. This is necessary on some TUF laptops in order to set the RGB mode.
Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes
Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while.
I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle.
Regards,
Hans
Quoted 42 lines
Quoted 40 lines
---
V1 -> V2. Make setting0xb3and0xb4the default logic V2 -> V3. Defualt to-EINVALto match the rest of asus-wmi.drivers/platform/x86/asus-wmi.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)drivers/platform/x86/asus-wmi.c +12
-2@@ -738,13 +738,23 @@ static ssize_t kbd_rgb_mode_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - u32 cmd, mode, r, g, b, speed; + u32 cmd, mode, r, g, b, speed; int err; if (sscanf(buf, "%d %d %d %d %d %d", &cmd, &mode, &r, &g, &b, &speed) != 6) return -EINVAL; - cmd = !!cmd; + /* B3 is set and B4 is save to BIOS */ + switch (cmd) { + case 0: + cmd = 0xb3; + break; + case 1: + cmd = 0xb4; + break; + default: + return -EINVAL; + } /* These are the known usable modes across all TUF/ROG */ if (mode >= 12 || mode == 9)Signature · 1 line
2.40.0