Skip to contentSkip to conversation

Add support to Fiberstore SFP quirks

PATCH In review Raju Lakkaraju 2 participants 4 messages Jul 21, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Add support to Fiberstore SFP quirks

This patch series adds support to Fiberstore(FS)'s SFP quirks for
- 2.5G copper SFP (SFP-2.5G-T)
- DAC10G SFP (SFPP-PC01)

Raju Lakkaraju (2):
net: sfp: add quirk for FS's 2.5G copper SFP
net: sfp: add quirk for FS's DAC10G SFP (SFPP-PC01)

 drivers/net/phy/sfp.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 net: sfp: add quirk for FS's 2.5G copper SFP

Add a quirk for a copper SFP that identifies itself as "FS" "SFP-2.5G-T". This module's PHY is inaccessible, and can only run at 2500base-X with the host without negotiation. Add a quirk to enable the 2500base-X interface mode with 2500base-T support and disable auto negotiation.

---
 drivers/net/phy/sfp.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/phy/sfp.c +3 -0
index d855a18308d7..ee049efdf71b 100644
@@ -463,6 +463,9 @@ static const struct sfp_quirk sfp_quirks[] = {
 	SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex,
 		  sfp_fixup_ignore_tx_fault),
 
+	// FS 2.5G Base-T
+	SFP_QUIRK_M("FS", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
+
 	// Lantech 8330-262D-E can operate at 2500base-X, but incorrectly report
 	// 2500MBd NRZ in their EEPROM
 	SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex),
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/2 net: sfp: add quirk for FS's DAC10G SFP (SFPP-PC01)

In reply to Raju Lakkaraju

Add a quirk for a DAC10G SFP that identifies itself as "FS" "SFPP-PC01". Add a quirk to enable the SGMII interface, modes 2500base-T, 1000base-T, 100base-T/Full and 100base-T/Half support.

---
 drivers/net/phy/sfp.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/phy/sfp.c +14 -0
index ee049efdf71b..80d2680f08ab 100644
@@ -421,6 +421,18 @@ static void sfp_quirk_oem_2_5g(const struct sfp_eeprom_id *id,
 	sfp_quirk_disable_autoneg(id, modes, interfaces);
 }
 
+static void sfp_quirk_fs_dac(const struct sfp_eeprom_id *id,
+			     unsigned long *modes,
+			     unsigned long *interfaces)
+{
+	/* Fiberstore(FS)'s DAC SFP (SFPP-PC01) */
+	linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, modes);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, modes);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, modes);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, modes);
+	__set_bit(PHY_INTERFACE_MODE_SGMII, interfaces);
+}
+
 static void sfp_quirk_ubnt_uf_instant(const struct sfp_eeprom_id *id,
 				      unsigned long *modes,
 				      unsigned long *interfaces)
@@ -465,6 +477,8 @@ static const struct sfp_quirk sfp_quirks[] = {
 
 	// FS 2.5G Base-T
 	SFP_QUIRK_M("FS", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
+	// FS DAC10G (SFPP-PC01)
+	SFP_QUIRK_M("FS", "SFPP-PC01", sfp_quirk_fs_dac),
 
 	// Lantech 8330-262D-E can operate at 2500base-X, but incorrectly report
 	// 2500MBd NRZ in their EEPROM
Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH net-next 2/2] net: sfp: add quirk for FS's DAC10G SFP (SFPP-PC01)

Quoted 16 lines · Raju Lakkaraju

Add a quirk for a DAC10G SFP that identifies itself as "FS" "SFPP-PC01". Add a quirk to enable the SGMII interface, modes 2500base-T, 1000base-T, 100base-T/Full and 100base-T/Half support.

---
 drivers/net/phy/sfp.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/phy/sfp.c +0 -0
index ee049efdf71b..80d2680f08ab 100644
@@ -421,6 +421,18 @@ static void sfp_quirk_oem_2_5g(const struct sfp_eeprom_id *id,
 	sfp_quirk_disable_autoneg(id, modes, interfaces);
 }

drivers/net/phy/sfp.c static void sfp_quirk_oem_2_5g(const struct sfp_eeprom_id *id, · line 432

Quoted 10 lines
drivers/net/phy/sfp.c +9 -0
 
+static void sfp_quirk_fs_dac(const struct sfp_eeprom_id *id,
+			     unsigned long *modes,
+			     unsigned long *interfaces)
+{
+	/* Fiberstore(FS)'s DAC SFP (SFPP-PC01) */
+	linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, modes);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, modes);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, modes);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, modes);

No. A DAC cable does _not_ give you twisted-pair ethernet which is what baseT linkmodes are.

The description on fs.com states:

"The 10G SFP+ Passive Direct Attach Copper Twinax Cable is designed for use in 10GBASE Ethernet."

That means it supports 10GBASE-CR, which is the link mode for 10 Gigabit ethernet over a direct attach cable.

If it does work at 2.5G speeds, then the protocol that will be used for that will be 2500base-X.

If it does work at 1G speeds, then the protocol that will be used for that will be 1000base-X (which is the "standard" protocol for the host connection for 1G SFPs.)

Going below that isn't technically possible, but can be done with SGMII by forcing the link settings, but is there really any need to support slower speeds? What possible valid reason could there be? A host not supporting 1G speeds with a SFP cage would be utterly insane.

drivers/net/phy/sfp.c static void sfp_quirk_oem_2_5g(const struct sfp_eeprom_id *id, · line 433

Quoted 1 line
drivers/net/phy/sfp.c +1 -0
+	__set_bit(PHY_INTERFACE_MODE_SGMII, interfaces);

I also disagree with this. Unless there is a PHY present, you can _not_ connect two hosts together that are using the SGMII protocol. The SGMII "negotiation" protocol is _asymetric_, and it relies upon a PHY telling the host what the link speed and duplex settings are. A host never sends that information, so this will not "negotiate".

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!