Skip to contentSkip to conversation

drivers/scsi: Fix typos in comments

PATCH In review [email protected] 2 participants 2 messages Jul 20, 2023 – Jul 21, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drivers/scsi: Fix typos in comments

Delete duplicate word "the"

---
 drivers/scsi/dc395x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/dc395x.c +0 -0
index c8e86f8a631e..077e76407c58 100644
@@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb, struct ScsiReqBlk *srb,
         /*
          * KG: We should wait for the DMA FIFO to be empty ...
          * but: it would be better to wait first for the SCSI FIFO and 

then the
- * the DMA FIFO to become empty? How do we know, that the device not already
+ * DMA FIFO to become empty? How do we know, that the device not already

          * sent data to the FIFO in a MsgIn phase, eg.?
          */
         if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {
#2 lore raw
Quoted 21 lines · On Fri, Jul 21, 2023 at 12:06:11AM +0800, [email protected] wrote:

Delete duplicate word "the"

---
 drivers/scsi/dc395x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/dc395x.c +0 -0
index c8e86f8a631e..077e76407c58 100644
@@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb,
 struct ScsiReqBlk *srb,
         /*
          * KG: We should wait for the DMA FIFO to be empty ...
          * but: it would be better to wait first for the SCSI FIFO and then

the
- * the DMA FIFO to become empty? How do we know, that the device
not already
+ * DMA FIFO to become empty? How do we know, that the device not
already

Quoted 3 lines
          * sent data to the FIFO in a MsgIn phase, eg.?
          */
         if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {

I'd like to write the comment above instead as "We should wait for the DMA FIFO to be empty, but it would be better to wait first for the SCSI one and then the DMA one to be emptied..."

But hey, you did not read review comments to all your submissions, many of them (including mine) asking you to not corrupt your patches like this one did.

Hence NAK from me.

Bye!

Signature · 1 line
An old man doll... just what I always wanted! - Clara