perf probe: Make synthesize_perf_probe_point() private to probe-event.c
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf probe: Make synthesize_perf_probe_point() private to probe-event.c
Not used in any other place, so just make it static.
Cc Adrian Hunter <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/probe-event.c | 4 +++- tools/perf/util/probe-event.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-)
tools/perf/util/probe-event.c +3 -1
@@ -53,6 +53,8 @@bool probe_event_dry_run;/* Dry run flag */ struct probe_conf probe_conf = { .magic_num =DEFAULT_PROBE_MAGIC_NUM }; +static char *synthesize_perf_probe_point (struct perf_probe_point *pp); + #define semantic_error(msg ...) pr_err("Semantic error :" msg)int e_snprintf (char *str,size_t size,const char *format, ...)
@@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa) }/* Compose only probe point (not argument) */ -char *synthesize_perf_probe_point (struct perf_probe_point *pp) +static char *synthesize_perf_probe_point (struct perf_probe_point *pp) {struct strbuf buf;char *tmp, *ret =NULL ;
tools/perf/util/probe-event.h +0 -1
@@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev);char *synthesize_perf_probe_command (struct perf_probe_event *pev);char *synthesize_probe_trace_command (struct probe_trace_event *tev);char *synthesize_perf_probe_arg (struct perf_probe_arg *pa); -char *synthesize_perf_probe_point (struct perf_probe_point *pp);int perf_probe_event__copy (struct perf_probe_event *dst,struct perf_probe_event *src);
Signature · 1 line
2.37.1
Quoted 10 lines · Arnaldo Carvalho de Melo
Not used in any other place, so just make it static.
Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Jiri Olsa <[email protected]>Cc Masami Hiramatsu <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Reviewed-by Ian Rogers <[email protected]>
Thanks,
Ian
Quoted 42 lines
--- tools/perf/util/probe-event.c | 4 +++- tools/perf/util/probe-event.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-)tools/perf/util/probe-event.c +3
-1@@ -53,6 +53,8 @@bool probe_event_dry_run;/* Dry run flag */ struct probe_conf probe_conf = { .magic_num =DEFAULT_PROBE_MAGIC_NUM }; +static char *synthesize_perf_probe_point (struct perf_probe_point *pp); + #define semantic_error(msg ...) pr_err("Semantic error :" msg)int e_snprintf (char *str,size_t size,const char *format, ...)@@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa) }/* Compose only probe point (not argument) */ -char *synthesize_perf_probe_point (struct perf_probe_point *pp) +static char *synthesize_perf_probe_point (struct perf_probe_point *pp) {struct strbuf buf;char *tmp, *ret =NULL ;tools/perf/util/probe-event.h +0
-2@@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev);char *synthesize_perf_probe_command (struct perf_probe_event *pev);char *synthesize_probe_trace_command (struct probe_trace_event *tev);char *synthesize_perf_probe_arg (struct perf_probe_arg *pa); -char *synthesize_perf_probe_point (struct perf_probe_point *pp);int perf_probe_event__copy (struct perf_probe_event *dst,struct perf_probe_event *src); --2.37.1
Quoted 2 lines · On Fri, 4 Aug 2023 13:38:37 -0300 Arnaldo Carvalho de Melo <[email protected]>…
Not used in any other place, so just make it static.
Looks good to me.
Thanks!
Quoted 49 lines
Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Jiri Olsa <[email protected]>Cc Masami Hiramatsu <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>--- tools/perf/util/probe-event.c | 4 +++- tools/perf/util/probe-event.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-)tools/perf/util/probe-event.c +3
-1@@ -53,6 +53,8 @@bool probe_event_dry_run;/* Dry run flag */ struct probe_conf probe_conf = { .magic_num =DEFAULT_PROBE_MAGIC_NUM }; +static char *synthesize_perf_probe_point (struct perf_probe_point *pp); + #define semantic_error(msg ...) pr_err("Semantic error :" msg)int e_snprintf (char *str,size_t size,const char *format, ...)@@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa) }/* Compose only probe point (not argument) */ -char *synthesize_perf_probe_point (struct perf_probe_point *pp) +static char *synthesize_perf_probe_point (struct perf_probe_point *pp) {struct strbuf buf;char *tmp, *ret =NULL ;tools/perf/util/probe-event.h +0
-1@@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev);char *synthesize_perf_probe_command (struct perf_probe_event *pev);char *synthesize_probe_trace_command (struct probe_trace_event *tev);char *synthesize_perf_probe_arg (struct perf_probe_arg *pa); -char *synthesize_perf_probe_point (struct perf_probe_point *pp);int perf_probe_event__copy (struct perf_probe_event *dst,struct perf_probe_event *src);Signature · 1 line
2.37.1
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>