serial: 8250: Fix oops for port->pm on uart_change_pm()
PATCH 1/1 serial: 8250: Fix oops for port->pm on uart_change_pm()
Unloading a hardware specific 8250 driver can produce error "Unable to handle kernel paging request at virtual address" about ten seconds after unloading the driver. This happens on uart_hangup() calling uart_change_pm().
Turns out commit 04e82793f068 ("serial: 8250: Reinit port->pm on port specific driver unbind") was only a partial fix. If the hardware specific driver has initialized port->pm function, we need to clear port->pm too. Just reinitializing port->ops does not do this. Otherwise serial8250_pm() will call port->pm() instead of serial8250_do_pm().
--- drivers/tty/serial/8250/8250_port.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/8250/8250_port.c +1 -0
@@ -3278,6 +3278,7 @@ void serial8250_init_port(struct uart_8250_port *up)spin_lock_init (&port->lock); port->ctrl_id =0 ; + port->pm =NULL ; port->ops = &serial8250_pops; port->has_sysrq =IS_ENABLED (CONFIG_SERIAL_8250_CONSOLE );
Signature · 1 line
2.41.0
Quoted 10 lines · Tony Lindgren
Unloading a hardware specific 8250 driver can produce error "Unable to handle kernel paging request at virtual address" about ten seconds after unloading the driver. This happens on
uart_hangup()callinguart_change_pm().Turns out commit
04e82793f068("serial: 8250: Reinitport->pmon port specific driver unbind") was only a partial fix. If the hardware specific driver has initializedport->pmfunction, we need to clearport->pmtoo. Just reinitializingport->opsdoes not do this. Otherwiseserial8250_pm()will callport->pm()instead ofserial8250_do_pm().
Oh, good catch!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Tony Lindgren
Unloading a hardware specific 8250 driver can produce error "Unable to handle kernel paging request at virtual address" about ten seconds after unloading the driver. This happens on
uart_hangup()callinguart_change_pm().Turns out commit
04e82793f068("serial: 8250: Reinitport->pmon port specific driver unbind") was only a partial fix. If the hardware specific driver has initializedport->pmfunction, we need to clearport->pmtoo. Just reinitializingport->opsdoes not do this. Otherwiseserial8250_pm()will callport->pm()instead ofserial8250_do_pm().
Thanks for catching and fixing this!
Quoted 11 lines
Fixes 04e82793f068 ("serial: 8250: Reinit port->pm on port specific driver unbind")Signed-off-by Tony Lindgren <[email protected]>--- drivers/tty/serial/8250/8250_port.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/8250/8250_port.c void serial8250_init_port(struct uart_8250_port *up) · line 3281
Quoted 4 lines
drivers/tty/serial/8250/8250_port.c +1
-0@@ -3278,6 +3278,7 @@ void serial8250_init_port(struct uart_8250_port *up)spin_lock_init (&port->lock); port->ctrl_id =0 ; + port->pm =NULL ;
Quoted 5 lines
drivers/tty/serial/8250/8250_port.c +0
-0port->ops = &serial8250_pops; port->has_sysrq =IS_ENABLED (CONFIG_SERIAL_8250_CONSOLE );Signature · 1 line
2.41.0
Signature · 2 lines
Best regards, Dhruva Gole <[email protected]>