Skip to contentSkip to conversation

perf tests task_analyzer: Check perf build options for libtraceevent support

PATCH In review Aditya Gupta 4 participants 8 messages Jul 25, 2023 – Aug 7, 2023 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tests task_analyzer: Check perf build options for libtraceevent support

Currently we depend on output of 'perf record -e "sched:sched_switch"', to check whether perf was built with libtraceevent support.

Instead, a more straightforward approach can be to check the build options, using 'perf version --build-options', to check for libtraceevent support.

When perf is compiled WITHOUT libtraceevent ('make NO_LIBTRACEEVENT=1'), 'perf version --build-options' outputs (output trimmed):

	 ...
         libtraceevent: [ OFF ]  # HAVE_LIBTRACEEVENT
	 ...

While, when perf is compiled WITH libtraceevent,

'perf version --build-options' outputs:

...
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
...

---

 tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_task_analyzer.sh +1 -1
index 0095abbe20ca..a28d784987b4 100755
@@ -52,7 +52,7 @@ find_str_or_fail() {
 
 # check if perf is compiled with libtraceevent support
 skip_no_probe_record_support() {
-	perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
+	perf version --build-options | grep HAVE_LIBTRACEEVENT | grep -q OFF && return 2
 	return 0
 }
 
Signature · 1 line
2.41.0
#1 lore raw

Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu:

Quoted 33 lines

Currently we depend on output of 'perf record -e "sched:sched_switch"', to check whether perf was built with libtraceevent support.

Instead, a more straightforward approach can be to check the build options, using 'perf version --build-options', to check for libtraceevent support.

When perf is compiled WITHOUT libtraceevent ('make NO_LIBTRACEEVENT=1'), 'perf version --build-options' outputs (output trimmed):

	 ...
         libtraceevent: [ OFF ]  # HAVE_LIBTRACEEVENT
	 ...

While, when perf is compiled WITH libtraceevent,

'perf version --build-options' outputs:

...
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
...

---

 tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_task_analyzer.sh +0 -0
index 0095abbe20ca..a28d784987b4 100755

tools/perf/tests/shell/test_task_analyzer.sh find_str_or_fail() { · line 56

Quoted 6 lines
tools/perf/tests/shell/test_task_analyzer.sh +1 -1
@@ -52,7 +52,7 @@ find_str_or_fail() {
 
 # check if perf is compiled with libtraceevent support
 skip_no_probe_record_support() {
-	perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
+	perf version --build-options | grep HAVE_LIBTRACEEVENT | grep -q OFF && return 2
 	return 0

I'll apply this, but please consider adding a:

	perf build --has libtraceevent

subcommand to have that query made more compact and to avoid the two extra grep.

BTW, I'll change that to:

[acme@quaco perf-tools-next]$ perf version --build-options | grep " on .* HAVE_LIBTRACEEVENT"
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
[acme@quaco perf-tools-next]$

replacing "on" with OFF, so that we have just one grep.

Thanks,

- Arnaldo

Quoted 5 lines
tools/perf/tests/shell/test_task_analyzer.sh +0 -0
 }
 
Signature · 1 line
2.41.0
Signature · 1 line
- Arnaldo
reviewer
#2 lore raw
Quoted 44 lines · Arnaldo Carvalho de Melo

Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu:

Quoted 33 lines

Currently we depend on output of 'perf record -e "sched:sched_switch"', to check whether perf was built with libtraceevent support.

Instead, a more straightforward approach can be to check the build options, using 'perf version --build-options', to check for libtraceevent support.

When perf is compiled WITHOUT libtraceevent ('make NO_LIBTRACEEVENT=1'), 'perf version --build-options' outputs (output trimmed):

       ...
         libtraceevent: [ OFF ]  # HAVE_LIBTRACEEVENT
       ...

While, when perf is compiled WITH libtraceevent,

'perf version --build-options' outputs:

...
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
...

---

 tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_task_analyzer.sh +0 -0
index 0095abbe20ca..a28d784987b4 100755

tools/perf/tests/shell/test_task_analyzer.sh find_str_or_fail() { · line 56

Quoted 6 lines
tools/perf/tests/shell/test_task_analyzer.sh +1 -1
@@ -52,7 +52,7 @@ find_str_or_fail() {
 
 # check if perf is compiled with libtraceevent support
 skip_no_probe_record_support() {
-     perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
+     perf version --build-options | grep HAVE_LIBTRACEEVENT | grep -q OFF && return 2
      return 0

I'll apply this, but please consider adding a:

Quoted 1 line
        perf build --has libtraceevent

That's a nice idea. You mean add a script like perf-archive.sh? Perhaps this flag should be supported by perf version instead.

Thanks,
Ian

Quoted 24 lines

subcommand to have that query made more compact and to avoid the two extra grep.

BTW, I'll change that to:

[acme@quaco perf-tools-next]$ perf version --build-options | grep " on .* HAVE_LIBTRACEEVENT"
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
[acme@quaco perf-tools-next]$

replacing "on" with OFF, so that we have just one grep.

Thanks,

- Arnaldo

Quoted 5 lines
tools/perf/tests/shell/test_task_analyzer.sh +0 -1
 }
 
--

2.41.0

--

- Arnaldo

#3 lore raw

Em Fri, Jul 28, 2023 at 09:01:11AM -0700, Ian Rogers escreveu:

Quoted 46 lines
Quoted 44 lines · Arnaldo Carvalho de Melo

Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu:

Quoted 33 lines

Currently we depend on output of 'perf record -e "sched:sched_switch"', to check whether perf was built with libtraceevent support.

Instead, a more straightforward approach can be to check the build options, using 'perf version --build-options', to check for libtraceevent support.

When perf is compiled WITHOUT libtraceevent ('make NO_LIBTRACEEVENT=1'), 'perf version --build-options' outputs (output trimmed):

       ...
         libtraceevent: [ OFF ]  # HAVE_LIBTRACEEVENT
       ...

While, when perf is compiled WITH libtraceevent,

'perf version --build-options' outputs:

...
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
...

---

 tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/test_task_analyzer.sh +0 -0
index 0095abbe20ca..a28d784987b4 100755

tools/perf/tests/shell/test_task_analyzer.sh find_str_or_fail() { · line 56

Quoted 6 lines
tools/perf/tests/shell/test_task_analyzer.sh +1 -1
@@ -52,7 +52,7 @@ find_str_or_fail() {
 
 # check if perf is compiled with libtraceevent support
 skip_no_probe_record_support() {
-     perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
+     perf version --build-options | grep HAVE_LIBTRACEEVENT | grep -q OFF && return 2
      return 0

I'll apply this, but please consider adding a:

Quoted 3 lines
Quoted 1 line
        perf build --has libtraceevent

That's a nice idea. You mean add a script like perf-archive.sh?

Nope, I would just add a new builtin-build.c (or some other more suitable name to query what was built into perf) and then it would just do a simple search on the same array that 'perf version --build-options' currently uses (or the array that it would then share with 'perf build', I haven't looked at the source code.).

So instead of a series of fork + execs we would just have one.

- Arnaldo

Quoted 29 lines

Perhaps this flag should be supported by perf version instead.

Thanks,
Ian

Quoted 24 lines

subcommand to have that query made more compact and to avoid the two extra grep.

BTW, I'll change that to:

[acme@quaco perf-tools-next]$ perf version --build-options | grep " on .* HAVE_LIBTRACEEVENT"
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
[acme@quaco perf-tools-next]$

replacing "on" with OFF, so that we have just one grep.

Thanks,

- Arnaldo

Quoted 5 lines
tools/perf/tests/shell/test_task_analyzer.sh +0 -1
 }
 
--

2.41.0

--

- Arnaldo

Signature · 1 line
- Arnaldo
#4 lore raw

Hi Arnaldo,
I am working on a patch for 'perf version --has', and will send a patch next week using that instead of 'perf version --build-options'.

You can skip this patch if not needed.

Thanks,
- Aditya G

#5 lore raw
Quoted 6 lines · Aditya Gupta

Hi Arnaldo,
I am working on a patch for 'perf version --has', and will send a patch next

Hi Aditya,

I believe, it will be “perf build —has” option. And not “perf version —has” ?

Thanks
Athira

Quoted 6 lines

week using that instead of 'perf version --build-options'.

You can skip this patch if not needed.

Thanks,
- Aditya G

#6 lore raw
Quoted 10 lines · Athira Rajeev
Quoted 6 lines · Aditya Gupta

Hi Arnaldo,
I am working on a patch for 'perf version --has', and will send a patch next

Hi Aditya,

I believe, it will be “perf build —has” option. And not “perf version —has” ?

Oh okay. I misread. Thanks for pointing it out Athira.

Thanks,
Aditya G

#7 lore raw
In reply to Arnaldo Carvalho de Melo
Quoted 23 lines · Arnaldo Carvalho de Melo

Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu:

Quoted 13 lines

Currently we depend on output of 'perf record -e "sched:sched_switch"', to check whether perf was built with libtraceevent support.

Instead, a more straightforward approach can be to check the build options, using 'perf version --build-options', to check for libtraceevent support.

[...]

tools/perf/tests/shell/test_task_analyzer.sh +0 -0
index 0095abbe20ca..a28d784987b4 100755

tools/perf/tests/shell/test_task_analyzer.sh find_str_or_fail() { · line 56

Quoted 6 lines
tools/perf/tests/shell/test_task_analyzer.sh +1 -1
@@ -52,7 +52,7 @@ find_str_or_fail() {
 
 # check if perf is compiled with libtraceevent support
 skip_no_probe_record_support() {
-	perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
+	perf version --build-options | grep HAVE_LIBTRACEEVENT | grep -q OFF && return 2
 	return 0

I'll apply this, but please consider adding a:

Quoted 4 lines
	perf build --has libtraceevent

subcommand to have that query made more compact and to avoid the two extra grep.

Okay. As you suggested in another reply, I found the code in builtin-version.c, we can have a "perf build --has" option which can use the IS_BUILTIN macro also used by "perf version --build-options". It can support all other feature flags too.

You can implement it or I can work on a patch for that ?

It should require adding another 'struct option' to 'version_options', and check for the flag in 'cmd_version()'. Will have to look how to get the string passed after '--has'.

Quoted 8 lines

BTW, I'll change that to:

[acme@quaco perf-tools-next]$ perf version --build-options | grep " on .* HAVE_LIBTRACEEVENT"
libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
[acme@quaco perf-tools-next]$

replacing "on" with OFF, so that we have just one grep.

Okay.

Thanks,
- Aditya G