riscv: enable DEBUG_FORCE_FUNCTION_ALIGN_64B
Subsystems (2)
PATCH 1/1 riscv: enable DEBUG_FORCE_FUNCTION_ALIGN_64B
Allow to force all function address 64B aligned as it is possible for other architectures. This may be useful when verify if performance bump is caused by function alignment changes.
Before commit 1bf18da62106 ("lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option"), riscv supports enabling the DEBUG_FORCE_FUNCTION_ALIGN_64B option, but after that commit, each arch needs to claim the support explicitly. I tried the config file in
[1] for both RV64 and RV32, I can't reproduce the build error as [1], there is no reason for not allowing to enforce this function alignment.
--- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug +1 -1
@@ -502,7 +502,7 @@ config SECTION_MISMATCH_WARN_ONLY config DEBUG_FORCE_FUNCTION_ALIGN_64B bool "Force all function address 64B aligned" - depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC || S390) + depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC || RISCV || S390) select FUNCTION_ALIGNMENT_64B help There are cases that a commit from one domain changes the function
Signature · 1 line
2.40.1
Hey,
Quoted 4 lines · Jisheng Zhang
Allow to force all function address 64B aligned as it is possible for other architectures. This may be useful when verify if performance bump is caused by function alignment changes.
Quoted 8 lines
Before commit
1bf18da62106("lib/Kconfig.debug: add ARCH dependency forFUNCTION_ALIGNoption"), riscv supports enabling theDEBUG_FORCE_FUNCTION_ALIGN_64Boption, but after that commit, each arch needs to claim the support explicitly. I tried the config file in
[1] for both RV64 and RV32, I can't reproduce the build error as [1], there is no reason for not allowing to enforce this function alignment.
This is a CSKY randconfig, is there any particular reason that running that randconfig (over a year later) and on a different architecture would trigger whatever the condition was?
The original commit here seems far too penal - why was it not just disabled on CSKY??? I tried looking a bit on lore, but didn't see anything explaining the subset of supported archs they picked. I did see Guo Ren wondering if rv32 would be similarly problematic - but since this is something likely to just trip up randconfigs, I think we should go for it and if rv32 becomes a problem, restrict this to 64-bit.
Thanks,
Conor.
Quoted 21 lines
Signed-off-by Jisheng Zhang <[email protected]>--- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/Kconfig.debug +1
-1@@ -502,7 +502,7 @@ config SECTION_MISMATCH_WARN_ONLY config DEBUG_FORCE_FUNCTION_ALIGN_64B bool "Force all function address 64B aligned" - depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC || S390) + depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC || RISCV || S390) select FUNCTION_ALIGNMENT_64B help There are cases that a commit from one domain changes the functionSignature · 1 line
2.40.1
Quoted 14 lines · Conor Dooley
Hey,
Quoted 11 lines · Jisheng Zhang
Allow to force all function address 64B aligned as it is possible for other architectures. This may be useful when verify if performance bump is caused by function alignment changes.
Before commit
1bf18da62106("lib/Kconfig.debug: add ARCH dependency forFUNCTION_ALIGNoption"), riscv supports enabling theDEBUG_FORCE_FUNCTION_ALIGN_64Boption, but after that commit, each arch needs to claim the support explicitly. I tried the config file in
[1] for both RV64 and RV32, I can't reproduce the build error as [1], there is no reason for not allowing to enforce this function alignment.
Quoted 5 lines
Quoted 1 line
This is a CSKY randconfig, is there any particular reason that running that randconfig (over a year later) and on a different architecture would trigger whatever the condition was?
Just use the randconfig and then s/CSKY/RISCV to check whether RV32 and RV64 can reproduce the compile error ;)
Quoted 34 lines
The original commit here seems far too penal - why was it not just disabled on CSKY??? I tried looking a bit on lore, but didn't see anything explaining the subset of supported archs they picked. I did see Guo Ren wondering if rv32 would be similarly problematic - but since this is something likely to just trip up randconfigs, I think we should go for it and if rv32 becomes a problem, restrict this to 64-bit.
Reviewed-by Conor Dooley <[email protected]>Thanks,
Conor.Quoted 21 lines
Signed-off-by Jisheng Zhang <[email protected]>--- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/Kconfig.debug +1
-1@@ -502,7 +502,7 @@ config SECTION_MISMATCH_WARN_ONLY config DEBUG_FORCE_FUNCTION_ALIGN_64B bool "Force all function address 64B aligned" - depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC || S390) + depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC || RISCV || S390) select FUNCTION_ALIGNMENT_64B help There are cases that a commit from one domain changes the functionSignature · 1 line
2.40.1
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 4 lines · On Fri, 28 Jul 2023 00:03:56 +0800 you wrote:
Allow to force all function address 64B aligned as it is possible for other architectures. This may be useful when verify if performance bump is caused by function alignment changes.
Quoted 8 lines
Before commit
1bf18da62106("lib/Kconfig.debug: add ARCH dependency forFUNCTION_ALIGNoption"), riscv supports enabling theDEBUG_FORCE_FUNCTION_ALIGN_64Boption, but after that commit, each arch needs to claim the support explicitly. I tried the config file in
[1] for both RV64 and RV32, I can't reproduce the build error as [1], there is no reason for not allowing to enforce this function alignment.[...]
Here is the summary with links:
- riscv: enable DEBUG_FORCE_FUNCTION_ALIGN_64B
https://git.kernel.org/riscv/c/74f438e75483
You are awesome, thank you!
Signature · 9 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Palmer Dabbelt
AppliedQuoted 4 lines · Jisheng Zhang
Allow to force all function address 64B aligned as it is possible for other architectures. This may be useful when verify if performance bump is caused by function alignment changes.
Quoted 8 lines
Before commit
1bf18da62106("lib/Kconfig.debug: add ARCH dependency forFUNCTION_ALIGNoption"), riscv supports enabling theDEBUG_FORCE_FUNCTION_ALIGN_64Boption, but after that commit, each arch needs to claim the support explicitly. I tried the config file in
[1] for both RV64 and RV32, I can't reproduce the build error as [1], there is no reason for not allowing to enforce this function alignment.[...]
Applied, thanks!
[1/1] riscv: enable DEBUG_FORCE_FUNCTION_ALIGN_64B
https://git.kernel.org/palmer/c/74f438e75483
Best regards,
Signature · 7 lines
Palmer Dabbelt <[email protected]> _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv