Skip to contentSkip to conversation

arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply

PATCH In review David Heidelberg 3 participants 4 messages Jul 30, 2023 – Aug 10, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply

Resolves following warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +1 -1
index b3549eae6278..a8b5da3ca08f 100644
@@ -1031,7 +1031,7 @@ &usdhc2 {
 	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
 	bus-width = <4>;
 	vmmc-supply = <&reg_usdhc2_vmmc>;
-	power-supply = <&wifi_pwr_en>;
+	vqmmc-supply = <&wifi_pwr_en>;
 	broken-cd;
 	disable-wp;
 	cap-sdio-irq;
Signature · 1 line
2.40.1
#1 lore raw

Hi,

Quoted 16 lines · David Heidelberg

Resolves following warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +0 -0
index b3549eae6278..a8b5da3ca08f 100644

arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts &usdhc2 { · line 1034

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +1 -1
@@ -1031,7 +1031,7 @@ &usdhc2 {
 	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
 	bus-width = <4>;
 	vmmc-supply = <&reg_usdhc2_vmmc>;
-	power-supply = <&wifi_pwr_en>;
+	vqmmc-supply = <&wifi_pwr_en>;

From the schematics WIFI_PWR_EN connects to the Wifi card's W_DISABLE so I don't think vqmmc is correct here. I wonder if there's a better way to model that in DT? Any suggestions would be welcome.

Cheers,
-- Guido

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +0 -0
 	broken-cd;
 	disable-wp;
 	cap-sdio-irq;
Signature · 1 line
2.40.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

Hello David,
Hello Guido,

Quoted 13 lines · Guido Günther

Hi,

Quoted 11 lines · David Heidelberg

Resolves following warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts &usdhc2 { · line 1034

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +1 -1
index b3549eae6278..a8b5da3ca08f 100644
@@ -1031,7 +1031,7 @@ &usdhc2 {
 	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
 	bus-width = <4>;
 	vmmc-supply = <&reg_usdhc2_vmmc>;
-	power-supply = <&wifi_pwr_en>;
+	vqmmc-supply = <&wifi_pwr_en>;

From the schematics WIFI_PWR_EN connects to the Wifi card's W_DISABLE so I don't think vqmmc is correct here. I wonder if there's a better way to model that in DT? Any suggestions would be welcome.

I think mmc-pwrseq is what you are after.

Cheers,
Ahmad

Quoted 12 lines

Cheers,
-- Guido

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +0 -0
 	broken-cd;
 	disable-wp;
 	cap-sdio-irq;
Signature · 1 line
2.40.1
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw
Quoted 30 lines · Ahmad Fatoum

Hello David,
Hello Guido,

Quoted 13 lines · Guido Günther

Hi,

Quoted 11 lines · David Heidelberg

Resolves following warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#

---
  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts &usdhc2 { · line 1034

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +1 -1
index b3549eae6278..a8b5da3ca08f 100644
@@ -1031,7 +1031,7 @@ &usdhc2 {
  	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
  	bus-width = <4>;
  	vmmc-supply = <&reg_usdhc2_vmmc>;
-	power-supply = <&wifi_pwr_en>;
+	vqmmc-supply = <&wifi_pwr_en>;

From the schematics WIFI_PWR_EN connects to the Wifi card's W_DISABLE
so I don't think vqmmc is correct here. I wonder if there's a better way to model that in DT? Any suggestions would be welcome.

Quoted 1 line

I think mmc-pwrseq is what you are after.

Guido sent patch to replace it with mmc-pwrseq in https://www.spinics.net/lists/kernel/msg4894084.html

Signature · 2 lines
David Heidelberg
Certified Linux Magician