Skip to contentSkip to conversation

dma: at_hdmac: "(foo*)" should be "(foo *)"

PATCH In review [email protected] 2 participants 2 messages Jul 19, 2023 – Aug 1, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 dma: at_hdmac: "(foo*)" should be "(foo *)"

This patch fixes the checkpatch.pl error:

./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)"

---
 drivers/dma/at_hdmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/at_hdmac.c +0 -0
index ee3a219..af747a7 100644
@@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan *chan,
     /* Only the first byte of value is to be used according to 

dmaengine */

     fill_pattern = (char)value;

- *(u32*)vaddr = (fill_pattern << 24) |
+ *(u32 *)vaddr = (fill_pattern << 24) |

                (fill_pattern << 16) |
                (fill_pattern << 8) |
                fill_pattern;
maintainer
#2 lore raw
Quoted 5 lines · On 19-07-23, 16:48, [email protected] wrote:

This patch fixes the checkpatch.pl error:

./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)"

Thanks for the patch, the From for this patch should match the signed-off name, pls fix and resend

Quoted 18 lines
---
 drivers/dma/at_hdmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/at_hdmac.c +1 -1
index ee3a219..af747a7 100644
@@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan
 *chan,
     /* Only the first byte of value is to be used according to dmaengine */
     fill_pattern = (char)value;
 
-    *(u32*)vaddr = (fill_pattern << 24) |
+    *(u32 *)vaddr = (fill_pattern << 24) |
                (fill_pattern << 16) |
                (fill_pattern << 8) |
                fill_pattern;
Signature · 1 line
~Vinod