x86/hyperv: add noop functions to x86_init mpparse functions
Subsystems (3)
PATCH v3 1/1 x86/hyperv: add noop functions to x86_init mpparse functions
Hyper-V can run VMs at different privilege "levels" known as Virtual Trust Levels (VTL). Sometimes, it chooses to run two different VMs at different levels but they share some of their address space. In such setups VTL2 (higher level VM) has visibility of all of the VTL0 (level 0) memory space.
When the CONFIG_X86_MPPARSE is enabled for VTL2, the VTL2 kernel performs a search within the low memory to locate MP tables. However, in systems where VTL0 manages the low memory and may contain valid tables, this scanning can result in incorrect MP table information being provided to the VTL2 kernel, mistakenly considering VTL0's MP table as its own
Add noop functions to avoid MP parse scan by VTL2.
---
[V3]
- modify commit message.
arch/x86/hyperv/hv_vtl.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/x86/hyperv/hv_vtl.c +4 -0
@@ -25,6 +25,10 @@ void __init hv_vtl_init_platform(void) x86_init.irqs.pre_vector_init = x86_init_noop; x86_init.timers.timer_init = x86_init_noop; +/* Avoid searching for BIOS MP tables */ + x86_init.mpparse.find_smp_config = x86_init_noop; + x86_init.mpparse.get_smp_config = x86_init_uint_noop; + x86_platform.get_wallclock = get_rtc_noop; x86_platform.set_wallclock = set_rtc_noop; x86_platform.get_nmi_reason = hv_get_nmi_reason;
Signature · 1 line
2.34.1
Wei Liu
maintainerQuoted 13 lines · Saurabh Sengar
Hyper-V can run VMs at different privilege "levels" known as Virtual Trust Levels (VTL). Sometimes, it chooses to run two different VMs at different levels but they share some of their address space. In such setups VTL2 (higher level VM) has visibility of all of the VTL0 (level 0) memory space.
When the
CONFIG_X86_MPPARSEis enabled for VTL2, the VTL2 kernel performs a search within the low memory to locate MP tables. However, in systems where VTL0 manages the low memory and may contain valid tables, this scanning can result in incorrect MP table information being provided to the VTL2 kernel, mistakenly considering VTL0's MP table as its own
Quoted 3 lines
Add noop functions to avoid MP parse scan by VTL2.
Signed-off-by Saurabh Sengar <[email protected]>
Hi Dave, are you happy with the commit message?
Quoted 25 lines
---
[V3]
- modify commit message.arch/x86/hyperv/hv_vtl.c | 4 ++++ 1 file changed, 4 insertions(+)arch/x86/hyperv/hv_vtl.c +4
-0@@ -25,6 +25,10 @@ void __init hv_vtl_init_platform(void) x86_init.irqs.pre_vector_init = x86_init_noop; x86_init.timers.timer_init = x86_init_noop; +/* Avoid searching for BIOS MP tables */ + x86_init.mpparse.find_smp_config = x86_init_noop; + x86_init.mpparse.get_smp_config = x86_init_uint_noop; + x86_platform.get_wallclock = get_rtc_noop; x86_platform.set_wallclock = set_rtc_noop; x86_platform.get_nmi_reason = hv_get_nmi_reason;Signature · 1 line
2.34.1
Quoted 29 lines
-----Original Message-----
From: Wei Liu <[email protected]>
Sent: Wednesday, June 28, 2023 11:29 PM
To: Saurabh Sengar <[email protected]>
Cc: KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Michael Kelley (LINUX) <[email protected]>; [email protected]; linux- [email protected]; [email protected]
Subject: [EXTERNAL] Re: [PATCH v3] x86/hyperv: add noop functions tox86_initmpparse functionsQuoted 13 lines · Saurabh Sengar
Hyper-V can run VMs at different privilege "levels" known as Virtual Trust Levels (VTL). Sometimes, it chooses to run two different VMs at different levels but they share some of their address space. In such setups VTL2 (higher level VM) has visibility of all of the VTL0 (level 0) memory space.
When the
CONFIG_X86_MPPARSEis enabled for VTL2, the VTL2 kernel performs a search within the low memory to locate MP tables. However, in systems where VTL0 manages the low memory and may contain valid tables, this scanning can result in incorrect MP table information being provided to the VTL2 kernel, mistakenly considering VTL0's MP table as its own
Quoted 5 lines
Quoted 3 lines
Add noop functions to avoid MP parse scan by VTL2.
Signed-off-by Saurabh Sengar <[email protected]>Hi Dave, are you happy with the commit message?
HI Dave,
If there is no concern, can I get your ack
- Saurabh
Quoted 26 lines
Quoted 26 lines
---
[V3]
- modify commit message.arch/x86/hyperv/hv_vtl.c | 4 ++++ 1 file changed, 4 insertions(+)arch/x86/hyperv/hv_vtl.c index renamed from arch/x86/hyperv/hv_vtl.c +0
-0
85d38b9f3586..db5d2ea39fc0100644arch/x86/hyperv/hv_vtl.c +4
-1@@ -25,6 +25,10 @@ void __init hv_vtl_init_platform(void) x86_init.irqs.pre_vector_init = x86_init_noop; x86_init.timers.timer_init = x86_init_noop; +/* Avoid searching for BIOS MP tables */ + x86_init.mpparse.find_smp_config = x86_init_noop; + x86_init.mpparse.get_smp_config = x86_init_uint_noop; + x86_platform.get_wallclock = get_rtc_noop; x86_platform.set_wallclock = set_rtc_noop; x86_platform.get_nmi_reason = hv_get_nmi_reason; --2.34.1
Dave Hansen
Acked-byQuoted 14 lines · Saurabh Singh Sengar
Quoted 14 lines · Saurabh Sengar
Quoted 13 lines
Hyper-V can run VMs at different privilege "levels" known as Virtual Trust Levels (VTL). Sometimes, it chooses to run two different VMs at different levels but they share some of their address space. In such setups VTL2 (higher level VM) has visibility of all of the VTL0 (level 0) memory space.
When the
CONFIG_X86_MPPARSEis enabled for VTL2, the VTL2 kernel performs a search within the low memory to locate MP tables. However, in systems where VTL0 manages the low memory and may contain valid tables, this scanning can result in incorrect MP table information being provided to the VTL2 kernel, mistakenly considering VTL0's MP table as its own
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Add noop functions to avoid MP parse scan by VTL2.
Signed-off-by Saurabh Sengar <[email protected]>Hi Dave, are you happy with the commit message?
HI Dave,
If there is no concern, can I get your ack
Looks sane:
Although, if you muck with this any more having actual facts on what the "incorrect MP table information" causes would be nice too.
Quoted 13 lines · Saurabh Sengar
Hyper-V can run VMs at different privilege "levels" known as Virtual Trust Levels (VTL). Sometimes, it chooses to run two different VMs at different levels but they share some of their address space. In such setups VTL2 (higher level VM) has visibility of all of the VTL0 (level 0) memory space.
When the
CONFIG_X86_MPPARSEis enabled for VTL2, the VTL2 kernel performs a search within the low memory to locate MP tables. However, in systems where VTL0 manages the low memory and may contain valid tables, this scanning can result in incorrect MP table information being provided to the VTL2 kernel, mistakenly considering VTL0's MP table as its own
Quoted 3 lines
Add noop functions to avoid MP parse scan by VTL2.
Signed-off-by Saurabh Sengar <[email protected]>
Applied to hyperv-fixes. Thanks.