x86/head64: Harmonize the style of array-type parameter for fixup_pointer
PATCH 1/1 x86/head64: Harmonize the style of array-type parameter for fixup_pointer
The usage of '&' before the array parameter is redundant because '&array' is equivalent to 'array'. Therefore, there is no need to include '&' before the array parameter. In fact, using '&' can cause more confusion, especially for individuals who are not familiar with the address-of operation for arrays. They might mistakenly believe that one is different from the other and spend additional time realizing that they are actually the same.
Harmonizing the style by removing the unnecessary '&' would save time for those individuals.
--- arch/x86/kernel/head64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/kernel/head64.c +3 -3
@@ -211,7 +211,7 @@ unsigned long __head __startup_64(unsigned long physaddr,/* Fixup the physical addresses in the page table */ - pgd =fixup_pointer (&early_top_pgt, physaddr); + pgd =fixup_pointer (early_top_pgt, physaddr); p = pgd +pgd_index (__START_KERNEL_map);if (la57) *p = (unsigned long )level4_kernel_pgt;
@@ -220,11 +220,11 @@ unsigned long __head __startup_64(unsigned long physaddr, *p += _PAGE_TABLE_NOENC - __START_KERNEL_map + load_delta;if (la57) { - p4d =fixup_pointer (&level4_kernel_pgt, physaddr); + p4d =fixup_pointer (level4_kernel_pgt, physaddr); p4d[511 ] += load_delta; } - pud =fixup_pointer (&level3_kernel_pgt, physaddr); + pud =fixup_pointer (level3_kernel_pgt, physaddr); pud[510 ] += load_delta; pud[511 ] += load_delta;
Signature · 1 line
2.40.0
[tip: x86/boot] x86/boot: Harmonize the style of array-type parameter for fixup_pointer() calls
The following commit has been merged into the x86/boot branch of tip:
The following commit has been merged into the x86/boot branch of tip:
Commit-ID: 9f76d606269be7bd1ee5942b7c9c21bb0b43825f Gitweb: https://git.kernel.org/tip/9f76d606269be7bd1ee5942b7c9c21bb0b43825f Author: Wang Jinchao <[email protected]> AuthorDate: Thu, 03 Aug 2023 17:44:00 +08:00 Committer: Ingo Molnar <[email protected]> CommitterDate: Tue, 03 Oct 2023 11:28:38 +02:00
x86/boot: Harmonize the style of array-type parameter for fixup_pointer() calls
The usage of '&' before the array parameter is redundant because '&array' is equivalent to 'array'. Therefore, there is no need to include '&' before the array parameter. In fact, using '&' can cause more confusion, especially for individuals who are not familiar with the address-of operation for arrays. They might mistakenly believe that one is different from the other and spend additional time realizing that they are actually the same.
Harmonizing the style by removing the unnecessary '&' would save time for those individuals.
--- arch/x86/kernel/head64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/kernel/head64.c +3 -3
@@ -211,7 +211,7 @@ unsigned long __head __startup_64(unsigned long physaddr,/* Fixup the physical addresses in the page table */ - pgd =fixup_pointer (&early_top_pgt, physaddr); + pgd =fixup_pointer (early_top_pgt, physaddr); p = pgd +pgd_index (__START_KERNEL_map);if (la57) *p = (unsigned long )level4_kernel_pgt;
@@ -220,11 +220,11 @@ unsigned long __head __startup_64(unsigned long physaddr, *p += _PAGE_TABLE_NOENC - __START_KERNEL_map + load_delta;if (la57) { - p4d =fixup_pointer (&level4_kernel_pgt, physaddr); + p4d =fixup_pointer (level4_kernel_pgt, physaddr); p4d[511 ] += load_delta; } - pud =fixup_pointer (&level3_kernel_pgt, physaddr); + pud =fixup_pointer (level3_kernel_pgt, physaddr); pud[510 ] += load_delta; pud[511 ] += load_delta;