Skip to contentSkip to conversation

counter: rz-mtu3-cnt: Reorder locking sequence for consistency

PATCH Applied Biju Das 2 participants 2 messages Jul 25, 2023 – Aug 3, 2023

Subsystems (3)
IIO Counter Renesas RZ/G2L MTU3a counter driver
lore
Share & tools
lore

Biju Das

author maintainer
#0 lore raw

PATCH v3 1/1 counter: rz-mtu3-cnt: Reorder locking sequence for consistency

All functions except rz_mtu3_count_enable_write(), call pm_runtime_{get,put} inside the lock. For consistency do the same here.

Reported-by Pavel Machek <[email protected]>
Closes https://lore.kernel.org/r/[email protected] open here
Signed-off-by Biju Das <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

---
v2->v3:
* Updated commit description by replacing 'calls'->'call'.
* Added Rb tag from Geert.
v1->v2:
* Updated commit header to make it clear this is not addressing a bug, rather it's just cleanup.

---
 drivers/counter/rz-mtu3-cnt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/counter/rz-mtu3-cnt.c +2 -2
index 48c83933aa2f..ee821493b166 100644
@@ -500,8 +500,8 @@ static int rz_mtu3_count_enable_write(struct counter_device *counter,
 	int ret = 0;
 
 	if (enable) {
-		pm_runtime_get_sync(ch->dev);
 		mutex_lock(&priv->lock);
+		pm_runtime_get_sync(ch->dev);
 		ret = rz_mtu3_initialize_counter(counter, count->id);
 		if (ret == 0)
 			priv->count_is_enabled[count->id] = true;

@@ -510,8 +510,8 @@ static int rz_mtu3_count_enable_write(struct counter_device *counter,
 		mutex_lock(&priv->lock);
 		rz_mtu3_terminate_counter(counter, count->id);
 		priv->count_is_enabled[count->id] = false;
-		mutex_unlock(&priv->lock);
 		pm_runtime_put(ch->dev);
+		mutex_unlock(&priv->lock);
 	}
 
 	return ret;
Signature · 1 line
2.25.1