mm: move dummy_vm_ops out of a header
Subsystems (2)
PATCH 1/1 mm: move dummy_vm_ops out of a header
Otherwise the kernel ends up with multiple copies:
$ nm vmlinux | grep dummy_vm_ops ffffffff81e4ea00 d dummy_vm_ops.2 ffffffff81e11760 d dummy_vm_ops.254 ffffffff81e406e0 d dummy_vm_ops.4 ffffffff81e3c780 d dummy_vm_ops.7
While here prefix it with vma_.
[if someone has better ideas where to put it, please move it]
--- include/linux/mm.h | 6 +++--- mm/init-mm.c | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/mm.h +3 -3
@@ -756,17 +756,17 @@ static inline void vma_mark_detached(struct vm_area_struct *vma,#endif /* CONFIG_PER_VMA_LOCK */ +extern const struct vm_operations_struct vma_dummy_vm_ops; +/* * WARNING: vma_init does not initialize vma->vm_lock. * Use vm_area_alloc()/vm_area_free() if vma needs locking. */ static inline void vma_init (struct vm_area_struct *vma,struct mm_struct *mm) { -static const struct vm_operations_struct dummy_vm_ops = {}; -memset (vma,0 ,sizeof (*vma)); vma->vm_mm = mm; - vma->vm_ops = &dummy_vm_ops; + vma->vm_ops = &vma_dummy_vm_ops;INIT_LIST_HEAD (&vma->anon_vma_chain);vma_mark_detached (vma, false);vma_numab_state_init (vma);
mm/init-mm.c +2 -0
@@ -17,6 +17,8 @@#define INIT_MM_CONTEXT (name)#endif +const struct vm_operations_struct vma_dummy_vm_ops; +/* * For dynamically allocated mm_structs, there is a dynamically sized cpumask * at the end of the structure, the size of which depends on the maximum CPU
Signature · 1 line
2.39.2
Quoted 8 lines · Mateusz Guzik
Otherwise the kernel ends up with multiple copies:
$ nm vmlinux | grep dummy_vm_ops ffffffff81e4ea00 d dummy_vm_ops.2 ffffffff81e11760 d dummy_vm_ops.254 ffffffff81e406e0 d dummy_vm_ops.4 ffffffff81e3c780 d dummy_vm_ops.7While here prefix it with
vma_.
It really shouldn't be prefixed with vma. Other than that, I love this patch.
Quoted 50 lines
[if someone has better ideas where to put it, please move it]
Signed-off-by Mateusz Guzik <[email protected]>--- include/linux/mm.h | 6 +++--- mm/init-mm.c | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-)include/linux/mm.h +3
-3@@ -756,17 +756,17 @@ static inline void vma_mark_detached(struct vm_area_struct *vma,#endif /* CONFIG_PER_VMA_LOCK */ +extern const struct vm_operations_struct vma_dummy_vm_ops; +/* * WARNING: vma_init does not initialize vma->vm_lock. * Use vm_area_alloc()/vm_area_free() if vma needs locking. */ static inline void vma_init (struct vm_area_struct *vma,struct mm_struct *mm) { -static const struct vm_operations_struct dummy_vm_ops = {}; -memset (vma,0 ,sizeof (*vma)); vma->vm_mm = mm; - vma->vm_ops = &dummy_vm_ops; + vma->vm_ops = &vma_dummy_vm_ops;INIT_LIST_HEAD (&vma->anon_vma_chain);vma_mark_detached (vma, false);vma_numab_state_init (vma);mm/init-mm.c +2
-0@@ -17,6 +17,8 @@#define INIT_MM_CONTEXT (name)#endif +const struct vm_operations_struct vma_dummy_vm_ops; +/* * For dynamically allocated mm_structs, there is a dynamically sized cpumask * at the end of the structure, the size of which depends on the maximum CPU Signature · 1 line
2.39.2
Quoted 8 lines · Matthew Wilcox
Quoted 7 lines · Mateusz Guzik
Otherwise the kernel ends up with multiple copies:
$ nm vmlinux | grep dummy_vm_ops ffffffff81e4ea00 d dummy_vm_ops.2 ffffffff81e11760 d dummy_vm_ops.254 ffffffff81e406e0 d dummy_vm_ops.4 ffffffff81e3c780 d dummy_vm_ops.7
Quoted 5 lines
Quoted 1 line
While here prefix it with
vma_.It really shouldn't be prefixed with vma. Other than that, I love this patch.
I think an unprefixed global is iffy, but I'm not going to insist on semi-cosmetics.
The one thing I expected people to complain about is the location of the struct. The mm_init.c file was the least bad choice I found, but maybe something else is preferred?
I'm just trying to avoid sending V3 for this patch after someone claims dummy ops should land elsewhere. ;)
Signature · 1 line
Mateusz Guzik <mjguzik gmail.com>