Skip to contentSkip to conversation

dma/idxd: add reset in the init routine

PATCH Applied Frank Du 3 participants 3 messages Aug 11, 2023 – Oct 17, 2023

Subsystems (2)
lore
Share & tools
lore

Frank Du

author
#0 lore raw

PATCH 1/1 dma/idxd: add reset in the init routine

Fix for windows, no one reset the dev to a clear status. In Linux, kernel driver will reset during the prob.

---
 drivers/dma/idxd/idxd_pci.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/dma/idxd/idxd_pci.c +8 -0
index 3696c7f452..a78889a7ef 100644
@@ -196,6 +196,14 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,
 	pci->portals = dev->mem_resource[2].addr;
 	pci->wq_cfg_sz = (pci->regs->wqcap >> 24) & 0x0F;
 
+	/* reset */
+	idxd->u.pci = pci;
+	err_code = idxd_pci_dev_command(idxd, idxd_reset_device);
+	if (err_code) {
+		IDXD_PMD_ERR("Error reset device: code %#x", err_code);
+		goto err;
+	}
+
 	/* sanity check device status */
 	if (pci->regs->gensts & GENSTS_DEV_STATE_MASK) {
 		/* need function-level-reset (FLR) or is enabled */
Signature · 1 line
2.34.1
#2 lore raw

14/08/2023 17:37, Bruce Richardson:

Quoted 12 lines · Frank Du
Quoted 8 lines

Fix for windows, no one reset the dev to a clear status. In Linux, kernel driver will reset during the prob.

---
 drivers/dma/idxd/idxd_pci.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Ran some sanity tests on Linux and saw no issues.

Applied, thanks.