Skip to contentSkip to conversation

gpio: mxc: set the port->irq high to 0 for imx2

PATCH In review [email protected] 2 participants 2 messages Aug 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: mxc: set the port->irq high to 0 for imx2

From: Haibo Chen <[email protected]>

MX2 has one interrupt for all gpio ports, so do not need the value port->irq_high, need to set to 0. Current setting is -1, which will meet issue in gpio_set_wake_irq().

Fixes 5f6d1998adeb ("gpio: mxc: release the parent IRQ in runtime suspend")
---
 drivers/gpio/gpio-mxc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-mxc.c +1 -1
index 004c6ad7ce52..c96602da7e3a 100644
@@ -479,7 +479,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
 		 * the handler is needed only once, but doing it for every port
 		 * is more robust and easier.
 		 */
-		port->irq_high = -1;
+		port->irq_high = 0;
 		port->mx_irq_handler = mx2_gpio_irq_handler;
 	} else
 		port->mx_irq_handler = mx3_gpio_irq_handler;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 5 lines · On Mon, Aug 21, 2023 at 11:14:43AM +0800, [email protected] wrote:

From: Haibo Chen <[email protected]>

MX2 has one interrupt for all gpio ports, so do not need the value port->irq_high, need to set to 0. Current setting is -1, which will meet issue in gpio_set_wake_irq().

Can you describe a bit more the nature of the issue?

Signature · 2 lines
With Best Regards,
Andy Shevchenko