pinctrl: cherryview: fix address_space_handler() argument
Subsystems (4)
PATCH v2 1/1 pinctrl: cherryview: fix address_space_handler() argument
First argument of acpi_*_address_space_handler() APIs is acpi_handle of the device, which is incorrectly passed in driver ->remove() path here. Fix it by passing the appropriate argument and while at it, make both API calls consistent using ACPI_HANDLE().
---
Changes since v1:
- Update subject and commit message
drivers/pinctrl/intel/pinctrl-cherryview.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pinctrl/intel/pinctrl-cherryview.c +2 -3
@@ -1650,7 +1650,6 @@ static int chv_pinctrl_probe(struct platform_device *pdev)struct intel_community_context *cctx;struct intel_community *community;struct device *dev = &pdev->dev; -struct acpi_device *adev =ACPI_COMPANION (dev);struct intel_pinctrl *pctrl;acpi_status status;unsigned int i;
@@ -1718,7 +1717,7 @@ static int chv_pinctrl_probe(struct platform_device *pdev)if (ret)return ret; - status =acpi_install_address_space_handler (adev->handle, + status =acpi_install_address_space_handler (ACPI_HANDLE (dev), community->acpi_space_id, chv_pinctrl_mmio_access_handler,NULL , pctrl);
@@ -1735,7 +1734,7 @@ static int chv_pinctrl_remove(struct platform_device *pdev)struct intel_pinctrl *pctrl =platform_get_drvdata (pdev);const struct intel_community *community = &pctrl->communities[0 ]; -acpi_remove_address_space_handler (ACPI_COMPANION (&pdev->dev), +acpi_remove_address_space_handler (ACPI_HANDLE (&pdev->dev), community->acpi_space_id, chv_pinctrl_mmio_access_handler);
Signature · 1 line
2.17.1
Quoted 8 lines · Raag Jadav
First argument of acpi_*_address_space_handler() APIs is
acpi_handleof the device, which is incorrectly passed in driver ->remove() path here. Fix it by passing the appropriate argument and while at it, make both API calls consistent usingACPI_HANDLE().Fixes a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")Signed-off-by Raag Jadav <[email protected]>
Quoted 11 lines · Mika Westerberg
Quoted 8 lines · Raag Jadav
First argument of acpi_*_address_space_handler() APIs is
acpi_handleof the device, which is incorrectly passed in driver ->remove() path here. Fix it by passing the appropriate argument and while at it, make both API calls consistent usingACPI_HANDLE().Fixes a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")Signed-off-by Raag Jadav <[email protected]>Acked-by Mika Westerberg <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko