lsm: constify 'sb' parameter in security_sb_kern_mount()
Subsystems (2)
PATCH 1/1 lsm: constify 'sb' parameter in security_sb_kern_mount()
The "sb_kern_mount" hook has implementation registered in SELinux. Looking at the function implementation we observe that the "sb" parameter is not changing.
Mark the "sb" parameter of LSM hook security_sb_kern_mount() as "const" since it will not be changing in the LSM hook.
Signed-off-by Khadija Kamran <[email protected]>
--- include/linux/lsm_hook_defs.h | 2 +- include/linux/security.h | 2 +- security/security.c | 2 +- security/selinux/hooks.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-)
include/linux/lsm_hook_defs.h +1 -1
@@ -65,7 +65,7 @@ LSM_HOOK(void, LSM_RET_VOID, sb_free_mnt_opts, void *mnt_opts) LSM_HOOK(int, 0, sb_eat_lsm_opts, char *orig, void **mnt_opts) LSM_HOOK(int, 0, sb_mnt_opts_compat, struct super_block *sb, void *mnt_opts) LSM_HOOK(int, 0, sb_remount, struct super_block *sb, void *mnt_opts) -LSM_HOOK(int, 0, sb_kern_mount, struct super_block *sb) +LSM_HOOK(int, 0, sb_kern_mount, const struct super_block *sb) LSM_HOOK(int, 0, sb_show_options, struct seq_file *m, struct super_block *sb) LSM_HOOK(int, 0, sb_statfs, struct dentry *dentry) LSM_HOOK(int, 0, sb_mount, const char *dev_name, const struct path *path,
include/linux/security.h +1 -1
@@ -302,7 +302,7 @@ void security_free_mnt_opts(void **mnt_opts);int security_sb_eat_lsm_opts (char *options,void **mnt_opts);int security_sb_mnt_opts_compat (struct super_block *sb,void *mnt_opts);int security_sb_remount (struct super_block *sb,void *mnt_opts); -int security_sb_kern_mount (struct super_block *sb); +int security_sb_kern_mount (const struct super_block *sb);int security_sb_show_options (struct seq_file *m,struct super_block *sb);int security_sb_statfs (struct dentry *dentry); int security_sb_mount(const char *dev_name, const struct path *path,
security/security.c +1 -1
@@ -1304,7 +1304,7 @@ EXPORT_SYMBOL(security_sb_remount);* * Return: Returns 0 if permission is granted. */ -int security_sb_kern_mount (struct super_block *sb) +int security_sb_kern_mount (const struct super_block *sb) {return call_int_hook (sb_kern_mount,0 , sb); }
security/selinux/hooks.c +2 -2
@@ -1886,7 +1886,7 @@ static inline int may_rename(struct inode *old_dir,/* Check whether a task can perform a filesystem operation. */ static int superblock_has_perm (const struct cred *cred, -struct super_block *sb, +const struct super_block *sb,u32 perms,struct common_audit_data *ad) {
@@ -2670,7 +2670,7 @@ static int selinux_sb_remount(struct super_block *sb, void *mnt_opts)return -EINVAL ; } -static int selinux_sb_kern_mount (struct super_block *sb) +static int selinux_sb_kern_mount (const struct super_block *sb) {const struct cred *cred =current_cred ();struct common_audit_data ad;
Signature · 1 line
2.34.1
Quoted 8 lines · On Aug 23, 2023 Khadija Kamran <[email protected]> wrote:
The "
sb_kern_mount" hook has implementation registered in SELinux. Looking at the function implementation we observe that the "sb" parameter is not changing.Mark the "sb" parameter of LSM hook
security_sb_kern_mount()as "const" since it will not be changing in the LSM hook.
Quoted 7 lines
Signed-off-by Khadija Kamran <[email protected]>--- include/linux/lsm_hook_defs.h | 2 +- include/linux/security.h | 2 +- security/security.c | 2 +- security/selinux/hooks.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-)
Merged into lsm/next, thanks!
--
paul-moore.com