Skip to contentSkip to conversation

igb: disable virtualization features on 82580

PATCH Applied Corinna Vinschen 3 participants 4 messages Aug 31, 2023 – Sep 4, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 igb: disable virtualization features on 82580

Disable virtualization features on 82580 just as on i210/i211. This avoids that virt functions are acidentally called on 82850.

Fixes 55cac248caa4 ("igb: Add full support for 82580 devices")
---
 drivers/net/ethernet/intel/igb/igb_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/igb/igb_main.c +3 -2
index 1ab787ed254d..13ba9c74bd84 100644
@@ -3933,8 +3933,9 @@ static void igb_probe_vfs(struct igb_adapter *adapter)
 	struct pci_dev *pdev = adapter->pdev;
 	struct e1000_hw *hw = &adapter->hw;
 
-	/* Virtualization features not supported on i210 family. */
-	if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211))
+	/* Virtualization features not supported on i210 and 82580 family. */
+	if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211) ||
+	    (hw->mac.type == e1000_82580))
 		return;
 
 	/* Of the below we really only want the effect of getting
Signature · 1 line
2.31.1
#2 lore raw
In reply to Corinna Vinschen
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Thu, 31 Aug 2023 14:19:13 +0200 you wrote:

Disable virtualization features on 82580 just as on i210/i211. This avoids that virt functions are acidentally called on 82850.

Fixes 55cac248caa4 ("igb: Add full support for 82580 devices")
---
 drivers/net/ethernet/intel/igb/igb_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Here is the summary with links:
- [v2,net] igb: disable virtualization features on 82580

    https://git.kernel.org/netdev/net/c/fa09bc40b21a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#3 lore raw
Quoted 15 lines · On Sep 3 13:12, [email protected] wrote:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Thu, 31 Aug 2023 14:19:13 +0200 you wrote:

Disable virtualization features on 82580 just as on i210/i211. This avoids that virt functions are acidentally called on 82850.

Fixes 55cac248caa4 ("igb: Add full support for 82580 devices")
---
 drivers/net/ethernet/intel/igb/igb_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 3 lines

Here is the summary with links:
- [v2,net] igb: disable virtualization features on 82580

    https://git.kernel.org/netdev/net/c/fa09bc40b21a

Thank you! Will my first patch

igb: clean up in all error paths when enabling SR-IOV

https://lore.kernel.org/netdev/[email protected]/

get applied as well? While I reproduced this on 82580 only, there might be some other reason why pci_enable_sriov() fails, independent of the actual NIC.

Thanks,
Corinna