staging: vt6655: Type encoding info dropped from array name "byVT3253B0_"
PATCH v3 1/1 staging: vt6655: Type encoding info dropped from array name "byVT3253B0_"
Below array names updated as per coding guidelines:
1.byVT3253B0_AGC4_RFMD2959
2.byVT3253B0_AIROHA2230
3.byVT3253B0_UW2451
4.byVT3253B0_AGC
Conversions performed:
a.type encoding info dropped from names
b.names replaced by snakecase
Issue found by checkpatch
---
v1 -> v2: Name of the tool added in the body of explanation,
which found this issue
v2 -> v3: subject modified to more specific detail
drivers/staging/vt6655/baseband.c | 32 +++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/staging/vt6655/baseband.c +16 -16
@@ -761,7 +761,7 @@ static const unsigned char vt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = {#define CB_VT3253B0_AGC_FOR_RFMD2959 195/* For RFMD2959 */ static -unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_FOR_RFMD2959 ][2 ] = { +unsigned char vt3253b0_agc4_rfmd2959[CB_VT3253B0_AGC_FOR_RFMD2959 ][2 ] = { {0xF0 ,0x00 }, {0xF1 ,0x3E }, {0xF0 ,0x80 },
@@ -962,7 +962,7 @@ unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_FOR_RFMD2959][2] = {#define CB_VT3253B0_INIT_FOR_AIROHA2230 256/* For AIROHA */ static -unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_FOR_AIROHA2230 ][2 ] = { +unsigned char vt3253b0_airoha2230[CB_VT3253B0_INIT_FOR_AIROHA2230 ][2 ] = { {0x00 ,0x31 }, {0x01 ,0x00 }, {0x02 ,0x00 },
@@ -1223,7 +1223,7 @@ unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_FOR_AIROHA2230][2] = {#define CB_VT3253B0_INIT_FOR_UW2451 256/* For UW2451 */ -static unsigned char byVT3253B0_UW2451[CB_VT3253B0_INIT_FOR_UW2451 ][2 ] = { +static unsigned char vt3253b0_uw2451[CB_VT3253B0_INIT_FOR_UW2451 ][2 ] = { {0x00 ,0x31 }, {0x01 ,0x00 }, {0x02 ,0x00 },
@@ -1484,7 +1484,7 @@ static unsigned char byVT3253B0_UW2451[CB_VT3253B0_INIT_FOR_UW2451][2] = {#define CB_VT3253B0_AGC 193/* For AIROHA */ -static unsigned char byVT3253B0_AGC[CB_VT3253B0_AGC ][2 ] = { +static unsigned char vt3253b0_agc[CB_VT3253B0_AGC ][2 ] = { {0xF0 ,0x00 }, {0xF1 ,0x00 }, {0xF0 ,0x80 },
@@ -2010,8 +2010,8 @@ bool bb_vt3253_init(struct vnt_private *priv)for (ii =0 ; ii <CB_VT3253B0_AGC_FOR_RFMD2959 ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_AGC4_RFMD2959[ii][0 ], - byVT3253B0_AGC4_RFMD2959[ii][1 ]); + vt3253b0_agc4_rfmd2959[ii][0 ], + vt3253b0_agc4_rfmd2959[ii][1 ]);iowrite32 (0x23 , iobase +MAC_REG_ITRTMSET );vt6655_mac_reg_bits_on (iobase,MAC_REG_PAPEDELAY ,BIT (0 ));
@@ -2027,12 +2027,12 @@ bool bb_vt3253_init(struct vnt_private *priv) }else if ((by_rf_type ==RF_AIROHA ) || (by_rf_type ==RF_AL2230S )) {for (ii =0 ; ii <CB_VT3253B0_INIT_FOR_AIROHA2230 ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_AIROHA2230[ii][0 ], - byVT3253B0_AIROHA2230[ii][1 ]); + vt3253b0_airoha2230[ii][0 ], + vt3253b0_airoha2230[ii][1 ]);for (ii =0 ; ii <CB_VT3253B0_AGC ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_AGC[ii][0 ], byVT3253B0_AGC[ii][1 ]); + vt3253b0_agc[ii][0 ], vt3253b0_agc[ii][1 ]); priv->abyBBVGA[0 ] =0x1C ; priv->abyBBVGA[1 ] =0x10 ;
@@ -2045,13 +2045,13 @@ bool bb_vt3253_init(struct vnt_private *priv) }else if (by_rf_type ==RF_UW2451 ) {for (ii =0 ; ii <CB_VT3253B0_INIT_FOR_UW2451 ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_UW2451[ii][0 ], - byVT3253B0_UW2451[ii][1 ]); + vt3253b0_uw2451[ii][0 ], + vt3253b0_uw2451[ii][1 ]);for (ii =0 ; ii <CB_VT3253B0_AGC ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_AGC[ii][0 ], - byVT3253B0_AGC[ii][1 ]); + vt3253b0_agc[ii][0 ], + vt3253b0_agc[ii][1 ]);iowrite8 (0x23 , iobase +MAC_REG_ITRTMSET );vt6655_mac_reg_bits_on (iobase,MAC_REG_PAPEDELAY ,BIT (0 ));
@@ -2067,12 +2067,12 @@ bool bb_vt3253_init(struct vnt_private *priv) }else if (by_rf_type ==RF_VT3226 ) {for (ii =0 ; ii <CB_VT3253B0_INIT_FOR_AIROHA2230 ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_AIROHA2230[ii][0 ], - byVT3253B0_AIROHA2230[ii][1 ]); + vt3253b0_airoha2230[ii][0 ], + vt3253b0_airoha2230[ii][1 ]);for (ii =0 ; ii <CB_VT3253B0_AGC ; ii++) result &=bb_write_embedded (priv, - byVT3253B0_AGC[ii][0 ], byVT3253B0_AGC[ii][1 ]); + vt3253b0_agc[ii][0 ], vt3253b0_agc[ii][1 ]); priv->abyBBVGA[0 ] =0x1C ; priv->abyBBVGA[1 ] =0x10 ;
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 13 lines · Pavan Bobba
Below array names updated as per coding guidelines:
1.byVT3253B0_AGC4_RFMD2959 2.byVT3253B0_AIROHA2230 3.byVT3253B0_UW2451 4.byVT3253B0_AGC Conversions performed: a.type encoding info dropped from names b.names replaced by snakecase Issue found by checkpatch
Quoted 6 lines
Signed-off-by Pavan Bobba <[email protected]>---
v1 -> v2: Name of the tool added in the body of explanation,
which found this issuev2 -> v3: subject modified to more specific detail
Any specific reason you are not sending this to the maintainer that can take it?
Also, your changelog needs work, please read the link the bot referred you to.
thanks,
greg k-h
Quoted 19 lines · Greg KH
Quoted 18 lines · Pavan Bobba
Below array names updated as per coding guidelines:
1.byVT3253B0_AGC4_RFMD2959 2.byVT3253B0_AIROHA2230 3.byVT3253B0_UW2451 4.byVT3253B0_AGC Conversions performed: a.type encoding info dropped from names b.names replaced by snakecase Issue found by checkpatchSigned-off-by Pavan Bobba <[email protected]>---
v1 -> v2: Name of the tool added in the body of explanation,
which found this issue
Quoted 4 lines
Quoted 1 line
v2 -> v3: subject modified to more specific detail
Any specific reason you are not sending this to the maintainer that can take it?
i used scripts/get_maintainer.pl to get maintainers names and i am adding all those people to the mail. kindly let me know the maintainer id and the correct way to know the mainter of a file
Quoted 7 lines
Also, your changelog needs work, please read the link the bot referred you to.
thanks,
greg k-h
sure. i will cross check once. Thank you
Quoted 20 lines · Pavan Bobba
Quoted 19 lines · Greg KH
Quoted 18 lines · Pavan Bobba
Below array names updated as per coding guidelines:
1.byVT3253B0_AGC4_RFMD2959 2.byVT3253B0_AIROHA2230 3.byVT3253B0_UW2451 4.byVT3253B0_AGC Conversions performed: a.type encoding info dropped from names b.names replaced by snakecase Issue found by checkpatchSigned-off-by Pavan Bobba <[email protected]>---
v1 -> v2: Name of the tool added in the body of explanation,
which found this issue
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
v2 -> v3: subject modified to more specific detail
Any specific reason you are not sending this to the maintainer that can take it?
i used
scripts/get_maintainer.plto get maintainers names and i am adding all those people to the mail. kindly let me know the maintainer id and the correct way to know the mainter of a file
./scripts/get_maintainer.pl ~/Downloads/PATCH-v3-staging-vt6655-Type-encoding-info-dropped-from-array-name-byVT3253B0_.txt
Forest Bond <[email protected]> (odd fixer:STAGING - VIA VT665X DRIVERS)
Greg Kroah-Hartman <[email protected]> (supporter:STAGING SUBSYSTEM,commit_signer:2/2=100%) Michael Straube <[email protected]> (commit_signer:2/2=100%,authored:2/2=100%,removed_lines:44/44=100%) [email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
Greg shows up as one of the maintainers for me.
Either a bug with get_maintainer.pl (unlikely), or you did something incorrectly.
Best regards,
Nam
Quoted 36 lines · Nam Cao
Quoted 20 lines · Pavan Bobba
Quoted 19 lines · Greg KH
Quoted 18 lines · Pavan Bobba
Below array names updated as per coding guidelines:
1.byVT3253B0_AGC4_RFMD2959 2.byVT3253B0_AIROHA2230 3.byVT3253B0_UW2451 4.byVT3253B0_AGC Conversions performed: a.type encoding info dropped from names b.names replaced by snakecase Issue found by checkpatchSigned-off-by Pavan Bobba <[email protected]>---
v1 -> v2: Name of the tool added in the body of explanation,
which found this issueQuoted 7 lines
Quoted 4 lines
Quoted 1 line
v2 -> v3: subject modified to more specific detail
Any specific reason you are not sending this to the maintainer that can take it?
i used
scripts/get_maintainer.plto get maintainers names and i am adding all those people to the mail. kindly let me know the maintainer id and the correct way to know the mainter of a file./scripts/get_maintainer.pl ~/Downloads/PATCH-v3-staging-vt6655-Type-encoding-info-dropped-from-array-name-byVT3253B0_.txtForest Bond <[email protected]> (odd fixer:STAGING - VIA VT665X DRIVERS)
Greg Kroah-Hartman <[email protected]> (supporter:STAGING SUBSYSTEM,commit_signer:2/2=100%) Michael Straube <[email protected]> (commit_signer:2/2=100%,authored:2/2=100%,removed_lines:44/44=100%) [email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
Quoted 6 lines
Greg shows up as one of the maintainers for me.
Either a bug with get_maintainer.pl (unlikely), or you did something incorrectly.
Best regards,
Nam
yes. now it is showing Greg as maintainer for me too. i might have used the script incorrectly earlier. added Greg to my mail while sending next patch.
Thank you,
pavan