Skip to contentSkip to conversation

memory-hotplug.rst: fix wrong /sys/device/ path

PATCH Applied Wang Jinchao 3 participants 3 messages Sep 22, 2023

Subsystems (4)
Memory management Documentation MM misc Memory hot(un)plug
lore
Share & tools
lore

Wang Jinchao

author
#0 lore raw

PATCH 1/1 memory-hotplug.rst: fix wrong /sys/device/ path

Actually, it should be /sys/devices/

Signed-off-by Wang Jinchao <[email protected]>
---
 Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/admin-guide/mm/memory-hotplug.rst +4 -4
index cfe034cf1e87..01595965734a 100644
@@ -250,15 +250,15 @@ Observing the State of Memory Blocks
 The state (online/offline/going-offline) of a memory block can be observed
 either via::
 
-	% cat /sys/device/system/memory/memoryXXX/state
+	% cat /sys/devices/system/memory/memoryXXX/state
 
 Or alternatively (1/0) via::
 
-	% cat /sys/device/system/memory/memoryXXX/online
+	% cat /sys/devices/system/memory/memoryXXX/online
 
 For an online memory block, the managing zone can be observed via::
 
-	% cat /sys/device/system/memory/memoryXXX/valid_zones
+	% cat /sys/devices/system/memory/memoryXXX/valid_zones
 
 Configuring Memory Hot(Un)Plug
 ==============================

@@ -326,7 +326,7 @@ however, a memory block might span memory holes. A memory block spanning memory
 holes cannot be offlined.
 
 For example, assume 1 GiB memory block size. A device for a memory starting at
-0x100000000 is ``/sys/device/system/memory/memory4``::
+0x100000000 is ``/sys/devices/system/memory/memory4``::
 
 	(0x100000000 / 1Gib = 4)
Signature · 1 line
2.40.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 31 lines · Wang Jinchao

Actually, it should be /sys/devices/

Signed-off-by Wang Jinchao <[email protected]>
---
  Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/admin-guide/mm/memory-hotplug.rst +3 -3
index cfe034cf1e87..01595965734a 100644
@@ -250,15 +250,15 @@ Observing the State of Memory Blocks
  The state (online/offline/going-offline) of a memory block can be observed
  either via::
 
-	% cat /sys/device/system/memory/memoryXXX/state
+	% cat /sys/devices/system/memory/memoryXXX/state
 
  Or alternatively (1/0) via::
 
-	% cat /sys/device/system/memory/memoryXXX/online
+	% cat /sys/devices/system/memory/memoryXXX/online
 
  For an online memory block, the managing zone can be observed via::
 
-	% cat /sys/device/system/memory/memoryXXX/valid_zones
+	% cat /sys/devices/system/memory/memoryXXX/valid_zones
 
  Configuring Memory Hot(Un)Plug
  ==============================

Documentation/admin-guide/mm/memory-hotplug.rst however, a memory block might span memory holes. A memory block spanning memory · line 332

Quoted 8 lines
Documentation/admin-guide/mm/memory-hotplug.rst +1 -1
@@ -326,7 +326,7 @@ however, a memory block might span memory holes. A memory block spanning memory
  holes cannot be offlined.
 
  For example, assume 1 GiB memory block size. A device for a memory starting at
-0x100000000 is ``/sys/device/system/memory/memory4``::
+0x100000000 is ``/sys/devices/system/memory/memory4``::
 
  	(0x100000000 / 1Gib = 4)
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Cheers,

David / dhildenb