pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
Subsystems (3)
PATCH 1/1 pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE() as it will be consistent with the content of the real ID table of the platform devices.
--- drivers/pinctrl/intel/pinctrl-denverton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/pinctrl-denverton.c +1 -1
@@ -261,6 +261,7 @@ static const struct platform_device_id dnv_pinctrl_platform_ids[] = { { "denverton-pinctrl", (kernel_ulong_t)&dnv_soc_data }, { } }; +MODULE_DEVICE_TABLE (platform, dnv_pinctrl_platform_ids);static struct platform_driver dnv_pinctrl_driver = { .probe = intel_pinctrl_probe_by_hid,
@@ -287,5 +288,4 @@ module_exit(dnv_pinctrl_exit);MODULE_AUTHOR ("Mika Westerberg <[email protected]>" );MODULE_DESCRIPTION ("Intel Denverton SoC pinctrl/GPIO driver" );MODULE_LICENSE ("GPL v2" ); -MODULE_ALIAS ("platform:denverton-pinctrl" );MODULE_IMPORT_NS (PINCTRL_INTEL );
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 6 lines · Andy Shevchenko
As Krzysztof pointed out the better is to use
MODULE_DEVICE_TABLE()as it will be consistent with the content of the real ID table of the platform devices.Suggested-by Krzysztof Kozlowski <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Quoted 10 lines · Andy Shevchenko
As Krzysztof pointed out the better is to use
MODULE_DEVICE_TABLE()as it will be consistent with the content of the real ID table of the platform devices.Suggested-by Krzysztof Kozlowski <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/pinctrl/intel/pinctrl-denverton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards,
Krzysztof
Quoted 6 lines · Krzysztof Kozlowski
Quoted 3 lines · Andy Shevchenko
As Krzysztof pointed out the better is to use
MODULE_DEVICE_TABLE()as it will be consistent with the content of the real ID table of the platform devices.Reviewed-by Krzysztof Kozlowski <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko