perf build: Add missing comment about NO_LIBTRACEEVENT=1
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf build: Add missing comment about NO_LIBTRACEEVENT=1
From: Arnaldo Carvalho de Melo <[email protected]>
By default perf will fail the build if the development files for libtraceevent are not available.
To build perf without libtraceevent support, disabling several features such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make command line.
Add the missing comments about that to the tools/perf/Makefile.perf file, just like all the other such command line toggles.
--- tools/perf/Makefile.perf | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/Makefile.perf +4 -0
@@ -69,6 +69,10 @@ include ../scripts/utilities.mak # Define NO_LIBDW_DWARF_UNWIND if you do not want libdw support # for dwarf backtrace post unwind. # +# Define NO_LIBTRACEEVENT=1 if you don't want libtraceevent to be linked, +# this will remove multiple features and tools, such as 'perf trace', +# that need it to read tracefs event format files, etc. +# # Define NO_PERF_READ_VDSO32 if you do not want to build perf-read-vdso32 # for reading the 32-bit compatibility VDSO in 64-bit mode #
Signature · 3 lines
2.41.0 --
Quoted 13 lines · Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <[email protected]>
By default perf will fail the build if the development files for libtraceevent are not available.
To build perf without libtraceevent support, disabling several features such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make command line.
Add the missing comments about that to the
tools/perf/Makefile.perffile, just like all the other such command line toggles.
Quoted 6 lines
Fixes 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Jiri Olsa <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Thanks,
Ian
Quoted 23 lines
--- tools/perf/Makefile.perf | 4 ++++ 1 file changed, 4 insertions(+)tools/perf/Makefile.perf +4
-1@@ -69,6 +69,10 @@ include ../scripts/utilities.mak # Define NO_LIBDW_DWARF_UNWIND if you do not want libdw support # for dwarf backtrace post unwind. # +# Define NO_LIBTRACEEVENT=1 if you don't want libtraceevent to be linked, +# this will remove multiple features and tools, such as 'perf trace', +# that need it to read tracefs event format files, etc. +# # Define NO_PERF_READ_VDSO32 if you do not want to build perf-read-vdso32 # for reading the 32-bit compatibility VDSO in 64-bit mode # --2.41.0
--
Quoted 15 lines · Ian Rogers
Quoted 13 lines · Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <[email protected]>
By default perf will fail the build if the development files for libtraceevent are not available.
To build perf without libtraceevent support, disabling several features such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make command line.
Add the missing comments about that to the
tools/perf/Makefile.perffile, just like all the other such command line toggles.
Quoted 8 lines
Quoted 6 lines
Fixes 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Jiri Olsa <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>Reviewed-by Ian Rogers <[email protected]>
Applied to perf-tools-next, thanks!