Skip to contentSkip to conversation

mm: Fixed multiple typos in multiple files

PATCH In review Muhammad Muzammil 4 participants 10 messages Oct 14, 2023 – Oct 23, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Fixed multiple typos in multiple files

debug_vm_pgtable.c: Fixed typo
internal.h: Fixed typo
memcontrol.c: Fixed typo
mmap.c: Fixed typo

---
 mm/debug_vm_pgtable.c | 4 ++--
 mm/internal.h         | 2 +-
 mm/memcontrol.c       | 4 ++--
 mm/mmap.c             | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
mm/debug_vm_pgtable.c +2 -2
index 48e329ea5ba3..e651500e597a 100644
@@ -1322,8 +1322,8 @@ static int __init debug_vm_pgtable(void)
 	 * true irrespective of the starting protection value for a
 	 * given page table entry.
 	 *
-	 * Protection based vm_flags combinatins are always linear
-	 * and increasing i.e starting from VM_NONE and going upto
+	 * Protection based vm_flags combinations are always linear
+	 * and increasing i.e starting from VM_NONE and going up to
 	 * (VM_SHARED | READ | WRITE | EXEC).
 	 */
 #define VM_FLAGS_START	(VM_NONE)
mm/internal.h +1 -1
index b52a526d239d..b61034bd50f5 100644
@@ -601,7 +601,7 @@ extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags,
  * range.
  * "fully mapped" means all the pages of folio is associated with the page
  * table of range while this function just check whether the folio range is
- * within the range [start, end). Funcation caller nees to do page table
+ * within the range [start, end). Function caller needs to do page table
  * check if it cares about the page table association.
  *
  * Typical usage (like mlock or madvise) is:
mm/memcontrol.c +2 -2
index be2ad117515e..7987a092e530 100644
@@ -842,7 +842,7 @@ void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx,
 	memcg = pn->memcg;
 
 	/*
-	 * The caller from rmap relay on disabled preemption becase they never
+	 * The caller from rmap relay on disabled preemption because they never
 	 * update their counter from in-interrupt context. For these two
 	 * counters we check that the update is never performed from an
 	 * interrupt context while other caller need to have disabled interrupt.
@@ -8104,7 +8104,7 @@ static struct cftype memsw_files[] = {
  *
  * This doesn't check for specific headroom, and it is not atomic
  * either. But with zswap, the size of the allocation is only known
- * once compression has occured, and this optimistic pre-check avoids
+ * once compression has occurred, and this optimistic pre-check avoids
  * spending cycles on compression when there is already no room left
  * or zswap is disabled altogether somewhere in the hierarchy.
  */
mm/mmap.c +1 -1
index b59f5e26b6fb..27539ffe2048 100644
@@ -1223,7 +1223,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr,
 	 * Does the application expect PROT_READ to imply PROT_EXEC?
 	 *
 	 * (the exception is when the underlying filesystem is noexec
-	 *  mounted, in which case we dont add PROT_EXEC.)
+	 *  mounted, in which case we don't add PROT_EXEC.)
 	 */
 	if ((prot & PROT_READ) && (current->personality & READ_IMPLIES_EXEC))
 		if (!(file && path_noexec(&file->f_path)))
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 6 lines · Muhammad Muzammil

debug_vm_pgtable.c: Fixed typo
internal.h: Fixed typo
memcontrol.c: Fixed typo
mmap.c: Fixed typo

These all look good to me. Thanks.

One comment below:

Quoted 40 lines
---
 mm/debug_vm_pgtable.c | 4 ++--
 mm/internal.h         | 2 +-
 mm/memcontrol.c       | 4 ++--
 mm/mmap.c             | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
mm/debug_vm_pgtable.c +2 -2
index 48e329ea5ba3..e651500e597a 100644
@@ -1322,8 +1322,8 @@ static int __init debug_vm_pgtable(void)
 	 * true irrespective of the starting protection value for a
 	 * given page table entry.
 	 *
-	 * Protection based vm_flags combinatins are always linear
-	 * and increasing i.e starting from VM_NONE and going upto
+	 * Protection based vm_flags combinations are always linear
+	 * and increasing i.e starting from VM_NONE and going up to
 	 * (VM_SHARED | READ | WRITE | EXEC).
 	 */
 #define VM_FLAGS_START	(VM_NONE)
mm/internal.h +1 -1
index b52a526d239d..b61034bd50f5 100644
@@ -601,7 +601,7 @@ extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags,
  * range.
  * "fully mapped" means all the pages of folio is associated with the page
  * table of range while this function just check whether the folio range is
- * within the range [start, end). Funcation caller nees to do page table
+ * within the range [start, end). Function caller needs to do page table
  * check if it cares about the page table association.
  *
  * Typical usage (like mlock or madvise) is:
mm/memcontrol.c +0 -0
index be2ad117515e..7987a092e530 100644

mm/memcontrol.c void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, · line 846

Quoted 6 lines
mm/memcontrol.c +1 -1
@@ -842,7 +842,7 @@ void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx,
 	memcg = pn->memcg;
 
 	/*
-	 * The caller from rmap relay on disabled preemption becase they never
+	 * The caller from rmap relay on disabled preemption because they never
 	 * update their counter from in-interrupt context. For these two

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

Quoted 24 lines
mm/memcontrol.c +1 -1
 	 * counters we check that the update is never performed from an
 	 * interrupt context while other caller need to have disabled interrupt.
@@ -8104,7 +8104,7 @@ static struct cftype memsw_files[] = {
  *
  * This doesn't check for specific headroom, and it is not atomic
  * either. But with zswap, the size of the allocation is only known
- * once compression has occured, and this optimistic pre-check avoids
+ * once compression has occurred, and this optimistic pre-check avoids
  * spending cycles on compression when there is already no room left
  * or zswap is disabled altogether somewhere in the hierarchy.
  */
mm/mmap.c +1 -1
index b59f5e26b6fb..27539ffe2048 100644
@@ -1223,7 +1223,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr,
 	 * Does the application expect PROT_READ to imply PROT_EXEC?
 	 *
 	 * (the exception is when the underlying filesystem is noexec
-	 *  mounted, in which case we dont add PROT_EXEC.)
+	 *  mounted, in which case we don't add PROT_EXEC.)
 	 */
 	if ((prot & PROT_READ) && (current->personality & READ_IMPLIES_EXEC))
 		if (!(file && path_noexec(&file->f_path)))
Signature · 1 line
~Randy
#2 lore raw
Quoted 7 lines · Randy Dunlap

mm/memcontrol.c void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, · line 846

Quoted 4 lines
mm/memcontrol.c +1 -1
 	/*
-	 * The caller from rmap relay on disabled preemption becase they never
+	 * The caller from rmap relay on disabled preemption because they never
 	 * update their counter from in-interrupt context. For these two

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

s/relay/rely/

#3 lore raw
Quoted 10 lines · Matthew Wilcox
Quoted 7 lines · Randy Dunlap

mm/memcontrol.c void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, · line 846

Quoted 4 lines
mm/memcontrol.c +1 -1
 	/*
-	 * The caller from rmap relay on disabled preemption becase they never
+	 * The caller from rmap relay on disabled preemption because they never
 	 * update their counter from in-interrupt context. For these two

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

s/relay/rely/

Duh. Thanks.

So either:

+ * The callers from rmap rely on disabled preemption because they never
or
+ * The caller from rmap relies on disabled preemption because they never

but the entire paragraph still needs some care IMO.

Signature · 1 line
~Randy
#4 lore raw
In reply to Matthew Wilcox
Quoted 9 lines · Matthew Wilcox
Quoted 8 lines · Randy Dunlap
Quoted 7 lines

        /*
-        * The caller from rmap relay on disabled preemption becase they never
+        * The caller from rmap relay on disabled preemption because they never
         * update their counter from in-interrupt context. For these two

Quoted 4 lines
Quoted 2 lines

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

s/relay/rely/

relies, surely, being the correct third person singular form of the verb to match the nominative noun "the caller".

James

#5 lore raw

should I create the v2 or this patch is fine?

Quoted 21 lines · James Bottomley
Quoted 9 lines · Matthew Wilcox
Quoted 8 lines · Randy Dunlap
Quoted 7 lines
        /*

- * The caller from rmap relay on disabled preemption
becase they never
+ * The caller from rmap relay on disabled preemption
because they never
* update their counter from in-interrupt context. For
these two

Quoted 4 lines
Quoted 2 lines

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

s/relay/rely/

relies, surely, being the correct third person singular form of the verb to match the nominative noun "the caller".

James

#6 lore raw
Quoted 1 line · Muhammad Muzammil

should I create the v2 or this patch is fine?

Personally, I don't think anyone cares about misspellings unless it obscures the meaning of the sentence, so, given the interactions in this thread, I'd argue the only one really worth fixing is relay -> relies.

James

Quoted 26 lines
Quoted 22 lines · James Bottomley
Quoted 10 lines · Matthew Wilcox
Quoted 9 lines · Randy Dunlap
Quoted 8 lines

        /*
-        * The caller from rmap relay on disabled preemption becase they never
+        * The caller from rmap relay on disabled preemption because they never
         * update their counter from in-interrupt context. For
these two

Quoted 4 lines
Quoted 2 lines

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

s/relay/rely/

relies, surely, being the correct third person singular form of the verb to match the nominative noun "the caller".

James

#7 lore raw

Can anyone approve this patch?

Quoted 39 lines · James Bottomley
Quoted 1 line · Muhammad Muzammil

should I create the v2 or this patch is fine?

Personally, I don't think anyone cares about misspellings unless it obscures the meaning of the sentence, so, given the interactions in this thread, I'd argue the only one really worth fixing is relay -> relies.

James

Quoted 26 lines
Quoted 22 lines · James Bottomley
Quoted 10 lines · Matthew Wilcox
Quoted 9 lines · Randy Dunlap
Quoted 8 lines
        /*

- * The caller from rmap relay on disabled preemption
becase they never
+ * The caller from rmap relay on disabled preemption
because they never
* update their counter from in-interrupt context.
For
these two

Quoted 4 lines
Quoted 2 lines

I don't know what that (partial) sentence is trying to say... Maybe someone else does.

s/relay/rely/

relies, surely, being the correct third person singular form of the verb to match the nominative noun "the caller".

James

#8 lore raw
Quoted 1 line · Muhammad Muzammil

Can anyone approve this patch?

Please send a v2 with the rely -> relies fix included.

#9 lore raw

I have sent the v2 patch. Thanks

Quoted 5 lines · Matthew Wilcox
Quoted 1 line · Muhammad Muzammil

Can anyone approve this patch?

Please send a v2 with the rely -> relies fix included.