perf: get_perf_callchain return NULL for crosstask
Subsystems (2)
PATCH v2 1/1 perf: get_perf_callchain return NULL for crosstask
Return NULL instead of returning 1 incorrect frame, which currently happens when trying to walk the user stack for any task that isn't current. Returning NULL is a better indicator that this behavior is not supported.
This issue was found using bpf_get_task_stack inside a BPF iterator ("iter/task"), which iterates over all tasks. The single address/frame in the buffer when getting user stacks for tasks that aren't current could not be symbolized (testing multiple symbolizers).
---
Changes in v2:
* move user and crosstask check before get_callchain_entry
kernel/events/callchain.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
kernel/events/callchain.c +3 -4
@@ -184,6 +184,9 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user,struct perf_callchain_entry_ctx ctx;int rctx; +if (user && crosstask) +return NULL ; + entry =get_callchain_entry (&rctx);if (!entry)return NULL ;
@@ -209,9 +212,6 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, }if (regs) { -if (crosstask) - goto exit_put; -if (add_mark)perf_callchain_store_context (&ctx,PERF_CONTEXT_USER );
@@ -219,7 +219,6 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, } } -exit_put:put_callchain_entry (rctx);return entry;
Signature · 1 line
2.39.3
Quoted 12 lines · Jordan Rome
Return NULL instead of returning 1 incorrect frame, which currently happens when trying to walk the user stack for any task that isn't current. Returning NULL is a better indicator that this behavior is not supported.
This issue was found using
bpf_get_task_stackinside a BPF iterator ("iter/task"), which iterates over all tasks. The single address/frame in the buffer when getting user stacks for tasks that aren't current could not be symbolized (testing multiple symbolizers).
Quoted 6 lines
Signed-off-by Jordan Rome <[email protected]>---
Changes in v2:
* move user and crosstask check beforeget_callchain_entry
LGTM.
Quoted 41 lines
kernel/events/callchain.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)kernel/events/callchain.c +3
-5@@ -184,6 +184,9 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user,struct perf_callchain_entry_ctx ctx;int rctx; +if (user && crosstask) +return NULL ; + entry =get_callchain_entry (&rctx);if (!entry)return NULL ;@@ -209,9 +212,6 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, }if (regs) { -if (crosstask) - goto exit_put; -if (add_mark)perf_callchain_store_context (&ctx,PERF_CONTEXT_USER );@@ -219,7 +219,6 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, } } -exit_put:put_callchain_entry (rctx);return entry; --2.39.3
Quoted 5 lines · Jordan Rome
Return NULL instead of returning 1 incorrect frame, which currently happens when trying to walk the user stack for any task that isn't current. Returning NULL is a better indicator that this behavior is not supported.
Quoted 7 lines
This issue was found using
bpf_get_task_stackinside a BPF iterator ("iter/task"), which iterates over all tasks. The single address/frame in the buffer when getting user stacks for tasks that aren't current could not be symbolized (testing multiple symbolizers).Signed-off-by Jordan Rome <[email protected]>
jirka
Quoted 47 lines
---
Changes in v2:
* move user and crosstask check beforeget_callchain_entrykernel/events/callchain.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)kernel/events/callchain.c +3
-4@@ -184,6 +184,9 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user,struct perf_callchain_entry_ctx ctx;int rctx; +if (user && crosstask) +return NULL ; + entry =get_callchain_entry (&rctx);if (!entry)return NULL ;@@ -209,9 +212,6 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, }if (regs) { -if (crosstask) - goto exit_put; -if (add_mark)perf_callchain_store_context (&ctx,PERF_CONTEXT_USER );@@ -219,7 +219,6 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, } } -exit_put:put_callchain_entry (rctx);return entry;Signature · 1 line
2.39.3