gpio: sim: implement the dbg_show() callback
PATCH 1/1 gpio: sim: implement the dbg_show() callback
From: Bartosz Golaszewski <[email protected]>
Provide a custom implementation of the dbg_show() callback that prints all requested lines together with their label, direction, value and bias. This improves the code coverage of GPIOLIB.
--- drivers/gpio/gpio-sim.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)
drivers/gpio/gpio-sim.c +25 -0
@@ -28,6 +28,7 @@#include <linux/notifier.h> #include <linux/platform_device.h> #include <linux/property.h> +#include <linux/seq_file.h> #include <linux/slab.h> #include <linux/string.h> #include <linux/string_helpers.h>
@@ -224,6 +225,29 @@ static void gpio_sim_free(struct gpio_chip *gc, unsigned int offset) } } +#if IS_ENABLED (CONFIG_DEBUG_FS ) +static void gpio_sim_dbg_show (struct seq_file *seq,struct gpio_chip *gc) +{ +struct gpio_sim_chip *chip =gpiochip_get_data (gc); +const char *label; +int i; + +guard (mutex)(&chip->lock); + +for_each_requested_gpio (gc, i, label) +seq_printf (seq," gpio-%-3d (%s) %s,%s\n" , + gc->base + i, + label, +test_bit (i, chip->direction_map) ?"input" : +test_bit (i, chip->value_map) ?"output-high" : +"output-low" , +test_bit (i, chip->pull_map) ?"pull-up" : +"pull-down" ); +} +#else +#define gpio_sim_dbg_show NULL +#endif /* CONFIG_DEBUG_FS */ +static ssize_t gpio_sim_sysfs_val_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -460,6 +484,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) gc->to_irq = gpio_sim_to_irq; gc->request = gpio_sim_request; gc->free = gpio_sim_free; + gc->dbg_show = gpio_sim_dbg_show; gc->can_sleep = true; ret =devm_gpiochip_add_data (dev, gc, chip);
Signature · 1 line
2.40.1
Quoted 5 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Provide a custom implementation of the
dbg_show()callback that prints all requested lines together with their label, direction, value and bias. This improves the code coverage of GPIOLIB.
...
drivers/gpio/gpio-sim.c static void gpio_sim_free(struct gpio_chip *gc, unsigned int offset) · line 249
Quoted 3 lines
drivers/gpio/gpio-sim.c +3
-0+#else +#define gpio_sim_dbg_show NULL +#endif /* CONFIG_DEBUG_FS */
I;m wondering if you can use PTR_IF() instead of this ugly ifdeffery.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
...
Quoted 5 lines
drivers/gpio/gpio-sim.c static void gpio_sim_free(struct gpio_chip *gc, unsigned int offset) · line 249
Quoted 3 lines
drivers/gpio/gpio-sim.c +3
-0+#else +#define gpio_sim_dbg_show NULL +#endif /* CONFIG_DEBUG_FS */ I;m wondering if you can use
PTR_IF()instead of this ugly ifdeffery.
If brave enough, you can even propose a new macro like
#define debugfs_ptr(ptr) ...
(see pm_sleep_ptr() / pm_ptr() as examples).
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 5 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Provide a custom implementation of the
dbg_show()callback that prints all requested lines together with their label, direction, value and bias. This improves the code coverage of GPIOLIB.
Quoted 8 lines
...
drivers/gpio/gpio-sim.c static void gpio_sim_free(struct gpio_chip *gc, unsigned int offset) · line 249
Quoted 3 lines
drivers/gpio/gpio-sim.c +3
-0+#else +#define gpio_sim_dbg_show NULL +#endif /* CONFIG_DEBUG_FS */ I;m wondering if you can use
PTR_IF()instead of this ugly ifdeffery.
I wasn't aware of this. Thanks for bringing it to my attention, I'll use it.
Bart
Quoted 5 lines
--
With Best Regards,
Andy Shevchenko