Skip to contentSkip to conversation

perf stat: Fix help message for --metric-no-threshold option

PATCH Applied Ian Rogers 2 participants 4 messages Nov 29, 2023 – Dec 12, 2023 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf stat: Fix help message for --metric-no-threshold option

Copy-paste error led to help message for metric-no-threshold repeating that of metric-no-merge.

Fixes 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -1
index a3af805a1d57..c77a3308d3fb 100644
@@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
 	OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
 		       "don't try to share events between metrics in a group"),
 	OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
-		       "don't try to share events between metrics in a group  "),
+		       "disable adding events for the metric threshold calculation"),
 	OPT_BOOLEAN(0, "topdown", &topdown_run,
 			"measure top-down statistics"),
 	OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
Signature · 1 line
2.43.0.rc1.413.gea7ed67945-goog
author reviewer
#1 lore raw
Quoted 7 lines · Ian Rogers

Copy-paste error led to help message for metric-no-threshold repeating that of metric-no-merge.

Fixes 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")

Ping. Thanks,
Ian

Quoted 20 lines
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -2
index a3af805a1d57..c77a3308d3fb 100644
@@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
        OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
                       "don't try to share events between metrics in a group"),
        OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
-                      "don't try to share events between metrics in a group  "),
+                      "disable adding events for the metric threshold calculation"),
        OPT_BOOLEAN(0, "topdown", &topdown_run,
                        "measure top-down statistics"),
        OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
--

2.43.0.rc1.413.gea7ed67945-goog

#3 lore raw
In reply to Ian Rogers

Em Mon, Dec 11, 2023 at 11:39:02AM -0800, Ian Rogers escreveu:

Quoted 11 lines · Ian Rogers
Quoted 7 lines

Copy-paste error led to help message for metric-no-threshold repeating that of metric-no-merge.

Fixes 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")

Ping. Thanks,
Ian

This is in perf-tools-next now.

- Arnaldo

Quoted 20 lines
Quoted 20 lines
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -2
index a3af805a1d57..c77a3308d3fb 100644
@@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
        OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
                       "don't try to share events between metrics in a group"),
        OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
-                      "don't try to share events between metrics in a group  "),
+                      "disable adding events for the metric threshold calculation"),
        OPT_BOOLEAN(0, "topdown", &topdown_run,
                        "measure top-down statistics"),
        OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
--

2.43.0.rc1.413.gea7ed67945-goog

Signature · 1 line
- Arnaldo