Skip to contentSkip to conversation

scsi: core: add CMD_LAST flag for error handle scsi command

PATCH In review Ye Bin 2 participants 2 messages Dec 14, 2023 – Dec 15, 2023 SCSI

lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 scsi: core: add CMD_LAST flag for error handle scsi command

SCSI error handle will send scsi command bypass block layer. After commit 8930a6c20791 scsi support request batching. Some LLD only writing the hardware doorbell when necessary, after the last request was prepared.
For scsi error handle, each command waits synchronously. So each scsi command is both the beginning and the end. So add CMD_LAST flag for error handle scsi command.

Fixes 8930a6c20791 ("scsi: core: add support for request batching")
---
 drivers/scsi/scsi_error.c | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/scsi_error.c +1 -0
index 1bac12ef238e..9e79047a1250 100644
@@ -1147,6 +1147,7 @@ static enum scsi_disposition scsi_send_eh_cmnd(struct scsi_cmnd *scmd,
 	const unsigned long stall_for = msecs_to_jiffies(100);
 	int rtn;
 
+	scmd->flags |= SCMD_LAST;
 retry:
 	scsi_eh_prep_cmnd(scmd, &ses, cmnd, cmnd_size, sense_bytes);
 	shost->eh_action = &done;
Signature · 1 line
2.31.1