Skip to contentSkip to conversation

bcachefs: Use array_size() in call to copy_from_user()

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Dec 19, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Use array_size() in call to copy_from_user()

Use array_size() helper, instead of the open-coded version in call to copy_from_user().

---
 fs/bcachefs/chardev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/bcachefs/chardev.c +2 -1
index 304ea619a888..22a52bc8406b 100644
@@ -360,7 +360,8 @@ static long bch2_ioctl_fsck_offline(struct bch_ioctl_fsck_offline __user *user_a
 	init_waitqueue_head(&thr->output.wait);
 	darray_init(&thr->output2);
 
-	if (copy_from_user(devs, &user_arg->devs[0], sizeof(user_arg->devs[0]) * arg.nr_devs)) {
+	if (copy_from_user(devs, &user_arg->devs[0],
+			   array_size(sizeof(user_arg->devs[0]), arg.nr_devs))) {
 		ret = -EINVAL;
 		goto err;
 	}
Signature · 1 line
2.34.1