mm/khugepaged: Remove redundant try_to_freeze()
Subsystems (2)
PATCH v2 1/1 mm/khugepaged: Remove redundant try_to_freeze()
A freezable kernel thread can enter frozen state during freezing by either calling try_to_freeze() or using wait_event_freezable() and its variants. However, there is no need to use both methods simultaneously. The freezable wait variants have been used in khugepaged_wait_work() and khugepaged_alloc_sleep(), so remove this redundant try_to_freeze().
---
v2: Adjust the patch subject to make it look more unique.
mm/khugepaged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/khugepaged.c +1 -1
@@ -2500,7 +2500,7 @@ static void khugepaged_do_scan(struct collapse_control *cc)while (true) {cond_resched (); -if (unlikely (kthread_should_stop () ||try_to_freeze ())) +if (unlikely (kthread_should_stop ()))break ;spin_lock (&khugepaged_mm_lock);
Signature · 1 line
2.39.2
Andrew Morton
maintainerQuoted 12 lines · On Wed, 20 Dec 2023 07:17:53 +0800 Kevin Hao <[email protected]> wrote:
A freezable kernel thread can enter frozen state during freezing by either calling
try_to_freeze()or usingwait_event_freezable()and its variants. However, there is no need to use both methods simultaneously. The freezable wait variants have been used inkhugepaged_wait_work()andkhugepaged_alloc_sleep(), so remove this redundanttry_to_freeze()....
mm/khugepaged.c static void khugepaged_do_scan(struct collapse_control *cc) · line 2506
Quoted 8 lines
mm/khugepaged.c +1
-1@@ -2500,7 +2500,7 @@ static void khugepaged_do_scan(struct collapse_control *cc)while (true) {cond_resched (); -if (unlikely (kthread_should_stop () ||try_to_freeze ())) +if (unlikely (kthread_should_stop ()))break ;spin_lock (&khugepaged_mm_lock);
What are the effects upon worst-case freezing latency?
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Wed, 20 Dec 2023 07:17:53 +0800 Kevin Hao <[email protected]> wrote:
A freezable kernel thread can enter frozen state during freezing by either calling
try_to_freeze()or usingwait_event_freezable()and its variants. However, there is no need to use both methods simultaneously. The freezable wait variants have been used inkhugepaged_wait_work()andkhugepaged_alloc_sleep(), so remove this redundanttry_to_freeze()....
mm/khugepaged.c +0
-0@@ -2500,7 +2500,7 @@ static void khugepaged_do_scan(struct collapse_control *cc)while (true) {cond_resched ();
Quoted 7 lines
mm/khugepaged.c static void khugepaged_do_scan(struct collapse_control *cc) · line 2506
Quoted 5 lines
mm/khugepaged.c +1
-1-if (unlikely (kthread_should_stop () ||try_to_freeze ())) +if (unlikely (kthread_should_stop ()))break ;spin_lock (&khugepaged_mm_lock);What are the effects upon worst-case freezing latency?
I used the following stress-ng command to generate some memory load on my Intel Alder Lake board (24 CPUs, 32G memory).
stress-ng --vm 48 --vm-bytes 90%
The worst freezing latency is:
Freezing user space processes
Freezing user space processes completed (elapsed 0.040 seconds) OOM killer disabled.
Freezing remaining freezable tasks
Freezing remaining freezable tasks completed (elapsed 0.001 seconds)
Without the faked memory load, the freezing latency is:
Freezing user space processes
Freezing user space processes completed (elapsed 0.000 seconds) OOM killer disabled.
Freezing remaining freezable tasks
Freezing remaining freezable tasks completed (elapsed 0.001 seconds)
I didn't see any observable difference whether this patch is applied or not.
Thanks,
Kevin