cpufreq/amd-pstate: Adding Zen4 support in introduction
Subsystems (2)
PATCH 2/2 cpufreq/amd-pstate: Adding Zen4 support in introduction
amd-pstate is implemented on Zen4, adding this architecture in the introduction.
--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/amd-pstate.c +1 -1
@@ -14,7 +14,7 @@* communicate the performance hints to hardware. * * AMD P-State is supported on recent AMD Zen base CPU series include some of -* Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD +* Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD * P-State supported system. And there are two types of hardware implementations * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution. * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types.
Signature · 1 line
2.43.0
Rafael J. Wysocki
maintainerQuoted 14 lines · Erwan Velu
amd-pstate is implemented on Zen4, adding this architecture in the introduction.
Signed-off-by Erwan Velu <[email protected]>--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/amd-pstate.c +0
-0
drivers/cpufreq/amd-pstate.c line 17
Quoted 5 lines
drivers/cpufreq/amd-pstate.c +1
-1@@ -14,7 +14,7 @@* communicate the performance hints to hardware. * * AMD P-State is supported on recent AMD Zen base CPU series include some of -* Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD +* Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD
IMO, it would be really nice to avoid extending this line so much, but this is up to the AMD people.
Also, while you are at it, "include" in the first sentence should be "including" and a new paragraph after "processors." would make this comment easier to follow from the logical standpoint, because the first sentence is about the supported platforms and the second one is about additional requirements (ie. something else).
Quoted 4 lines
drivers/cpufreq/amd-pstate.c +0
-1* P-State supported system. And there are two types of hardware implementations * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution. * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types. --
So it's probably better to let AMD people fixing this part. Thx for the feedback.
Quoted 35 lines · Rafael J. Wysocki
Quoted 14 lines · Erwan Velu
amd-pstate is implemented on Zen4, adding this architecture in the introduction.
Signed-off-by Erwan Velu <[email protected]>--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/amd-pstate.c +0
-0drivers/cpufreq/amd-pstate.c line 17
Quoted 5 lines
drivers/cpufreq/amd-pstate.c +1
-1@@ -14,7 +14,7 @@* communicate the performance hints to hardware. * * AMD P-State is supported on recent AMD Zen base CPU series include some of -* Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD +* Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD IMO, it would be really nice to avoid extending this line so much, but this is up to the AMD people.
Also, while you are at it, "include" in the first sentence should be "including" and a new paragraph after "processors." would make this comment easier to follow from the logical standpoint, because the first sentence is about the supported platforms and the second one is about additional requirements (ie. something else).
Quoted 4 lines
drivers/cpufreq/amd-pstate.c +0
-1* P-State supported system. And there are two types of hardware implementations * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution. * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types. --
Huang Rui
maintainerQuoted 10 lines · Rafael J. Wysocki
Quoted 9 lines · Erwan Velu
amd-pstate is implemented on Zen4, adding this architecture in the introduction.
Signed-off-by Erwan Velu <[email protected]>--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
drivers/cpufreq/amd-pstate.c line 17
Quoted 10 lines
drivers/cpufreq/amd-pstate.c +1
-1@@ -14,7 +14,7 @@* communicate the performance hints to hardware. * * AMD P-State is supported on recent AMD Zen base CPU series include some of -* Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD +* Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD IMO, it would be really nice to avoid extending this line so much, but this is up to the AMD people.
Agree. Actually, we will use this driver for all future AMD CPU generations that starts from paritial Zen2.
Quoted 7 lines
Also, while you are at it, "include" in the first sentence should be "including" and a new paragraph after "processors." would make this comment easier to follow from the logical standpoint, because the first sentence is about the supported platforms and the second one is about additional requirements (ie. something else).
How about modifying here as "partial Zen2, Zen3, and future processors"?
Thanks,
Ray
Quoted 4 lines
Quoted 4 lines
drivers/cpufreq/amd-pstate.c +0
-1* P-State supported system. And there are two types of hardware implementations * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution. * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types. --
Quoted 1 line
How about modifying here as "partial Zen2, Zen3, and future processors"?
And all processors starting Zen4 ?
Quoted 46 lines · Huang Rui
Quoted 10 lines · Rafael J. Wysocki
Quoted 9 lines · Erwan Velu
amd-pstate is implemented on Zen4, adding this architecture in the introduction.
Signed-off-by Erwan Velu <[email protected]>--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 13 lines
drivers/cpufreq/amd-pstate.c line 17
Quoted 10 lines
drivers/cpufreq/amd-pstate.c +1
-1@@ -14,7 +14,7 @@* communicate the performance hints to hardware. * * AMD P-State is supported on recent AMD Zen base CPU series include some of -* Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD +* Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD IMO, it would be really nice to avoid extending this line so much, but this is up to the AMD people.
Agree. Actually, we will use this driver for all future AMD CPU generations that starts from paritial Zen2.
Quoted 7 lines
Also, while you are at it, "include" in the first sentence should be "including" and a new paragraph after "processors." would make this comment easier to follow from the logical standpoint, because the first sentence is about the supported platforms and the second one is about additional requirements (ie. something else).
How about modifying here as "partial Zen2, Zen3, and future processors"?
Thanks,
RayQuoted 4 lines
Quoted 4 lines
drivers/cpufreq/amd-pstate.c +0
-1* P-State supported system. And there are two types of hardware implementations * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution. * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types. --
Huang Rui
maintainerQuoted 2 lines · Erwan Velu
Quoted 1 line
How about modifying here as "partial Zen2, Zen3, and future processors"?
And all processors starting Zen4 ?
"partial Zen2 and all processors starting Zen3"
Thanks,
Ray
Quoted 48 lines · Huang Rui
Quoted 46 lines · Rafael J. Wysocki
Quoted 10 lines · Erwan Velu
Quoted 9 lines
amd-pstate is implemented on Zen4, adding this architecture in the introduction.
Signed-off-by Erwan Velu <[email protected]>--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 13 lines
drivers/cpufreq/amd-pstate.c line 17
Quoted 10 lines
drivers/cpufreq/amd-pstate.c +1
-1@@ -14,7 +14,7 @@* communicate the performance hints to hardware. * * AMD P-State is supported on recent AMD Zen base CPU series include some of -* Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables of AMD +* Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI tables of AMD IMO, it would be really nice to avoid extending this line so much, but this is up to the AMD people.
Agree. Actually, we will use this driver for all future AMD CPU generations that starts from paritial Zen2.
Quoted 7 lines
Also, while you are at it, "include" in the first sentence should be "including" and a new paragraph after "processors." would make this comment easier to follow from the logical standpoint, because the first sentence is about the supported platforms and the second one is about additional requirements (ie. something else).
How about modifying here as "partial Zen2, Zen3, and future processors"?
Thanks,
RayQuoted 4 lines
Quoted 4 lines
drivers/cpufreq/amd-pstate.c +0
-1* P-State supported system. And there are two types of hardware implementations * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution. * X86_FEATURE_CPPC CPU feature flag is used to distinguish the different types. --