Skip to contentSkip to conversation

x86/cpu: Add CPU model number for Bartlett Lake CPUs with Raptor Cove cores

tip: x86/urgent In review Christian Ludloff 3 participants 5 messages Apr 14, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw
Quoted 1 line

+#define INTEL_RAPTORCOVE IFM(6, 0xD7) /* Bartlett Lake */

Please fix this. It has the core and the product reversed. That is, it should be INTEL_BARTLETTLAKE and /* Raptor Cove */ to match the bulk of that file.

And yes, you also want to fix this for INTEL_PANTHERCOVE_X and /* Diamond Rapids */ entry.

The macros refer to products.
The comments refer to cores.

Consistency, please.
Sanity, please.

--
Christian

#1 lore raw

PATCH 1/1 x86/cpu: Add CPU model number for Bartlett Lake CPUs with Raptor Cove cores

Quoted 5 lines · Christian Ludloff
Quoted 1 line

+#define INTEL_RAPTORCOVE IFM(6, 0xD7) /* Bartlett Lake */

Please fix this. It has the core and the product reversed. That is, it should be INTEL_BARTLETTLAKE and /* Raptor Cove */ to match the bulk of that file.

I switched it around for this commit - see the updated patch below.

Quoted 5 lines

And yes, you also want to fix this for INTEL_PANTHERCOVE_X and /* Diamond Rapids */ entry.

The macros refer to products.
The comments refer to cores.

Please send a patch if you have the time.

Quoted 2 lines

Consistency, please.
Sanity, please.

Amen!

Thanks,

Ingo

==================>
From: Pi Xiange <[email protected]>
Date: Mon, 14 Apr 2025 11:28:39 +0800
Subject: [PATCH] x86/cpu: Add CPU model number for Bartlett Lake CPUs with Raptor Cove cores

Bartlett Lake has a P-core only product with Raptor Cove.

[ mingo: Switch around the define as pointed out by Christian Ludloff:
Ratpr Cove is the core, Bartlett Lake is the product.

Cc Christian Ludloff <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Tony Luck <[email protected]>
Cc Andrew Cooper <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc John Ogness <[email protected]>
Cc "Ahmed S. Darwish" <[email protected]>
---
 arch/x86/include/asm/intel-family.h | 2 ++
 1 file changed, 2 insertions(+)
arch/x86/include/asm/intel-family.h +2 -0
index 3a97a7eefb51..be10c188614f 100644
@@ -126,6 +126,8 @@
 #define INTEL_GRANITERAPIDS_X		IFM(6, 0xAD) /* Redwood Cove */
 #define INTEL_GRANITERAPIDS_D		IFM(6, 0xAE)
 
+#define INTEL_BARTLETTLAKE		IFM(6, 0xD7) /* Raptor Cove */
+
 /* "Hybrid" Processors (P-Core/E-Core) */
 
 #define INTEL_LAKEFIELD			IFM(6, 0x8A) /* Sunny Cove / Tremont */
maintainer
#2 lore raw
Quoted 12 lines
Quoted 3 lines

Please fix this. It has the core and the product reversed. That is, it should be INTEL_BARTLETTLAKE and /* Raptor Cove */ to match the bulk of that file.

I switched it around for this commit - see the updated patch below.

Quoted 5 lines

And yes, you also want to fix this for INTEL_PANTHERCOVE_X and /* Diamond Rapids */ entry.

The macros refer to products.
The comments refer to cores.

Quoted 6 lines

Please send a patch if you have the time.

Quoted 2 lines

Consistency, please.
Sanity, please.

Amen!

PeterZ has been very vocal that he wants the "sane" way to be making the "#define" name be based on the core rather than the product. That way multiple products using the same core show up together in switch statements for model specific features like power and performance counters.

This does mean we have a transition between legacy names that were using the SoC product codename and modern ones that use the core codename.

Can the X86 maintainers please get in a huddle and define a naming policy. This discussion keeps happening.

-Tony

#3 lore raw
Quoted 13 lines · Tony
Quoted 7 lines
Quoted 5 lines

The macros refer to products.
The comments refer to cores.

Consistency, please.
Sanity, please.

Amen!

PeterZ has been very vocal that he wants the "sane" way to be making the "#define" name be based on the core rather than the product. That way multiple products using the same core show up together in switch statements for model specific features like power and performance counters.

Quoted 5 lines

This does mean we have a transition between legacy names that were using the SoC product codename and modern ones that use the core codename.

Can the X86 maintainers please get in a huddle and define a naming policy. This discussion keeps happening.

Consider a two-level abstraction.

One which gets "looked up" from FMS – fundamentally that is what the existing file is trying to achieve, right?

Another which gets "looked up" from core (e.g. RPC) or product (e.g. RPL,BTL) or whatever-else-is-used-often.

--
Christian

#4 lore raw
In reply to Ingo Molnar
Quoted 8 lines · Ingo Molnar
Quoted 5 lines · Christian Ludloff
Quoted 1 line

+#define INTEL_RAPTORCOVE IFM(6, 0xD7) /* Bartlett Lake */

Please fix this. It has the core and the product reversed. That is, it should be INTEL_BARTLETTLAKE and /* Raptor Cove */ to match the bulk of that file.

I switched it around for this commit - see the updated patch below.

Thanks.

Quoted 4 lines
Quoted 2 lines

And yes, you also want to fix this for INTEL_PANTHERCOVE_X and /* Diamond Rapids */ entry.

Please send a patch if you have the time.

Peter had proposed...

https://lore.kernel.org/lkml/[email protected]/

--
Christian