Skip to contentSkip to conversation

usb: typec: class: Unlocked on error in typec_register_partner()

PATCH In review Dan Carpenter 3 participants 3 messages Apr 15, 2025 – Apr 22, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: typec: class: Unlocked on error in typec_register_partner()

We recently added some locking to this function but this error path was accidentally missed. Unlock before returning.

Fixes ec27386de23a ("usb: typec: class: Fix NULL pointer access")
---
 drivers/usb/typec/class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/class.c +1 -0
index 3df3e3736916..67a533e35150 100644
@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
 	ret = device_register(&partner->dev);
 	if (ret) {
 		dev_err(&port->dev, "failed to register partner (%d)\n", ret);
+		mutex_unlock(&port->partner_link_lock);
 		put_device(&partner->dev);
 		return ERR_PTR(ret);
 	}
Signature · 1 line
2.47.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

We recently added some locking to this function but this error path was accidentally missed. Unlock before returning.

Fixes ec27386de23a ("usb: typec: class: Fix NULL pointer access")
Quoted 19 lines
---
 drivers/usb/typec/class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/class.c +1 -0
index 3df3e3736916..67a533e35150 100644
@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
 	ret = device_register(&partner->dev);
 	if (ret) {
 		dev_err(&port->dev, "failed to register partner (%d)\n", ret);
+		mutex_unlock(&port->partner_link_lock);
 		put_device(&partner->dev);
 		return ERR_PTR(ret);
 	}
Signature · 1 line
2.47.2
Signature · 1 line
heikki
Reviewed-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 5 lines · Dan Carpenter

We recently added some locking to this function but this error path was accidentally missed. Unlock before returning.

Fixes ec27386de23a ("usb: typec: class: Fix NULL pointer access")
Quoted 19 lines
---
 drivers/usb/typec/class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/class.c +1 -1
index 3df3e3736916..67a533e35150 100644
@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
        ret = device_register(&partner->dev);
        if (ret) {
                dev_err(&port->dev, "failed to register partner (%d)\n", ret);
+               mutex_unlock(&port->partner_link_lock);
                put_device(&partner->dev);
                return ERR_PTR(ret);
        }
--

2.47.2