usb: typec: class: Unlocked on error in typec_register_partner()
Subsystems (3)
PATCH 1/1 usb: typec: class: Unlocked on error in typec_register_partner()
We recently added some locking to this function but this error path was accidentally missed. Unlock before returning.
Fixes ec27386de23a ("usb: typec: class: Fix NULL pointer access")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/usb/typec/class.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/typec/class.c +1 -0
@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port, ret =device_register (&partner->dev);if (ret) {dev_err (&port->dev,"failed to register partner (%d)\n" , ret); +mutex_unlock (&port->partner_link_lock);put_device (&partner->dev);return ERR_PTR (ret); }
Signature · 1 line
2.47.2
Quoted 5 lines · Dan Carpenter
We recently added some locking to this function but this error path was accidentally missed. Unlock before returning.
Fixes ec27386de23a ("usb: typec: class: Fix NULL pointer access")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Heikki Krogerus <[email protected]>
Quoted 19 lines
--- drivers/usb/typec/class.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/class.c +1
-0@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port, ret =device_register (&partner->dev);if (ret) {dev_err (&port->dev,"failed to register partner (%d)\n" , ret); +mutex_unlock (&port->partner_link_lock);put_device (&partner->dev);return ERR_PTR (ret); }Signature · 1 line
2.47.2
Signature · 1 line
heikki
Quoted 5 lines · Dan Carpenter
We recently added some locking to this function but this error path was accidentally missed. Unlock before returning.
Fixes ec27386de23a ("usb: typec: class: Fix NULL pointer access")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Andrei Kuchynski <[email protected]>
Quoted 19 lines
--- drivers/usb/typec/class.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/class.c +1
-1@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port, ret =device_register (&partner->dev);if (ret) {dev_err (&port->dev,"failed to register partner (%d)\n" , ret); +mutex_unlock (&port->partner_link_lock);put_device (&partner->dev);return ERR_PTR (ret); } --2.47.2