linux-next: build failure after merge of the ath-next tree
Subsystems (3)
Hi all,
After merging the ath-next tree, today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/net/wireless/ath/ath12k/ahb.c: In function 'ath12k_ahb_stop':drivers/net/wireless/ath/ath12k/ahb.c:337:9: error: implicit declaration of function 'del_timer_sync'; did you mean 'dev_mc_sync'? [-Wimplicit-function-declaration]
337 | del_timer_sync(&ab->rx_replenish_retry);
| ^~~~~~~~~~~~~~
| dev_mc_syncCaused by commit
6cee30f0da75 ("wifi: ath12k: add AHB driver support for IPQ5332")
I have used the ath-next tree from next-20250407 for today.
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 11 lines · * Stephen Rothwell ([email protected]) wrote:
Hi all,
After merging the ath-next tree, today's linux-next build (
x86_64allmodconfig) failed like this:
drivers/net/wireless/ath/ath12k/ahb.c: In function 'ath12k_ahb_stop':drivers/net/wireless/ath/ath12k/ahb.c:337:9: error: implicit declaration of function 'del_timer_sync'; did you mean 'dev_mc_sync'? [-Wimplicit-function-declaration]337 | del_timer_sync(&ab->rx_replenish_retry); | ^~~~~~~~~~~~~~ | dev_mc_sync
Quoted 5 lines
Caused by commit
6cee30f0da75("wifi: ath12k: add AHB driver support for IPQ5332")I have used the ath-next tree from next-20250407 for today.
I guess a clash with the recent:
Dave
Quoted 4 lines
Signature · 3 lines
-- Cheers, Stephen Rothwell
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Hi Dave,
Quoted 12 lines · On Tue, 8 Apr 2025 01:06:28 +0000 "Dr. David Alan Gilbert" <[email protected]>…
Quoted 10 lines · * Stephen Rothwell ([email protected]) wrote:
After merging the ath-next tree, today's linux-next build (
x86_64allmodconfig) failed like this:
drivers/net/wireless/ath/ath12k/ahb.c: In function 'ath12k_ahb_stop':drivers/net/wireless/ath/ath12k/ahb.c:337:9: error: implicit declaration of function 'del_timer_sync'; did you mean 'dev_mc_sync'? [-Wimplicit-function-declaration]337 | del_timer_sync(&ab->rx_replenish_retry); | ^~~~~~~~~~~~~~ | dev_mc_sync
Quoted 8 lines
Quoted 5 lines
Caused by commit
6cee30f0da75("wifi: ath12k: add AHB driver support for IPQ5332")I have used the ath-next tree from next-20250407 for today.
I guess a clash with the recent:
Fixes 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
I will try that out tomorrow.
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 17 lines · Stephen Rothwell
Hi Dave,
Quoted 14 lines · On Tue, 8 Apr 2025 01:06:28 +0000 "Dr. David Alan Gilbert" <[email protected]>…
Quoted 12 lines · * Stephen Rothwell ([email protected]) wrote:
After merging the ath-next tree, today's linux-next build (
x86_64allmodconfig) failed like this:
drivers/net/wireless/ath/ath12k/ahb.c: In function 'ath12k_ahb_stop':drivers/net/wireless/ath/ath12k/ahb.c:337:9: error: implicit declaration of function 'del_timer_sync'; did you mean 'dev_mc_sync'? [-Wimplicit-function-declaration]337 | del_timer_sync(&ab->rx_replenish_retry); | ^~~~~~~~~~~~~~ | dev_mc_syncCaused by commit
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
6cee30f0da75("wifi: ath12k: add AHB driver support for IPQ5332")I have used the ath-next tree from next-20250407 for today.
I guess a clash with the recent:
Fixes 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")I will try that out tomorrow.
Yes, looks like you'll need to carry a patch:
s/del_timer_sync/timer_delete_sync/
Until that renaming patch makes it down to my tree and we rename.
Quoted 25 lines · Jeff Johnson
Quoted 24 lines · Stephen Rothwell
Hi Dave,
Quoted 20 lines · On Tue, 8 Apr 2025 01:06:28 +0000 "Dr. David Alan Gilbert" <[email protected]>…
Quoted 10 lines · * Stephen Rothwell ([email protected]) wrote:
After merging the ath-next tree, today's linux-next build (
x86_64allmodconfig) failed like this:
drivers/net/wireless/ath/ath12k/ahb.c: In function 'ath12k_ahb_stop':drivers/net/wireless/ath/ath12k/ahb.c:337:9: error: implicit declaration of function 'del_timer_sync'; did you mean 'dev_mc_sync'? [-Wimplicit-function-declaration]337 | del_timer_sync(&ab->rx_replenish_retry); | ^~~~~~~~~~~~~~ | dev_mc_syncQuoted 5 lines
Caused by commit
6cee30f0da75("wifi: ath12k: add AHB driver support for IPQ5332")I have used the ath-next tree from next-20250407 for today.
I guess a clash with the recent:
Fixes 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
Quoted 6 lines
Quoted 1 line
I will try that out tomorrow.
Yes, looks like you'll need to carry a patch:
s/del_timer_sync/timer_delete_sync/Until that renaming patch makes it down to my tree and we rename.
NM. Since the timer_delete_sync() API is already in my tree I can make a one-off patch for this.
/jeff
Quoted 2 lines · Jeff Johnson
NM. Since the
timer_delete_sync()API is already in my tree I can make a one-off patch for this.
please review https://msgid.link/[email protected]
I'll wait a bit for any tags to accumulate before I merge into ath-next
/jeff
Hi Jeff,
Quoted 8 lines · On Tue, 8 Apr 2025 09:17:21 -0700 Jeff Johnson <[email protected]>…
Quoted 2 lines · Jeff Johnson
NM. Since the
timer_delete_sync()API is already in my tree I can make a one-off patch for this.please review https://msgid.link/[email protected]
I'll wait a bit for any tags to accumulate before I merge into ath-next
I'll use your patch in the ath-next tree merge today (if necessary).
Signature · 2 lines
Cheers, Stephen Rothwell