Skip to contentSkip to conversation

RB1 fixes

PATCH Superseded Sumit Garg 2 participants 13 messages Apr 7, 2025 – Apr 10, 2025 Arm (32-bit)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Sumit Garg

author
#0 lore raw

cover RB1 fixes

From: Sumit Garg <[email protected]>

The eMMC on RB1 boards supports HS200 mode but currently the msm_shdci driver in U-Boot is missing DLL configuration required for HS200 mode to work. Hence disable HS200 for now until proper support is in place.

Apart from that, add DT override for USB to work in host mode as otg mode isn't supported. Along with that disable sdhci_2 which doesn't work as of now.

There is another patch related to clk_stub posted here [1] which allows the MMC clocks to be probed properly.

[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Sumit Garg (2):
arm: dts: Add override for RB1
qcom_defconfig: Disable MMC HS200 mode support

 arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
 configs/qcom_defconfig               |  1 -
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 1/2 arm: dts: Add override for RB1

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
 arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +11 -0
new file mode 100644
index 00000000000..1e136ee405a
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */
+&sdhc_2 {
+	status = "disabled";
+};
Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH 1/2] arm: dts: Add override for RB1

Quoted 18 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
  arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
  1 file changed, 11 insertions(+)

create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +0 -0
new file mode 100644
index 00000000000..1e136ee405a

arch/arm/dts/qrb2210-rb1-u-boot.dtsi line 8

Quoted 8 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +8 -0
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */

I'd rather avoid disabling this here, I guess it's just missing clocks and regulators which doesn't justify modifying DT. An error that mmc1 couldn't be enabled seems fine to me?> +&sdhc_2 {

Quoted 2 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +2 -0
+	status = "disabled";
+};
Signature · 1 line
Caleb (they/them)
author
#3 lore raw

Re: [PATCH 1/2] arm: dts: Add override for RB1

Quoted 25 lines · Caleb Connolly
Quoted 22 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
  arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
  1 file changed, 11 insertions(+)

create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
new file mode 100644
index 00000000000..1e136ee405a
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
Quoted 8 lines

arch/arm/dts/qrb2210-rb1-u-boot.dtsi line 8

Quoted 4 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */

I'd rather avoid disabling this here, I guess it's just missing clocks and regulators which doesn't justify modifying DT. An error that mmc1 couldn't be enabled seems fine to me?

I totally echo with your thinking that we should avoid modifying DT but at the same point we shouldn't enable peripherals in U-Boot which throws errors. It's also possible that U-Boot misconfiguring mmc1 which might turn as a problem for later stages.

I have been totally working with a remote lab to fix issues on RB1. I will soon get one on my desk then I will be able to fix mmc1 too.

-Sumit

Quoted 6 lines
Quoted 3 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +3 -0
+&sdhc_2 {
+	status = "disabled";
+};
Signature · 1 line
Caleb (they/them)
#4 lore raw

Re: [PATCH 1/2] arm: dts: Add override for RB1

Quoted 35 lines · Sumit Garg
Quoted 25 lines · Caleb Connolly
Quoted 22 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
   arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
   1 file changed, 11 insertions(+)

create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
new file mode 100644
index 00000000000..1e136ee405a
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
Quoted 8 lines

arch/arm/dts/qrb2210-rb1-u-boot.dtsi line 8

Quoted 4 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */

I'd rather avoid disabling this here, I guess it's just missing clocks and regulators which doesn't justify modifying DT. An error that mmc1 couldn't be enabled seems fine to me?

Quoted 3 lines

I totally echo with your thinking that we should avoid modifying DT but at the same point we shouldn't enable peripherals in U-Boot which throws errors. It's also possible that U-Boot misconfiguring mmc1 which might

I disagree, DT isn't enabling or disabling peripherals, it's describing hardware. U-Boot lacking proper support for that hardware isn't a good justification to disable it. Especially since you might boot Linux with the same DT and now have no working sdcard for seemingly no reason.

An error in U-Boot is exactly the behaviour we want to see, masking it only created confusion.> turn as a problem for later stages.

Quoted 3 lines

I have been totally working with a remote lab to fix issues on RB1. I will soon get one on my desk then I will be able to fix mmc1 too.

In that case we can surely land the proper fixes for 2025.07 anyway, so I'd just keep the errors until then.

Kind regards,>

Quoted 8 lines

-Sumit

Quoted 6 lines
Quoted 3 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +3 -0
+&sdhc_2 {
+	status = "disabled";
+};
Signature · 1 line
Caleb (they/them)
Signature · 1 line
Caleb (they/them)
author
#5 lore raw

Re: [PATCH 1/2] arm: dts: Add override for RB1

Quoted 38 lines · Caleb Connolly
Quoted 35 lines · Sumit Garg
Quoted 33 lines · Caleb Connolly
Quoted 18 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
   arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
   1 file changed, 11 insertions(+)

create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +0 -0
new file mode 100644
index 00000000000..1e136ee405a

arch/arm/dts/qrb2210-rb1-u-boot.dtsi line 8

Quoted 8 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +8 -0
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */

I'd rather avoid disabling this here, I guess it's just missing clocks and regulators which doesn't justify modifying DT. An error that mmc1 couldn't be enabled seems fine to me?

Quoted 6 lines
Quoted 3 lines

I totally echo with your thinking that we should avoid modifying DT but at the same point we shouldn't enable peripherals in U-Boot which throws errors. It's also possible that U-Boot misconfiguring mmc1 which might

I disagree, DT isn't enabling or disabling peripherals, it's describing hardware.

It would be helpful if you can describe the use-case for "status" property then.

Quoted 3 lines

U-Boot lacking proper support for that hardware isn't a good justification to disable it. Especially since you might boot Linux with the same DT and now have no working sdcard for seemingly no reason.

We shouldn't use same DT unless both U-Boot and Linux support that without modifications and *not* being in a broken state. The similar argument holds true for USB OTG mode too.

Quoted 3 lines

An error in U-Boot is exactly the behaviour we want to see, masking it only created confusion.> turn as a problem for later stages.

IMO, our first priority should be to fix U-Boot issues and then see if we can use unmodified DT.

Quoted 6 lines
Quoted 3 lines

I have been totally working with a remote lab to fix issues on RB1. I will soon get one on my desk then I will be able to fix mmc1 too.

In that case we can surely land the proper fixes for 2025.07 anyway, so I'd just keep the errors until then.

Fixing errors in mainline will help other people confidence who are trying to boot U-Boot on RB1. If you still have a strong preference to keep SD card support enabled in broken state then I can live with that until I fix it for real.

-Sumit

#6 lore raw

Re: [PATCH 1/2] arm: dts: Add override for RB1

Quoted 43 lines · Sumit Garg
Quoted 42 lines · Caleb Connolly
Quoted 38 lines · Sumit Garg
Quoted 25 lines · Caleb Connolly
Quoted 22 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
    arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
    1 file changed, 11 insertions(+)
    create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
new file mode 100644
index 00000000000..1e136ee405a
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
Quoted 8 lines

arch/arm/dts/qrb2210-rb1-u-boot.dtsi line 8

Quoted 4 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */

I'd rather avoid disabling this here, I guess it's just missing clocks and regulators which doesn't justify modifying DT. An error that mmc1 couldn't be enabled seems fine to me?

I totally echo with your thinking that we should avoid modifying DT but at the same point we shouldn't enable peripherals in U-Boot which throws errors. It's also possible that U-Boot misconfiguring mmc1 which might

Quoted 5 lines
Quoted 2 lines

I disagree, DT isn't enabling or disabling peripherals, it's describing hardware.

It would be helpful if you can describe the use-case for "status" property then.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#status

These all describe the functionality of hardware, since implementation details of the software (U-Boot) which is parsing the DT has absolutely nothing to do with it.>

Quoted 7 lines
Quoted 3 lines

U-Boot lacking proper support for that hardware isn't a good justification to disable it. Especially since you might boot Linux with the same DT and now have no working sdcard for seemingly no reason.

We shouldn't use same DT unless both U-Boot and Linux support that without modifications and *not* being in a broken state. The similar argument holds true for USB OTG mode too.

Well, the main difference with the OTG fixup is that we undo it later on, so if we boot an OS with this DT it won't have the override -- our hacks aren't exposed.

Quoted 12 lines
Quoted 4 lines

An error in U-Boot is exactly the behaviour we want to see, masking it only created confusion.> turn as a problem for later stages.

IMO, our first priority should be to fix U-Boot issues and then see if we can use unmodified DT.

Quoted 4 lines
Quoted 3 lines

I have been totally working with a remote lab to fix issues on RB1. I will soon get one on my desk then I will be able to fix mmc1 too.

Quoted 7 lines
Quoted 2 lines

In that case we can surely land the proper fixes for 2025.07 anyway, so I'd just keep the errors until then.

Fixing errors in mainline will help other people confidence who are trying to boot U-Boot on RB1. If you still have a strong preference to keep SD card support enabled in broken state then I can live with that until I fix it for real.

I decided to just have a crack at it and managed to get everything cleaned up. sdcard seems to work on my RB1 with these patches on top of qcom-next and the u-boot specific DTS hacks are removed.

USB phy init seems to fail for me, but the board I'm testing on is some super early DVT so I'm hoping it's a silicon issue....

Please give these a spin and let me know how it goes.

https://lore.kernel.org/u-boot/[email protected]

Kind regards,>

Quoted 1 line

-Sumit

Signature · 1 line
Caleb (they/them)
author
#7 lore raw

Re: [PATCH 1/2] arm: dts: Add override for RB1

Quoted 49 lines · Caleb Connolly
Quoted 46 lines · Sumit Garg
Quoted 44 lines · Caleb Connolly
Quoted 35 lines · Sumit Garg
Quoted 25 lines · Caleb Connolly
Quoted 22 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1 works fine though.

---
    arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
    1 file changed, 11 insertions(+)
    create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
new file mode 100644
index 00000000000..1e136ee405a
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
Quoted 8 lines

arch/arm/dts/qrb2210-rb1-u-boot.dtsi line 8

Quoted 4 lines
arch/arm/dts/qrb2210-rb1-u-boot.dtsi new file +4 -0
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */

I'd rather avoid disabling this here, I guess it's just missing clocks and regulators which doesn't justify modifying DT. An error that mmc1 couldn't be enabled seems fine to me?

Quoted 3 lines

I totally echo with your thinking that we should avoid modifying DT but at the same point we shouldn't enable peripherals in U-Boot which throws errors. It's also possible that U-Boot misconfiguring mmc1 which might

I disagree, DT isn't enabling or disabling peripherals, it's describing hardware.

Quoted 8 lines
Quoted 2 lines

It would be helpful if you can describe the use-case for "status" property then.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#status

These all describe the functionality of hardware, since implementation details of the software (U-Boot) which is parsing the DT has absolutely nothing to do with it.

Generally in Linux, we don't enable complete hardware support in one go but it is rather incremently enabled where people make use of this "status" property. So IMHO, it shouldn't be anything different for U-Boot too.

Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

U-Boot lacking proper support for that hardware isn't a good justification to disable it. Especially since you might boot Linux with the same DT and now have no working sdcard for seemingly no reason.

We shouldn't use same DT unless both U-Boot and Linux support that without modifications and *not* being in a broken state. The similar argument holds true for USB OTG mode too.

Well, the main difference with the OTG fixup is that we undo it later on, so if we boot an OS with this DT it won't have the override -- our hacks aren't exposed.

It's really nice to see the fixups using OF_LIVE.

Quoted 16 lines
Quoted 16 lines
Quoted 5 lines

An error in U-Boot is exactly the behaviour we want to see, masking it only created confusion.> turn as a problem for later stages.

IMO, our first priority should be to fix U-Boot issues and then see if we can use unmodified DT.

Quoted 6 lines
Quoted 3 lines

I have been totally working with a remote lab to fix issues on RB1. I will soon get one on my desk then I will be able to fix mmc1 too.

In that case we can surely land the proper fixes for 2025.07 anyway, so I'd just keep the errors until then.

Quoted 8 lines
Quoted 4 lines

Fixing errors in mainline will help other people confidence who are trying to boot U-Boot on RB1. If you still have a strong preference to keep SD card support enabled in broken state then I can live with that until I fix it for real.

I decided to just have a crack at it and managed to get everything cleaned up. sdcard seems to work on my RB1 with these patches on top of qcom-next and the u-boot specific DTS hacks are removed.

Great, you beat me to that. I have dropped the RB1 DT override patch from the v2 [1] in favour of your patch-set.

Quoted 3 lines

USB phy init seems to fail for me, but the board I'm testing on is some super early DVT so I'm hoping it's a silicon issue....

I repoduced it on my remote RB1 setup. The PHY power on was broken by recent addition of SM660 platform support. I fixed that as part of v2 [1] too.

Quoted 4 lines

Please give these a spin and let me know how it goes.

https://lore.kernel.org/u-boot/[email protected]

It really works fine for me without any pinctrl error for SD card, thanks.

[1] https://patchwork.ozlabs.org/project/uboot/list/?series=452055

-Sumit

author
#8 lore raw

PATCH 2/2 qcom_defconfig: Disable MMC HS200 mode support

In reply to Sumit Garg

From: Sumit Garg <[email protected]>

Currently the msm_sdhci doesn't yet support DLL configurations which are required to enable bus speeds greater that 100MHz. So disable HS200 mode support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

---
 configs/qcom_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/qcom_defconfig +0 -1
index a2b54b95f19..537806450dc 100644
@@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
 CONFIG_MISC=y
 CONFIG_NVMEM=y
 CONFIG_I2C_EEPROM=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_MMC_SDHCI_MSM=y
Signature · 1 line
2.43.0
#9 lore raw

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

Quoted 7 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Currently the msm_sdhci doesn't yet support DLL configurations which are required to enable bus speeds greater that 100MHz. So disable HS200 mode support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

This fixes the write corruption issues? Nice find!!

Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine on other boards, would this reduce their performance?

Quoted 18 lines
---
  configs/qcom_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/qcom_defconfig +0 -1
index a2b54b95f19..537806450dc 100644
@@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
  CONFIG_MISC=y
  CONFIG_NVMEM=y
  CONFIG_I2C_EEPROM=y
-CONFIG_MMC_HS200_SUPPORT=y
  CONFIG_MMC_SDHCI=y
  CONFIG_MMC_SDHCI_ADMA=y
  CONFIG_MMC_SDHCI_MSM=y
Signature · 1 line
Caleb (they/them)
author
#10 lore raw

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

Quoted 5 lines · Caleb Connolly
Quoted 2 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Quoted 7 lines
Quoted 5 lines

Currently the msm_sdhci doesn't yet support DLL configurations which are required to enable bus speeds greater that 100MHz. So disable HS200 mode support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

This fixes the write corruption issues? Nice find!!

Yeah, thanks.

Quoted 3 lines

Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine on other boards, would this reduce their performance?

Yes this problem should affect all Qualcomm platforms but it hasn't been seen there as mostly SD cards available don't support HS200 mode. The SD cards usually works in high speed mode whose performance remains unaffected by this change. It only affects RB1/RB2 as eMMC flash on these support HS200 mode but the U-Boot driver currently is incapable of supporting that.

-Sumit

Quoted 23 lines
Quoted 19 lines
---
  configs/qcom_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/qcom_defconfig +0 -1
index a2b54b95f19..537806450dc 100644
@@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
  CONFIG_MISC=y
  CONFIG_NVMEM=y
  CONFIG_I2C_EEPROM=y
-CONFIG_MMC_HS200_SUPPORT=y
  CONFIG_MMC_SDHCI=y
  CONFIG_MMC_SDHCI_ADMA=y
  CONFIG_MMC_SDHCI_MSM=y
Signature · 1 line
Caleb (they/them)
Reviewed-by
#11 lore raw

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

Quoted 20 lines · Sumit Garg
Quoted 5 lines · Caleb Connolly
Quoted 2 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Quoted 7 lines
Quoted 5 lines

Currently the msm_sdhci doesn't yet support DLL configurations which are required to enable bus speeds greater that 100MHz. So disable HS200 mode support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

This fixes the write corruption issues? Nice find!!

Yeah, thanks.

Quoted 3 lines

Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine on other boards, would this reduce their performance?

Quoted 6 lines

Yes this problem should affect all Qualcomm platforms but it hasn't been seen there as mostly SD cards available don't support HS200 mode. The SD cards usually works in high speed mode whose performance remains unaffected by this change. It only affects RB1/RB2 as eMMC flash on these support HS200 mode but the U-Boot driver currently is incapable of supporting that.

Ok awesome. Could you include this info in the commit message? Then

Kind regards,>

Quoted 25 lines

-Sumit

Quoted 23 lines
Quoted 19 lines
---
   configs/qcom_defconfig | 1 -
   1 file changed, 1 deletion(-)
configs/qcom_defconfig +0 -1
index a2b54b95f19..537806450dc 100644
@@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
   CONFIG_MISC=y
   CONFIG_NVMEM=y
   CONFIG_I2C_EEPROM=y
-CONFIG_MMC_HS200_SUPPORT=y
   CONFIG_MMC_SDHCI=y
   CONFIG_MMC_SDHCI_ADMA=y
   CONFIG_MMC_SDHCI_MSM=y
Signature · 1 line
Caleb (they/them)
Signature · 1 line
Caleb (they/them)
author
#12 lore raw

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

Quoted 23 lines · Caleb Connolly
Quoted 20 lines · Sumit Garg
Quoted 5 lines · Caleb Connolly
Quoted 2 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Quoted 7 lines
Quoted 5 lines

Currently the msm_sdhci doesn't yet support DLL configurations which are required to enable bus speeds greater that 100MHz. So disable HS200 mode support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

This fixes the write corruption issues? Nice find!!

Yeah, thanks.

Quoted 3 lines

Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine on other boards, would this reduce their performance?

Quoted 8 lines
Quoted 6 lines

Yes this problem should affect all Qualcomm platforms but it hasn't been seen there as mostly SD cards available don't support HS200 mode. The SD cards usually works in high speed mode whose performance remains unaffected by this change. It only affects RB1/RB2 as eMMC flash on these support HS200 mode but the U-Boot driver currently is incapable of supporting that.

Ok awesome. Could you include this info in the commit message? Then

Sure, I can expand the commit message.

Quoted 3 lines

Thanks.

-Sumit