perf report: Skip unsupported new event types
PATCH v3 1/1 perf report: Skip unsupported new event types
perf report currently halts with an error when encountering unsupported new event types (event.type >= PERF_RECORD_HEADER_MAX). This patch modifies the behavior to skip these samples and continue processing the remaining events. Additionally, stops reporting if the new event size is not 8-byte aligned.
--- tools/perf/util/session.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
tools/perf/util/session.c +11 -2
@@ -1639,8 +1639,17 @@ static s64 perf_session__process_event(struct perf_session *session,if (session->header.needs_swap)event_swap (event,evlist__sample_id_all (evlist)); -if (event->header.type >=PERF_RECORD_HEADER_MAX ) -return -EINVAL ; +if (event->header.type >=PERF_RECORD_HEADER_MAX ) { +/* perf should not support unaligned event, stop here. */ +if (event->header.size %sizeof (u64)) +return -EINVAL ; + +/* This perf is outdated and does not support the latest event type. */ +ui__warning ("Unsupported type %u, please considering update perf.\n" , + event->header.type); +/* Skip unsupported/unaligned event by returning its size. */ +return event->header.size; + }events_stats__inc (&evlist->stats, event->header.type);
Signature · 1 line
2.49.0.604.gff1f9ca942-goog
Namhyung Kim
maintainerQuoted 22 lines · Chun-Tse Shao
perf reportcurrently halts with an error when encountering unsupported new event types (event.type >= PERF_RECORD_HEADER_MAX). This patch modifies the behavior to skip these samples and continue processing the remaining events. Additionally, stops reporting if the new event size is not 8-byte aligned.Signed-off-by Chun-Tse Shao <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Namhyung Kim <[email protected]>--- tools/perf/util/session.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)tools/perf/util/session.c +0
-1@@ -1639,8 +1639,17 @@ static s64 perf_session__process_event(struct perf_session *session,if (session->header.needs_swap)event_swap (event,evlist__sample_id_all (evlist)); -if (event->header.type >=PERF_RECORD_HEADER_MAX )
tools/perf/util/session.c static s64 perf_session__process_event(struct perf_session *session, · line 1650
Quoted 10 lines
tools/perf/util/session.c +9
-1-return -EINVAL ; +if (event->header.type >=PERF_RECORD_HEADER_MAX ) { +/* perf should not support unaligned event, stop here. */ +if (event->header.size %sizeof (u64)) +return -EINVAL ; + +/* This perf is outdated and does not support the latest event type. */ +ui__warning ("Unsupported type %u, please considering update perf.\n" , + event->header.type); +/* Skip unsupported/unaligned event by returning its size. */
This comment also needs update. Other than that looks good to me.
Thanks,
Namhyung
Quoted 8 lines
tools/perf/util/session.c +2
-0+return event->header.size; + }events_stats__inc (&evlist->stats, event->header.type);Signature · 1 line
2.49.0.604.gff1f9ca942-goog
Sorry for my oversight, just sent out v4.
Thanks,
CT
Quoted 48 lines · Namhyung Kim
Quoted 22 lines · Chun-Tse Shao
perf reportcurrently halts with an error when encountering unsupported new event types (event.type >= PERF_RECORD_HEADER_MAX). This patch modifies the behavior to skip these samples and continue processing the remaining events. Additionally, stops reporting if the new event size is not 8-byte aligned.Signed-off-by Chun-Tse Shao <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Namhyung Kim <[email protected]>--- tools/perf/util/session.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)tools/perf/util/session.c +0
-1@@ -1639,8 +1639,17 @@ static s64 perf_session__process_event(struct perf_session *session,if (session->header.needs_swap)event_swap (event,evlist__sample_id_all (evlist)); -if (event->header.type >=PERF_RECORD_HEADER_MAX )tools/perf/util/session.c static s64 perf_session__process_event(struct perf_session *session, · line 1650
Quoted 10 lines
tools/perf/util/session.c +9
-1-return -EINVAL ; +if (event->header.type >=PERF_RECORD_HEADER_MAX ) { +/* perf should not support unaligned event, stop here. */ +if (event->header.size %sizeof (u64)) +return -EINVAL ; + +/* This perf is outdated and does not support the latest event type. */ +ui__warning ("Unsupported type %u, please considering update perf.\n" , + event->header.type); +/* Skip unsupported/unaligned event by returning its size. */ This comment also needs update. Other than that looks good to me.
Thanks,
NamhyungQuoted 8 lines
tools/perf/util/session.c +2
-1+return event->header.size; + }events_stats__inc (&evlist->stats, event->header.type); --2.49.0.604.gff1f9ca942-goog