Skip to contentSkip to conversation

tests/unit: Bump test-replication timeout to 45 seconds

PATCH In review Kevin Wolf 2 participants 3 messages Jan 25, 2024 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Kevin Wolf

author
#0 lore raw

PATCH 1/1 tests/unit: Bump test-replication timeout to 45 seconds

We're seeing timeouts for this test on CI runs (specifically for ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the successful runs take about 27 or 28 seconds, which is not very far from the 30 seconds timeout.

Bump the timeout a bit to make failure less likely even on this CI host.

---
 tests/unit/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tests/unit/meson.build +2 -1
index 0659532122..db6398a0f4 100644
@@ -175,7 +175,8 @@ slow_tests = {
   'test-aio-multithread' : 120,
   'test-crypto-block' : 300,
   'test-crypto-tlscredsx509': 45,
-  'test-crypto-tlssession': 45
+  'test-crypto-tlssession': 45,
+  'test-replication': 45,
 }
 
 foreach test_name, extra: tests
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Kevin Wolf

We're seeing timeouts for this test on CI runs (specifically for ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the successful runs take about 27 or 28 seconds, which is not very far from the 30 seconds timeout.

Bump the timeout a bit to make failure less likely even on this CI host.

---
  tests/unit/meson.build | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
tests/unit/meson.build +0 -0
index 0659532122..db6398a0f4 100644

tests/unit/meson.build slow_tests = { · line 182

Quoted 9 lines
tests/unit/meson.build +2 -1
@@ -175,7 +175,8 @@ slow_tests = {
    'test-aio-multithread' : 120,
    'test-crypto-block' : 300,
    'test-crypto-tlscredsx509': 45,
-  'test-crypto-tlssession': 45
+  'test-crypto-tlssession': 45,
+  'test-replication': 45,
  }
 
  foreach test_name, extra: tests

I'd maybe even bump it to 60 seconds, just to be on the safe side.

Anyway:

author
#2 lore raw

Am 25.01.2024 um 18:05 hat Thomas Huth geschrieben:

Quoted 13 lines · Kevin Wolf
Quoted 12 lines

We're seeing timeouts for this test on CI runs (specifically for ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the successful runs take about 27 or 28 seconds, which is not very far from the 30 seconds timeout.

Bump the timeout a bit to make failure less likely even on this CI host.

---
  tests/unit/meson.build | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 15 lines

tests/unit/meson.build slow_tests = { · line 181

Quoted 13 lines
tests/unit/meson.build +2 -1
index 0659532122..db6398a0f4 100644
@@ -175,7 +175,8 @@ slow_tests = {
    'test-aio-multithread' : 120,
    'test-crypto-block' : 300,
    'test-crypto-tlscredsx509': 45,
-  'test-crypto-tlssession': 45
+  'test-crypto-tlssession': 45,
+  'test-replication': 45,
  }
  foreach test_name, extra: tests

I'd maybe even bump it to 60 seconds, just to be on the safe side.

Works for me, too. I can change it before sending a pull request.

Quoted 2 lines

Anyway:

Thanks!

Kevin