nvmet-tcp: fix nvme tcp ida memory leak
Subsystems (2)
PATCH 1/1 nvmet-tcp: fix nvme tcp ida memory leak
The nvmet_tcp_queue_ida should be destroy when the nvmet-tcp module exit.
Signed-off-by Guixin Liu <[email protected]>
--- drivers/nvme/target/tcp.c | 1 + 1 file changed, 1 insertion(+)
drivers/nvme/target/tcp.c +1 -0
@@ -2216,6 +2216,7 @@ static void __exit nvmet_tcp_exit(void)flush_workqueue (nvmet_wq);destroy_workqueue (nvmet_tcp_wq); +ida_destroy (&nvmet_tcp_queue_ida); }module_init (nvmet_tcp_init);
Signature · 1 line
2.43.0
Quoted 13 lines · Guixin Liu
The
nvmet_tcp_queue_idashould be destroy when the nvmet-tcp module exit.Signed-off-by Guixin Liu <[email protected]>--- drivers/nvme/target/tcp.c | 1 + 1 file changed, 1 insertion(+)drivers/nvme/target/tcp.c +0
-0
drivers/nvme/target/tcp.c static void __exit nvmet_tcp_exit(void) · line 2222
Quoted 7 lines
drivers/nvme/target/tcp.c +1
-0@@ -2216,6 +2216,7 @@ static void __exit nvmet_tcp_exit(void)flush_workqueue (nvmet_wq);destroy_workqueue (nvmet_tcp_wq); +ida_destroy (&nvmet_tcp_queue_ida); }module_init (nvmet_tcp_init);
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
-ck
Looks good:
Reviewed-by Christoph Hellwig <[email protected]>
Quoted 2 lines · Guixin Liu
The
nvmet_tcp_queue_idashould be destroy when the nvmet-tcp module exit.
Thanks, applied to nvme-6.8.