Skip to contentSkip to conversation

rt-tests: oslat should use MHz, not Mhz

PATCH In review Marcelo Tosatti 2 participants 2 messages Feb 1, 2024 – Feb 2, 2024

lore
Share & tools
lore

Marcelo Tosatti

author
#0 lore raw

PATCH 1/1 rt-tests: oslat should use MHz, not Mhz

Usage of Mhz, in oslat, is incorrect:

From https://www.nist.gov/pml/owm/writing-si-metric-system-units#:~:text=NOT%20250%20mms.-,Capitalization,the%20beginning%20of%20the%20sentence:

"When the unit is derived from the name of a person, the symbol or the first letter of the symbol is an uppercase letter (W for the unit "watt" or Pa for the unit "pascal")."

Signed-off-by Marcelo Tosatti <[email protected]>
Reported-by Chuck Newman <[email protected]>
src/oslat/oslat.c +1 -1
index 4bdca64..e398f20 100644
@@ -501,7 +501,7 @@ static void write_summary(struct thread *t)
 	calculate(t);
 
 	putfield("Core", t[i].core_i, "d", "");
-	putfield("Counter Freq", t[i].counter_mhz, "u", " (Mhz)");
+	putfield("Counter Freq", t[i].counter_mhz, "u", " (MHz)");
 
 	for (j = 0; j < g.bucket_size; j++) {
 		if (j < g.bucket_size-1 && g.output_omit_zero_buckets) {
#1 lore raw
Quoted 18 lines · Marcelo Tosatti

Usage of Mhz, in oslat, is incorrect:

From https://www.nist.gov/pml/owm/writing-si-metric-system-units#:~:text=NOT%20250%20mms.-,Capitalization,the%20beginning%20of%20the%20sentence:

"When the unit is derived from the name of a person, the symbol or the first letter of the symbol is an uppercase letter (W for the unit "watt" or Pa for the unit "pascal")."

Signed-off-by Marcelo Tosatti <[email protected]>
Reported-by Chuck Newman <[email protected]>
src/oslat/oslat.c +0 -0
index 4bdca64..e398f20 100644

src/oslat/oslat.c static void write_summary(struct thread *t) · line 507

Quoted 8 lines
src/oslat/oslat.c +1 -1
@@ -501,7 +501,7 @@ static void write_summary(struct thread *t)
 	calculate(t);
 
 	putfield("Core", t[i].core_i, "d", "");
-	putfield("Counter Freq", t[i].counter_mhz, "u", " (Mhz)");
+	putfield("Counter Freq", t[i].counter_mhz, "u", " (MHz)");
 
 	for (j = 0; j < g.bucket_size; j++) {
 		if (j < g.bucket_size-1 && g.output_omit_zero_buckets) {
Signed-off-by John Kacur <[email protected]>