cpuidle: do not shrink guest poll_limit_ns below grow_start
PATCH 1/1 cpuidle: do not shrink guest poll_limit_ns below grow_start
While adjusting guest halt poll limit, grow block starts at guest_halt_poll_grow_start without taking intermediate values. Similar behavior is expected while shrinking the value. This avoids short interval values which are really not required.
VCPU1 trace (guest_halt_poll_shrink equals 2):
VCPU1 grow 10000
VCPU1 shrink 5000
VCPU1 shrink 2500
VCPU1 shrink 1250
VCPU1 shrink 625
VCPU1 shrink 312
VCPU1 shrink 156
VCPU1 shrink 78
VCPU1 shrink 39
VCPU1 shrink 19
VCPU1 shrink 9
VCPU1 shrink 4
Similar change is done in KVM halt poll flow with below patch:
--- drivers/cpuidle/governors/haltpoll.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/cpuidle/governors/haltpoll.c +7 -2
@@ -98,10 +98,15 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)unsigned int shrink = guest_halt_poll_shrink; val = dev->poll_limit_ns; -if (shrink ==0 ) +if (shrink ==0 ) { val =0 ; -else + }else { val /= shrink; +/* Reset value to 0 if shrunk below grow_start */ +if (val < guest_halt_poll_grow_start) + val =0 ; + } +trace_guest_halt_poll_ns_shrink (val, dev->poll_limit_ns); dev->poll_limit_ns = val; }
Signature · 1 line
2.17.1
Quoted 57 lines · Parshuram Sangle
While adjusting guest halt poll limit, grow block starts at
guest_halt_poll_grow_startwithout taking intermediate values. Similar behavior is expected while shrinking the value. This avoids short interval values which are really not required.VCPU1 trace (
guest_halt_poll_shrinkequals 2):VCPU1 grow 10000
VCPU1 shrink 5000
VCPU1 shrink 2500
VCPU1 shrink 1250
VCPU1 shrink 625
VCPU1 shrink 312
VCPU1 shrink 156
VCPU1 shrink 78
VCPU1 shrink 39
VCPU1 shrink 19
VCPU1 shrink 9
VCPU1 shrink 4Similar change is done in KVM halt poll flow with below patch:
Co-developed-by Rajendran Jaishankar <[email protected]>Signed-off-by Rajendran Jaishankar <[email protected]>Signed-off-by Parshuram Sangle <[email protected]>--- drivers/cpuidle/governors/haltpoll.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/cpuidle/governors/haltpoll.c +7
-2@@ -98,10 +98,15 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)unsigned int shrink = guest_halt_poll_shrink; val = dev->poll_limit_ns; -if (shrink ==0 ) +if (shrink ==0 ) { val =0 ; -else + }else { val /= shrink; +/* Reset value to 0 if shrunk below grow_start */ +if (val < guest_halt_poll_grow_start) + val =0 ; + } +trace_guest_halt_poll_ns_shrink (val, dev->poll_limit_ns); dev->poll_limit_ns = val; }Signature · 1 line
2.17.1
Looks good.
Quoted 62 lines · Marcelo Tosatti
Quoted 53 lines · Parshuram Sangle
While adjusting guest halt poll limit, grow block starts at
guest_halt_poll_grow_startwithout taking intermediate values. Similar behavior is expected while shrinking the value. This avoids short interval values which are really not required.VCPU1 trace (
guest_halt_poll_shrinkequals 2):VCPU1 grow 10000
VCPU1 shrink 5000
VCPU1 shrink 2500
VCPU1 shrink 1250
VCPU1 shrink 625
VCPU1 shrink 312
VCPU1 shrink 156
VCPU1 shrink 78
VCPU1 shrink 39
VCPU1 shrink 19
VCPU1 shrink 9
VCPU1 shrink 4Similar change is done in KVM halt poll flow with below patch:
Co-developed-by Rajendran Jaishankar <[email protected]>Signed-off-by Rajendran Jaishankar <[email protected]>Signed-off-by Parshuram Sangle <[email protected]>--- drivers/cpuidle/governors/haltpoll.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/cpuidle/governors/haltpoll.c +7
-3@@ -98,10 +98,15 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)unsigned int shrink = guest_halt_poll_shrink; val = dev->poll_limit_ns; -if (shrink ==0 ) +if (shrink ==0 ) { val =0 ; -else + }else { val /= shrink; +/* Reset value to 0 if shrunk below grow_start */ +if (val < guest_halt_poll_grow_start) + val =0 ; + } +trace_guest_halt_poll_ns_shrink (val, dev->poll_limit_ns); dev->poll_limit_ns = val; } --Quoted 4 lines
2.17.1
Looks good.
Quoted 1 line
Reviewed-by Marcelo Tosatti <[email protected]>
Applied as 6.9 (with a minor change in the subject), thanks!