wireless-regdb key change broke crda tests after 37dcea0e6e5
Hi crda and wireless-regdb maintainers!
nixpkgs attempted to update to latest wireless-regdb-2024.01.23 from 2024.01.23 and got crda verification failures at
https://github.com/NixOS/nixpkgs/pull/286012:
crda> make verify
crda> CHK ...-wireless-regdb-2024.01.23/lib/crda/regulatory.bin
crda> Database signature verification failed.
crda> Invalid or empty regulatory file, note: a binary regulatory file should be used. crda> make: *** [Makefile:161: verify] Error 234
Bisect says the suspect is key change at done by https://git.kernel.org/pub/scm/linux/kernel/git/wens/wireless-regdb.git/commit/?id=37dcea0e6e5effb4228fe385e906edba3cbee389
"wireless-regdb: Update keys and maintainer information".
Both git master version of crda and wireless-regdb still fail crda's make verify.
Should crda key the key update as well?
Thanks!
Signature · 1 line
Sergei
Hi,
Quoted 6 lines
"wireless-regdb: Update keys and maintainer information".
Both
gitmasterversion ofcrdaandwireless-regdbstill failcrda'smake verify.Should
crdakey the key update as well?
Maybe?
But perhaps the real question is if you should still be shipping crda? It was last needed for kernel 4.15, and even the newest stable kernel based on or before it (4.14) is now EOL ...
After that, we had the regdb loaded like a firmware file including the signatures, so the whole crda isn't needed any more.
johannes
Quoted 9 lines · On Tue, 06 Feb 2024 12:47:35 +0100 Johannes Berg <[email protected]>…
Hi,
Quoted 6 lines
"wireless-regdb: Update keys and maintainer information".
Both
gitmasterversion ofcrdaandwireless-regdbstill failcrda'smake verify.Should
crdakey the key update as well?
Quoted 8 lines
Maybe?
But perhaps the real question is if you should still be shipping crda? It was last needed for kernel 4.15, and even the newest stable kernel based on or before it (4.14) is now EOL ...
After that, we had the regdb loaded like a firmware file including the signatures, so the whole crda isn't needed any more.
Great point! nixpkgs uses crda only as a hostapd depend and looking at modern hostapd it does not use it at all. I'll spend some time removing it downstream. Thank you!
Signature · 1 line
Sergei
Quoted 4 lines · Sergei Trofimovich
Great point!
nixpkgsusescrdaonly as ahostapddepend and looking at modernhostapdit does not use it at all. I'll spend some time removing it downstream. Thank you!
Note that hostapd never directly depended on crda, it just needs/wants it to have the correct regulatory information in the kernel (crda puts it there) after switching the country (hostapd can do that if possible) and then hostapd retrieves the information.
But in any case, the whole step with crda is no longer needed if you have the regulatory file (and possibly signature) in place, the firmware will load them as firmware files.
johannes
Quoted 6 lines · Johannes Berg
Quoted 4 lines · Sergei Trofimovich
Great point!
nixpkgsusescrdaonly as ahostapddepend and looking at modernhostapdit does not use it at all. I'll spend some time removing it downstream. Thank you!
Quoted 8 lines
Note that hostapd never directly depended on crda, it just needs/wants it to have the correct regulatory information in the kernel (crda puts it there) after switching the country (hostapd can do that if possible) and then hostapd retrieves the information.
But in any case, the whole step with crda is no longer needed if you have the regulatory file (and possibly signature) in place, the firmware will load them as firmware files.
I assume you mean: the kernel will load them as firmware files.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 13 lines · Kalle Valo
Quoted 11 lines · Johannes Berg
Quoted 4 lines · Sergei Trofimovich
Great point!
nixpkgsusescrdaonly as ahostapddepend and looking at modernhostapdit does not use it at all. I'll spend some time removing it downstream. Thank you!Note that hostapd never directly depended on crda, it just needs/wants it to have the correct regulatory information in the kernel (crda puts it there) after switching the country (hostapd can do that if possible) and then hostapd retrieves the information.
Quoted 6 lines
Quoted 3 lines
But in any case, the whole step with crda is no longer needed if you have the regulatory file (and possibly signature) in place, the firmware will load them as firmware files.
I assume you mean: the kernel will load them as firmware files.
Haha, indeed, sorry.
johannes