Skip to contentSkip to conversation

wifi: ath11k: adjust a comment to reflect reality

PATCH In review Kevin Lo 3 participants 5 messages Mar 4, 2024 – Mar 11, 2024 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore

Kevin Lo

author
#0 lore raw

PATCH v2 1/1 wifi: ath11k: adjust a comment to reflect reality

On QCA6390/QCN9074/WCN6855, MHISTATUS may still have SYSERR bit set after SOC_GLOBAL_RESET.

changes for v2:
- update comment about resetting MHICTRL to clear SYSERR

---

drivers/net/wireless/ath/ath11k/mhi.c +2 -3
index fb4ecf9a103e..956fff0d4962 100644
@@ -158,9 +158,8 @@ void ath11k_mhi_set_mhictrl_reset(struct ath11k_base *ab)
 
 	ath11k_dbg(ab, ATH11K_DBG_PCI, "mhistatus 0x%x\n", val);
 
-	/* Observed on QCA6390 that after SOC_GLOBAL_RESET, MHISTATUS
-	 * has SYSERR bit set and thus need to set MHICTRL_RESET
-	 * to clear SYSERR.
+	/* After SOC_GLOBAL_RESET, MHISTATUS may still have SYSERR bit set 
+	 * and thus need to set MHICTRL_RESET to clear SYSERR.
 	 */
 	ath11k_pcic_write32(ab, MHICTRL, MHICTRL_RESET_MASK);
 
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · Kevin Lo

On QCA6390/QCN9074/WCN6855, MHISTATUS may still have SYSERR bit set after SOC_GLOBAL_RESET.

changes for v2:
- update comment about resetting MHICTRL to clear SYSERR

for future reference the version log should not be part of the commit text

Quoted 3 lines

---

the version log goes here, after the --- ("after the cut")

but no need to send another version -- Kalle can fix this when he pulls into the pending branch.

#2 lore raw
In reply to Kevin Lo
Quoted 7 lines · Kevin Lo

On QCA6390/QCN9074/WCN6855, MHISTATUS may still have SYSERR bit set after SOC_GLOBAL_RESET.

changes for v2:
- update comment about resetting MHICTRL to clear SYSERR

This didn't apply and I manually edited the patch. I also removed the changelog from the commit message, please check my changes:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=709cd1c88a11bc1969cf573575b0a2027e720146

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw
Quoted 8 lines · Kalle Valo
Quoted 6 lines · Kevin Lo

On QCA6390/QCN9074/WCN6855, MHISTATUS may still have SYSERR bit set after SOC_GLOBAL_RESET.

changes for v2:
- update comment about resetting MHICTRL to clear SYSERR

Quoted 7 lines
Quoted 1 line

This didn't apply and I manually edited the patch. I also removed the changelog from the commit message, please check my changes:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=709cd1c88a11bc1969cf573575b0a2027e720146

LGTM

#4 lore raw
In reply to Kevin Lo
Quoted 6 lines · Kevin Lo

On QCA6390/QCN9074/WCN6855, MHISTATUS may still have SYSERR bit set after SOC_GLOBAL_RESET.

Patch applied to ath-next branch of ath.git, thanks.

a368b0a9854e wifi: ath11k: adjust a comment to reflect reality

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches